linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Sottas Guillaume (LMB)" <Guillaume.Sottas@liebherr.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"socketcan@hartkopp.net" <socketcan@hartkopp.net>
Subject: Re: [PATCH] can: isotp: return -ECOMM on FC timeout on TX path
Date: Thu, 6 May 2021 15:38:20 +0200	[thread overview]
Message-ID: <20210506133820.ynabngerxtc5vsea@pengutronix.de> (raw)
In-Reply-To: <b70da5bc15974457b172794ef1149a99@liebherr.com>

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]

On 06.05.2021 12:45:38, Sottas Guillaume (LMB) wrote:
> Thank you for your investigations, seems to be the way to go? What is
> the next step, could I help in any way or are you going to merge your
> patch directly? I'm not really sure how we should go further in order
> to inegrate your fix in the code...

Maybe we can use sk->sk_err directly instead of adding a new variable.
I've send a patch, please test.

> Thank you in advance for your feedback,

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-05-06 13:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 12:45 [PATCH] can: isotp: return -ECOMM on FC timeout on TX path Sottas Guillaume (LMB)
2021-05-06 13:38 ` Marc Kleine-Budde [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-28 11:43 Sottas Guillaume (LMB)
2021-04-28 11:48 ` Oliver Hartkopp
2021-04-28  9:09 Marc Kleine-Budde
2021-04-28  9:12 ` Marc Kleine-Budde
2021-04-28  9:26   ` Oliver Hartkopp
2021-04-28 10:24     ` Oliver Hartkopp
2021-04-28 10:47       ` Marc Kleine-Budde
2021-04-28 11:45         ` Oliver Hartkopp
2021-04-28 12:07           ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210506133820.ynabngerxtc5vsea@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=Guillaume.Sottas@liebherr.com \
    --cc=linux-can@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).