linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Angelo Dureghello <angelo@kernel-space.org>
Cc: gerg@linux-m68k.org, wg@grandegger.com, geert@linux-m68k.org,
	linux-m68k@vger.kernel.org, linux-can@vger.kernel.org,
	qiangqing.zhang@nxp.com
Subject: Re: [PATCH v2 5/5] can: flexcan: add mcf5441x support
Date: Fri, 18 Jun 2021 08:57:34 +0200	[thread overview]
Message-ID: <20210618065734.vsjx6pvnbqdzmfqe@pengutronix.de> (raw)
In-Reply-To: <b6b948f4-dcdb-5f75-9fe8-138de0acf1f7@kernel-space.org>

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]

On 18.06.2021 00:14:32, Angelo Dureghello wrote:
> On 17/06/21 3:00 PM, Marc Kleine-Budde wrote:
> > On 17.06.2021 01:16:52, Angelo Dureghello wrote:
> > > Add flexcan support for NXP ColdFire mcf5441x family.
> > > 
> > > This flexcan module is quite similar to imx6 flexcan module, but
> > > with some exceptions:
> > > 
> > > - 3 separate interrupt sources, MB, BOFF and ERR,
> > > - implements 16 mb only,
> > > - m68k architecture is not supporting devicetrees, so a
> > >    platform data check/case has been added,
> > > - ColdFire is m68k, so big-endian cpu, with a little-endian flexcan
> > >    module.
> > 
> > Please add the mcg5441x to the "FLEXCAN hardware feature flags" table in
> > the driver, and add a new column for the number of mailboxes.
> 
> need a little help here: where can i find IP version and
> FlexCAN version ? I am 90% sure mcf5441x is FlexCAN2 (no FD).
> No trace of IP version in the datasheets.

The normal datasheets don't list the IP version. If you don't work for a
company integrating the flexcan core into a SoC, you probably don't have
access to the "low level" datasheets or the people who can look into
them. So just add a ? for details you don't know.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-06-18  7:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 23:16 [PATCH v2 1/5] can: flexcan: add platform data for ColdFire Angelo Dureghello
2021-06-16 23:16 ` [PATCH v2 2/5] m68k: stmark2: update board setup Angelo Dureghello
2021-06-16 23:16 ` [PATCH v2 3/5] m68k: m5441x: add flexcan support Angelo Dureghello
2021-06-17  0:18   ` Greg Ungerer
2021-06-17  7:17     ` Angelo Dureghello
2021-06-16 23:16 ` [PATCH v2 4/5] can: flexcan: enable Kconfig for ColdFire Angelo Dureghello
2021-06-17 15:27   ` Marc Kleine-Budde
2021-06-16 23:16 ` [PATCH v2 5/5] can: flexcan: add mcf5441x support Angelo Dureghello
2021-06-17 13:00   ` Marc Kleine-Budde
2021-06-17 13:32     ` Angelo Dureghello
2021-06-17 22:14     ` Angelo Dureghello
2021-06-18  6:57       ` Marc Kleine-Budde [this message]
2021-06-17 19:38   ` Marc Kleine-Budde
2021-06-18  7:59     ` Angelo Dureghello
2021-06-17  0:17 ` [PATCH v2 1/5] can: flexcan: add platform data for ColdFire Greg Ungerer
2021-06-17  7:23   ` Angelo Dureghello
2021-06-17  8:29     ` Marc Kleine-Budde
2021-06-17 11:45     ` Marc Kleine-Budde
2021-06-17  8:28 ` Geert Uytterhoeven
2021-06-17  8:31   ` Angelo Dureghello
2021-06-17 19:40 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210618065734.vsjx6pvnbqdzmfqe@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=angelo@kernel-space.org \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=qiangqing.zhang@nxp.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).