From: Angelo Dureghello <angelo@kernel-space.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Ungerer <gerg@linux-m68k.org>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Linux/m68k <linux-m68k@vger.kernel.org>,
linux-can@vger.kernel.org, Joakim Zhang <qiangqing.zhang@nxp.com>
Subject: Re: [PATCH v2 1/5] can: flexcan: add platform data for ColdFire
Date: Thu, 17 Jun 2021 10:31:41 +0200 [thread overview]
Message-ID: <21f07ecf-d222-46ef-b75e-28f647587551@kernel-space.org> (raw)
In-Reply-To: <CAMuHMdXNsPnaP6xwm0=2naydnxPs2k2ivLTNnrE_bGnhORmaBQ@mail.gmail.com>
Hi Geert,
On 17/06/21 10:28 AM, Geert Uytterhoeven wrote:
> Hi Angelo,
>
> On Thu, Jun 17, 2021 at 1:17 AM Angelo Dureghello
> <angelo@kernel-space.org> wrote:
>> Add platform data object for ColdFire architecture.
>>
>> ---
>> Changes for v2:
>> - move header file in more proper location
>> - remove irq defines
>> - change variable types to match driver types
>>
>> Signed-off-by: Angelo Dureghello <angelo@kernel-space.org>
>
> Thanks for your patch!
>
>> --- /dev/null
>> +++ b/include/linux/can/platform/mcf5441x.h
>> @@ -0,0 +1,28 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/*
>> + * Flexcan options for ColdFire family
>> + *
>> + * Copyright (C) 2021 Angelo Dureghello <angelo@kernel-space.org>
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License
>> + * version 2 as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +#ifndef _PLAT_FLEXCAN_MCF_H
>> +#define _PLAT_FLEXCAN_MCF_H
>> +
>> +struct mcf_flexcan_platform_data {
>> + u8 clk_src;
>> + u32 clock_frequency;
>> + bool big_endian;
>
> Please sort the members according to decreasing size, to avoid
> holes.
sure, never thought to this, thanks,
>
>> +};
>> +
>> +#define FLEXCAN_MCF5411X_MB_CNT_MCF 16
>> +
>> +#endif /* _PLAT_FLEXCAN_MCF_H */
>
> Gr{oetje,eeting}s,
>
> Geert
>
Regards,
angelo
next prev parent reply other threads:[~2021-06-17 8:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 23:16 [PATCH v2 1/5] can: flexcan: add platform data for ColdFire Angelo Dureghello
2021-06-16 23:16 ` [PATCH v2 2/5] m68k: stmark2: update board setup Angelo Dureghello
2021-06-16 23:16 ` [PATCH v2 3/5] m68k: m5441x: add flexcan support Angelo Dureghello
2021-06-17 0:18 ` Greg Ungerer
2021-06-17 7:17 ` Angelo Dureghello
2021-06-16 23:16 ` [PATCH v2 4/5] can: flexcan: enable Kconfig for ColdFire Angelo Dureghello
2021-06-17 15:27 ` Marc Kleine-Budde
2021-06-16 23:16 ` [PATCH v2 5/5] can: flexcan: add mcf5441x support Angelo Dureghello
2021-06-17 13:00 ` Marc Kleine-Budde
2021-06-17 13:32 ` Angelo Dureghello
2021-06-17 22:14 ` Angelo Dureghello
2021-06-18 6:57 ` Marc Kleine-Budde
2021-06-17 19:38 ` Marc Kleine-Budde
2021-06-18 7:59 ` Angelo Dureghello
2021-06-17 0:17 ` [PATCH v2 1/5] can: flexcan: add platform data for ColdFire Greg Ungerer
2021-06-17 7:23 ` Angelo Dureghello
2021-06-17 8:29 ` Marc Kleine-Budde
2021-06-17 11:45 ` Marc Kleine-Budde
2021-06-17 8:28 ` Geert Uytterhoeven
2021-06-17 8:31 ` Angelo Dureghello [this message]
2021-06-17 19:40 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21f07ecf-d222-46ef-b75e-28f647587551@kernel-space.org \
--to=angelo@kernel-space.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=qiangqing.zhang@nxp.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).