Re: [PATCH can-utils-dev 2/5] lib: add pr_debug() macro - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: linux-can@vger.kernel.org, Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH can-utils-dev 2/5] lib: add pr_debug() macro
Date: Sun, 13 Nov 2022 14:03:25 +0100	[thread overview]
Message-ID: <20221113130325.5tagqsi4t4523uob@pengutronix.de> (raw)
In-Reply-To: <20221113085321.87910-3-mailhol.vincent@wanadoo.fr>

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

On 13.11.2022 17:53:18, Vincent Mailhol wrote:

> diff --git a/mcp251xfd/mcp251xfd-dev-coredump.c b/mcp251xfd/mcp251xfd-dev-coredump.c
> index 5874d24..422900f 100644
> --- a/mcp251xfd/mcp251xfd-dev-coredump.c
> +++ b/mcp251xfd/mcp251xfd-dev-coredump.c
> @@ -17,18 +17,10 @@
>  
>  #include <linux/kernel.h>
>  
> +#include "../lib.h"

Does #include <lib.h> work?

>  #include "mcp251xfd.h"
>  #include "mcp251xfd-dump-userspace.h"
>  
> -#define pr_err(fmt, args...)    fprintf(stderr, fmt, ##args)
> -#define pr_no(fmt, args...)     while (0) { fprintf(stdout, fmt, ##args); }
> -
> -#ifdef DEBUG
> -#define pr_debug(fmt, args...) pr_err(fmt, ##args)
> -#else
> -#define pr_debug(fmt, args...) pr_no(fmt, ##args)
> -#endif
> -
>  
>  struct mcp251xfd_dump_iter {
>  	const void *start;

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]