* Re: [PATCH net-next] net: af_can: remove useless parameter 'err' in 'can_rx_register()'
2022-12-08 9:09 [PATCH net-next] net: af_can: remove useless parameter 'err' in 'can_rx_register()' Ye Bin
@ 2022-12-08 9:06 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2022-12-08 9:06 UTC (permalink / raw)
To: Ye Bin
Cc: socketcan, davem, edumazet, kuba, pabeni, linux-can, netdev, yebin10
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
On 08.12.2022 17:09:40, Ye Bin wrote:
> From: Ye Bin <yebin10@huawei.com>
>
> Since commit bdfb5765e45b remove NULL-ptr checks from users of
> can_dev_rcv_lists_find(). 'err' parameter is useless, so remove it.
>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
Applied to linux-can-next.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH net-next] net: af_can: remove useless parameter 'err' in 'can_rx_register()'
@ 2022-12-08 9:09 Ye Bin
2022-12-08 9:06 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Ye Bin @ 2022-12-08 9:09 UTC (permalink / raw)
To: socketcan, mkl, davem, edumazet, kuba, pabeni, linux-can, netdev; +Cc: yebin10
From: Ye Bin <yebin10@huawei.com>
Since commit bdfb5765e45b remove NULL-ptr checks from users of
can_dev_rcv_lists_find(). 'err' parameter is useless, so remove it.
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
net/can/af_can.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/can/af_can.c b/net/can/af_can.c
index 27dcdcc0b808..ec3f7e658295 100644
--- a/net/can/af_can.c
+++ b/net/can/af_can.c
@@ -446,7 +446,6 @@ int can_rx_register(struct net *net, struct net_device *dev, canid_t can_id,
struct hlist_head *rcv_list;
struct can_dev_rcv_lists *dev_rcv_lists;
struct can_rcv_lists_stats *rcv_lists_stats = net->can.rcv_lists_stats;
- int err = 0;
/* insert new receiver (dev,canid,mask) -> (func,data) */
@@ -481,7 +480,7 @@ int can_rx_register(struct net *net, struct net_device *dev, canid_t can_id,
rcv_lists_stats->rcv_entries);
spin_unlock_bh(&net->can.rcvlists_lock);
- return err;
+ return 0;
}
EXPORT_SYMBOL(can_rx_register);
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-08 9:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-08 9:09 [PATCH net-next] net: af_can: remove useless parameter 'err' in 'can_rx_register()' Ye Bin
2022-12-08 9:06 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).