* [PATCH net 0/3] pull-request: can 2022-12-19
@ 2022-12-19 15:52 Marc Kleine-Budde
2022-12-19 15:52 ` [PATCH net 1/3] Documentation: devlink: add missing toc entry for etas_es58x devlink doc Marc Kleine-Budde
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Marc Kleine-Budde @ 2022-12-19 15:52 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, linux-can, kernel
Hello Jakub, hello David,
this is a pull request of 3 patches for net/master.
The first patch is by Vincent Mailhol and adds the etas_es58x devlink
documentation to the index.
Haibo Chen's patch for the flexcan driver fixes a unbalanced
pm_runtime_enable warning.
The last patch is by me, targets the kvaser_usb driver and fixes an
error occurring with gcc-13.
regards,
Marc
---
The following changes since commit 2856a62762c8409e360d4fd452194c8e57ba1058:
mctp: serial: Fix starting value for frame check sequence (2022-12-19 12:38:45 +0000)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-6.2-20221219
for you to fetch changes up to f006229135b7debf4037adb1eb93e358559593db:
can: kvaser_usb: hydra: help gcc-13 to figure out cmd_len (2022-12-19 16:08:27 +0100)
----------------------------------------------------------------
linux-can-fixes-for-6.2-20221219
----------------------------------------------------------------
Haibo Chen (1):
can: flexcan: avoid unbalanced pm_runtime_enable warning
Marc Kleine-Budde (1):
can: kvaser_usb: hydra: help gcc-13 to figure out cmd_len
Vincent Mailhol (1):
Documentation: devlink: add missing toc entry for etas_es58x devlink doc
Documentation/networking/devlink/index.rst | 1 +
drivers/net/can/flexcan/flexcan-core.c | 12 ++++++---
drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 33 ++++++++++++++++-------
3 files changed, 34 insertions(+), 12 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH net 1/3] Documentation: devlink: add missing toc entry for etas_es58x devlink doc 2022-12-19 15:52 [PATCH net 0/3] pull-request: can 2022-12-19 Marc Kleine-Budde @ 2022-12-19 15:52 ` Marc Kleine-Budde 2022-12-19 18:14 ` Jacob Keller 2022-12-20 2:00 ` patchwork-bot+netdevbpf 2022-12-19 15:52 ` [PATCH net 2/3] can: flexcan: avoid unbalanced pm_runtime_enable warning Marc Kleine-Budde 2022-12-19 15:52 ` [PATCH net 3/3] can: kvaser_usb: hydra: help gcc-13 to figure out cmd_len Marc Kleine-Budde 2 siblings, 2 replies; 6+ messages in thread From: Marc Kleine-Budde @ 2022-12-19 15:52 UTC (permalink / raw) To: netdev Cc: davem, kuba, linux-can, kernel, Vincent Mailhol, Stephen Rothwell, kernel test robot, Marc Kleine-Budde From: Vincent Mailhol <mailhol.vincent@wanadoo.fr> toc entry is missing for etas_es58x devlink doc and triggers this warning: Documentation/networking/devlink/etas_es58x.rst: WARNING: document isn't included in any toctree Add the missing toc entry. Fixes: 9f63f96aac92 ("Documentation: devlink: add devlink documentation for the etas_es58x driver") Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> Link: https://lore.kernel.org/all/20221213051136.721887-1-mailhol.vincent@wanadoo.fr Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- Documentation/networking/devlink/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/networking/devlink/index.rst b/Documentation/networking/devlink/index.rst index 4b653d040627..fee4d3968309 100644 --- a/Documentation/networking/devlink/index.rst +++ b/Documentation/networking/devlink/index.rst @@ -50,6 +50,7 @@ parameters, info versions, and other features it supports. :maxdepth: 1 bnxt + etas_es58x hns3 ionic ice base-commit: 2856a62762c8409e360d4fd452194c8e57ba1058 -- 2.35.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net 1/3] Documentation: devlink: add missing toc entry for etas_es58x devlink doc 2022-12-19 15:52 ` [PATCH net 1/3] Documentation: devlink: add missing toc entry for etas_es58x devlink doc Marc Kleine-Budde @ 2022-12-19 18:14 ` Jacob Keller 2022-12-20 2:00 ` patchwork-bot+netdevbpf 1 sibling, 0 replies; 6+ messages in thread From: Jacob Keller @ 2022-12-19 18:14 UTC (permalink / raw) To: Marc Kleine-Budde, netdev Cc: davem, kuba, linux-can, kernel, Vincent Mailhol, Stephen Rothwell, kernel test robot On 12/19/2022 7:52 AM, Marc Kleine-Budde wrote: > From: Vincent Mailhol <mailhol.vincent@wanadoo.fr> > > toc entry is missing for etas_es58x devlink doc and triggers this warning: > > Documentation/networking/devlink/etas_es58x.rst: WARNING: document isn't included in any toctree > > Add the missing toc entry. > > Fixes: 9f63f96aac92 ("Documentation: devlink: add devlink documentation for the etas_es58x driver") > Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> > Link: https://lore.kernel.org/all/20221213051136.721887-1-mailhol.vincent@wanadoo.fr > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > Documentation/networking/devlink/index.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/networking/devlink/index.rst b/Documentation/networking/devlink/index.rst > index 4b653d040627..fee4d3968309 100644 > --- a/Documentation/networking/devlink/index.rst > +++ b/Documentation/networking/devlink/index.rst > @@ -50,6 +50,7 @@ parameters, info versions, and other features it supports. > :maxdepth: 1 > > bnxt > + etas_es58x > hns3 > ionic > ice > > base-commit: 2856a62762c8409e360d4fd452194c8e57ba1058 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net 1/3] Documentation: devlink: add missing toc entry for etas_es58x devlink doc 2022-12-19 15:52 ` [PATCH net 1/3] Documentation: devlink: add missing toc entry for etas_es58x devlink doc Marc Kleine-Budde 2022-12-19 18:14 ` Jacob Keller @ 2022-12-20 2:00 ` patchwork-bot+netdevbpf 1 sibling, 0 replies; 6+ messages in thread From: patchwork-bot+netdevbpf @ 2022-12-20 2:00 UTC (permalink / raw) To: Marc Kleine-Budde Cc: netdev, davem, kuba, linux-can, kernel, mailhol.vincent, sfr, lkp Hello: This series was applied to netdev/net.git (master) by Marc Kleine-Budde <mkl@pengutronix.de>: On Mon, 19 Dec 2022 16:52:08 +0100 you wrote: > From: Vincent Mailhol <mailhol.vincent@wanadoo.fr> > > toc entry is missing for etas_es58x devlink doc and triggers this warning: > > Documentation/networking/devlink/etas_es58x.rst: WARNING: document isn't included in any toctree > > Add the missing toc entry. > > [...] Here is the summary with links: - [net,1/3] Documentation: devlink: add missing toc entry for etas_es58x devlink doc https://git.kernel.org/netdev/net/c/115dd5469019 - [net,2/3] can: flexcan: avoid unbalanced pm_runtime_enable warning https://git.kernel.org/netdev/net/c/3bc2afcba812 - [net,3/3] can: kvaser_usb: hydra: help gcc-13 to figure out cmd_len https://git.kernel.org/netdev/net/c/f006229135b7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH net 2/3] can: flexcan: avoid unbalanced pm_runtime_enable warning 2022-12-19 15:52 [PATCH net 0/3] pull-request: can 2022-12-19 Marc Kleine-Budde 2022-12-19 15:52 ` [PATCH net 1/3] Documentation: devlink: add missing toc entry for etas_es58x devlink doc Marc Kleine-Budde @ 2022-12-19 15:52 ` Marc Kleine-Budde 2022-12-19 15:52 ` [PATCH net 3/3] can: kvaser_usb: hydra: help gcc-13 to figure out cmd_len Marc Kleine-Budde 2 siblings, 0 replies; 6+ messages in thread From: Marc Kleine-Budde @ 2022-12-19 15:52 UTC (permalink / raw) To: netdev; +Cc: davem, kuba, linux-can, kernel, Haibo Chen, Marc Kleine-Budde From: Haibo Chen <haibo.chen@nxp.com> When do suspend/resume, meet the following warning message: [ 30.028336] flexcan 425b0000.can: Unbalanced pm_runtime_enable! Balance the pm_runtime_force_suspend() and pm_runtime_force_resume(). Fixes: 8cb53b485f18 ("can: flexcan: add auto stop mode for IMX93 to support wakeup") Signed-off-by: Haibo Chen <haibo.chen@nxp.com> Link: https://lore.kernel.org/all/20221213094351.3023858-1-haibo.chen@nxp.com Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- drivers/net/can/flexcan/flexcan-core.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c index 0aeff34e5ae1..6d638c93977b 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -2349,9 +2349,15 @@ static int __maybe_unused flexcan_noirq_resume(struct device *device) if (netif_running(dev)) { int err; - err = pm_runtime_force_resume(device); - if (err) - return err; + /* For the wakeup in auto stop mode, no need to gate on the + * clock here, hardware will do this automatically. + */ + if (!(device_may_wakeup(device) && + priv->devtype_data.quirks & FLEXCAN_QUIRK_AUTO_STOP_MODE)) { + err = pm_runtime_force_resume(device); + if (err) + return err; + } if (device_may_wakeup(device)) flexcan_enable_wakeup_irq(priv, false); -- 2.35.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net 3/3] can: kvaser_usb: hydra: help gcc-13 to figure out cmd_len 2022-12-19 15:52 [PATCH net 0/3] pull-request: can 2022-12-19 Marc Kleine-Budde 2022-12-19 15:52 ` [PATCH net 1/3] Documentation: devlink: add missing toc entry for etas_es58x devlink doc Marc Kleine-Budde 2022-12-19 15:52 ` [PATCH net 2/3] can: flexcan: avoid unbalanced pm_runtime_enable warning Marc Kleine-Budde @ 2022-12-19 15:52 ` Marc Kleine-Budde 2 siblings, 0 replies; 6+ messages in thread From: Marc Kleine-Budde @ 2022-12-19 15:52 UTC (permalink / raw) To: netdev Cc: davem, kuba, linux-can, kernel, Marc Kleine-Budde, Jimmy Assarsson, Anssi Hannula Debian's gcc-13 [1] throws the following error in kvaser_usb_hydra_cmd_size(): [1] gcc version 13.0.0 20221214 (experimental) [master r13-4693-g512098a3316] (Debian 13-20221214-1) | drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c:502:65: error: | array subscript ‘struct kvaser_cmd_ext[0]’ is partly outside array | bounds of ‘unsigned char[32]’ [-Werror=array-bounds=] | 502 | ret = le16_to_cpu(((struct kvaser_cmd_ext *)cmd)->len); kvaser_usb_hydra_cmd_size() returns the size of given command. It depends on the command number (cmd->header.cmd_no). For extended commands (cmd->header.cmd_no == CMD_EXTENDED) the above shown code is executed. Help gcc to recognize that this code path is not taken in all cases, by calling kvaser_usb_hydra_cmd_size() directly after assigning the command number. Fixes: aec5fb2268b7 ("can: kvaser_usb: Add support for Kvaser USB hydra family") Cc: Jimmy Assarsson <extja@kvaser.com> Cc: Anssi Hannula <anssi.hannula@bitwise.fi> Link: https://lore.kernel.org/all/20221219110104.1073881-1-mkl@pengutronix.de Tested-by: Jimmy Assarsson <extja@kvaser.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- .../net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 33 ++++++++++++++----- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c index f688124d6d66..ef341c4254fc 100644 --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c @@ -545,6 +545,7 @@ static int kvaser_usb_hydra_send_simple_cmd(struct kvaser_usb *dev, u8 cmd_no, int channel) { struct kvaser_cmd *cmd; + size_t cmd_len; int err; cmd = kzalloc(sizeof(*cmd), GFP_KERNEL); @@ -552,6 +553,7 @@ static int kvaser_usb_hydra_send_simple_cmd(struct kvaser_usb *dev, return -ENOMEM; cmd->header.cmd_no = cmd_no; + cmd_len = kvaser_usb_hydra_cmd_size(cmd); if (channel < 0) { kvaser_usb_hydra_set_cmd_dest_he (cmd, KVASER_USB_HYDRA_HE_ADDRESS_ILLEGAL); @@ -568,7 +570,7 @@ static int kvaser_usb_hydra_send_simple_cmd(struct kvaser_usb *dev, kvaser_usb_hydra_set_cmd_transid (cmd, kvaser_usb_hydra_get_next_transid(dev)); - err = kvaser_usb_send_cmd(dev, cmd, kvaser_usb_hydra_cmd_size(cmd)); + err = kvaser_usb_send_cmd(dev, cmd, cmd_len); if (err) goto end; @@ -584,6 +586,7 @@ kvaser_usb_hydra_send_simple_cmd_async(struct kvaser_usb_net_priv *priv, { struct kvaser_cmd *cmd; struct kvaser_usb *dev = priv->dev; + size_t cmd_len; int err; cmd = kzalloc(sizeof(*cmd), GFP_ATOMIC); @@ -591,14 +594,14 @@ kvaser_usb_hydra_send_simple_cmd_async(struct kvaser_usb_net_priv *priv, return -ENOMEM; cmd->header.cmd_no = cmd_no; + cmd_len = kvaser_usb_hydra_cmd_size(cmd); kvaser_usb_hydra_set_cmd_dest_he (cmd, dev->card_data.hydra.channel_to_he[priv->channel]); kvaser_usb_hydra_set_cmd_transid (cmd, kvaser_usb_hydra_get_next_transid(dev)); - err = kvaser_usb_send_cmd_async(priv, cmd, - kvaser_usb_hydra_cmd_size(cmd)); + err = kvaser_usb_send_cmd_async(priv, cmd, cmd_len); if (err) kfree(cmd); @@ -742,6 +745,7 @@ static int kvaser_usb_hydra_get_single_capability(struct kvaser_usb *dev, { struct kvaser_usb_dev_card_data *card_data = &dev->card_data; struct kvaser_cmd *cmd; + size_t cmd_len; u32 value = 0; u32 mask = 0; u16 cap_cmd_res; @@ -753,13 +757,14 @@ static int kvaser_usb_hydra_get_single_capability(struct kvaser_usb *dev, return -ENOMEM; cmd->header.cmd_no = CMD_GET_CAPABILITIES_REQ; + cmd_len = kvaser_usb_hydra_cmd_size(cmd); cmd->cap_req.cap_cmd = cpu_to_le16(cap_cmd_req); kvaser_usb_hydra_set_cmd_dest_he(cmd, card_data->hydra.sysdbg_he); kvaser_usb_hydra_set_cmd_transid (cmd, kvaser_usb_hydra_get_next_transid(dev)); - err = kvaser_usb_send_cmd(dev, cmd, kvaser_usb_hydra_cmd_size(cmd)); + err = kvaser_usb_send_cmd(dev, cmd, cmd_len); if (err) goto end; @@ -1578,6 +1583,7 @@ static int kvaser_usb_hydra_get_busparams(struct kvaser_usb_net_priv *priv, struct kvaser_usb *dev = priv->dev; struct kvaser_usb_net_hydra_priv *hydra = priv->sub_priv; struct kvaser_cmd *cmd; + size_t cmd_len; int err; if (!hydra) @@ -1588,6 +1594,7 @@ static int kvaser_usb_hydra_get_busparams(struct kvaser_usb_net_priv *priv, return -ENOMEM; cmd->header.cmd_no = CMD_GET_BUSPARAMS_REQ; + cmd_len = kvaser_usb_hydra_cmd_size(cmd); kvaser_usb_hydra_set_cmd_dest_he (cmd, dev->card_data.hydra.channel_to_he[priv->channel]); kvaser_usb_hydra_set_cmd_transid @@ -1597,7 +1604,7 @@ static int kvaser_usb_hydra_get_busparams(struct kvaser_usb_net_priv *priv, reinit_completion(&priv->get_busparams_comp); - err = kvaser_usb_send_cmd(dev, cmd, kvaser_usb_hydra_cmd_size(cmd)); + err = kvaser_usb_send_cmd(dev, cmd, cmd_len); if (err) return err; @@ -1624,6 +1631,7 @@ static int kvaser_usb_hydra_set_bittiming(const struct net_device *netdev, struct kvaser_cmd *cmd; struct kvaser_usb_net_priv *priv = netdev_priv(netdev); struct kvaser_usb *dev = priv->dev; + size_t cmd_len; int err; cmd = kzalloc(sizeof(*cmd), GFP_KERNEL); @@ -1631,6 +1639,7 @@ static int kvaser_usb_hydra_set_bittiming(const struct net_device *netdev, return -ENOMEM; cmd->header.cmd_no = CMD_SET_BUSPARAMS_REQ; + cmd_len = kvaser_usb_hydra_cmd_size(cmd); memcpy(&cmd->set_busparams_req.busparams_nominal, busparams, sizeof(cmd->set_busparams_req.busparams_nominal)); @@ -1639,7 +1648,7 @@ static int kvaser_usb_hydra_set_bittiming(const struct net_device *netdev, kvaser_usb_hydra_set_cmd_transid (cmd, kvaser_usb_hydra_get_next_transid(dev)); - err = kvaser_usb_send_cmd(dev, cmd, kvaser_usb_hydra_cmd_size(cmd)); + err = kvaser_usb_send_cmd(dev, cmd, cmd_len); kfree(cmd); @@ -1652,6 +1661,7 @@ static int kvaser_usb_hydra_set_data_bittiming(const struct net_device *netdev, struct kvaser_cmd *cmd; struct kvaser_usb_net_priv *priv = netdev_priv(netdev); struct kvaser_usb *dev = priv->dev; + size_t cmd_len; int err; cmd = kzalloc(sizeof(*cmd), GFP_KERNEL); @@ -1659,6 +1669,7 @@ static int kvaser_usb_hydra_set_data_bittiming(const struct net_device *netdev, return -ENOMEM; cmd->header.cmd_no = CMD_SET_BUSPARAMS_FD_REQ; + cmd_len = kvaser_usb_hydra_cmd_size(cmd); memcpy(&cmd->set_busparams_req.busparams_data, busparams, sizeof(cmd->set_busparams_req.busparams_data)); @@ -1676,7 +1687,7 @@ static int kvaser_usb_hydra_set_data_bittiming(const struct net_device *netdev, kvaser_usb_hydra_set_cmd_transid (cmd, kvaser_usb_hydra_get_next_transid(dev)); - err = kvaser_usb_send_cmd(dev, cmd, kvaser_usb_hydra_cmd_size(cmd)); + err = kvaser_usb_send_cmd(dev, cmd, cmd_len); kfree(cmd); @@ -1804,6 +1815,7 @@ static int kvaser_usb_hydra_get_software_info(struct kvaser_usb *dev) static int kvaser_usb_hydra_get_software_details(struct kvaser_usb *dev) { struct kvaser_cmd *cmd; + size_t cmd_len; int err; u32 flags; struct kvaser_usb_dev_card_data *card_data = &dev->card_data; @@ -1813,6 +1825,7 @@ static int kvaser_usb_hydra_get_software_details(struct kvaser_usb *dev) return -ENOMEM; cmd->header.cmd_no = CMD_GET_SOFTWARE_DETAILS_REQ; + cmd_len = kvaser_usb_hydra_cmd_size(cmd); cmd->sw_detail_req.use_ext_cmd = 1; kvaser_usb_hydra_set_cmd_dest_he (cmd, KVASER_USB_HYDRA_HE_ADDRESS_ILLEGAL); @@ -1820,7 +1833,7 @@ static int kvaser_usb_hydra_get_software_details(struct kvaser_usb *dev) kvaser_usb_hydra_set_cmd_transid (cmd, kvaser_usb_hydra_get_next_transid(dev)); - err = kvaser_usb_send_cmd(dev, cmd, kvaser_usb_hydra_cmd_size(cmd)); + err = kvaser_usb_send_cmd(dev, cmd, cmd_len); if (err) goto end; @@ -1938,6 +1951,7 @@ static int kvaser_usb_hydra_set_opt_mode(const struct kvaser_usb_net_priv *priv) { struct kvaser_usb *dev = priv->dev; struct kvaser_cmd *cmd; + size_t cmd_len; int err; if ((priv->can.ctrlmode & @@ -1953,6 +1967,7 @@ static int kvaser_usb_hydra_set_opt_mode(const struct kvaser_usb_net_priv *priv) return -ENOMEM; cmd->header.cmd_no = CMD_SET_DRIVERMODE_REQ; + cmd_len = kvaser_usb_hydra_cmd_size(cmd); kvaser_usb_hydra_set_cmd_dest_he (cmd, dev->card_data.hydra.channel_to_he[priv->channel]); kvaser_usb_hydra_set_cmd_transid @@ -1962,7 +1977,7 @@ static int kvaser_usb_hydra_set_opt_mode(const struct kvaser_usb_net_priv *priv) else cmd->set_ctrlmode.mode = KVASER_USB_HYDRA_CTRLMODE_NORMAL; - err = kvaser_usb_send_cmd(dev, cmd, kvaser_usb_hydra_cmd_size(cmd)); + err = kvaser_usb_send_cmd(dev, cmd, cmd_len); kfree(cmd); return err; -- 2.35.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-12-20 2:00 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-12-19 15:52 [PATCH net 0/3] pull-request: can 2022-12-19 Marc Kleine-Budde 2022-12-19 15:52 ` [PATCH net 1/3] Documentation: devlink: add missing toc entry for etas_es58x devlink doc Marc Kleine-Budde 2022-12-19 18:14 ` Jacob Keller 2022-12-20 2:00 ` patchwork-bot+netdevbpf 2022-12-19 15:52 ` [PATCH net 2/3] can: flexcan: avoid unbalanced pm_runtime_enable warning Marc Kleine-Budde 2022-12-19 15:52 ` [PATCH net 3/3] can: kvaser_usb: hydra: help gcc-13 to figure out cmd_len Marc Kleine-Budde
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).