From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Stefan Althöfer" <Stefan.Althoefer@janztec.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Thomas Kopp <thomas.kopp@microchip.com>
Subject: Re: AW: [PATCH 0/5] can: mcp251xfd: workaround double-RX erratum
Date: Fri, 13 Jan 2023 14:08:44 +0100 [thread overview]
Message-ID: <20230113130844.spbdtq2kumcjn42k@pengutronix.de> (raw)
In-Reply-To: <FR0P281MB1966D75DB56E45D225313B5697C29@FR0P281MB1966.DEUP281.PROD.OUTLOOK.COM>
[-- Attachment #1: Type: text/plain, Size: 1803 bytes --]
On 13.01.2023 12:39:58, Stefan Althöfer wrote:
> > In my over night test the workaround triggered 31 times. The test
> > has found no problems.
>
> This is frustrating: how did you manage to get that much triggers ;-)
I don't know. In an older version of the workaround it triggered about
every 12 Minutes.
> I ran 4 targets in parallel and got 3 fifo errors in total after 20 h
> and no test failures.
At least the workaround triggered and the test didn't fail! \o/
> I will now switch my setup from doing the selft-receiption test to a
> two-node-same-host transmission test which is where I first detected
> the error.
Makes sense. If you're happy please reply to the patches with a
"Tested-by: Stefan Althöfer <Stefan.Althoefer@janztec.com>" tag.
> BTW: "... (applies) against current net/main" - is this kh-lingo for
> using this: git clone
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/ ?
Yes - it means that I applied the patches to the main branch of that
tree. On older kernels it might not apply without problems.
But you don't have to clone the tree, you better add it as a remote to
your existing tree, e.g.:
| git remote add -f net git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
...and then check it out:
| git checkout -b my-net-main net/main
> Oh and I "backported" the patched driver source into my 6.0.12
> raspbian kernel.
I think the patches apply without problems, there we not many changes
since v6.0.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-13 13:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 22:20 [PATCH 0/5] can: mcp251xfd: workaround double-RX erratum Marc Kleine-Budde
2023-01-11 22:20 ` [PATCH 1/5] can: mcp251xfd: setup cycle counter before mcp251xfd_ring_init() Marc Kleine-Budde
2023-01-11 22:20 ` [PATCH 2/5] can: mcp251xfd: introduce mcp251xfd_skb_set_timestamp_from_tbc() and make use of it Marc Kleine-Budde
2023-01-11 22:20 ` [PATCH 3/5] can: mcp251xfd: mcp251xfd_handle_rxif_ring_uinc(): factor out in separate function Marc Kleine-Budde
2023-01-11 22:20 ` [PATCH 4/5] can: mcp251xfd: rx: mcp251xfd_handle_rxif_ring() Marc Kleine-Budde
2023-01-11 22:20 ` [PATCH 5/5] can: mcp251xfd: implement workaround for double-RX erratum Marc Kleine-Budde
2023-01-11 22:30 ` [PATCH 0/5] can: mcp251xfd: workaround " Marc Kleine-Budde
2023-01-12 7:54 ` Marc Kleine-Budde
2023-01-13 12:39 ` AW: " Stefan Althöfer
2023-01-13 13:08 ` Marc Kleine-Budde [this message]
2023-01-16 7:19 ` Thomas.Kopp
2023-01-25 5:41 ` Tom Evans
2023-01-25 6:59 ` Thomas.Kopp
2023-01-25 7:42 ` Marc Kleine-Budde
2023-01-25 9:21 ` AW: " Stefan Althöfer
2023-01-16 8:43 ` Stefan Althöfer
2023-01-18 23:11 ` Marc Kleine-Budde
2023-01-16 19:49 ` Stefan Althöfer
2023-01-16 22:15 ` Marc Kleine-Budde
2023-01-19 7:47 ` AW: " Stefan Althöfer
2023-01-19 12:02 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113130844.spbdtq2kumcjn42k@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Stefan.Althoefer@janztec.com \
--cc=linux-can@vger.kernel.org \
--cc=thomas.kopp@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).