From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Jeroen Hofstee <jhofstee@victronenergy.com>, linux-can@vger.kernel.org
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] can: don't count arbitration lose as an error
Date: Fri, 27 Nov 2020 11:30:15 +0100 [thread overview]
Message-ID: <434167b4-c2df-02bf-8a9c-2d4716c5435f@pengutronix.de> (raw)
In-Reply-To: <20201127095941.21609-1-jhofstee@victronenergy.com>
[-- Attachment #1.1: Type: text/plain, Size: 1271 bytes --]
On 11/27/20 10:59 AM, Jeroen Hofstee wrote:
> Losing arbitration is normal in a CAN-bus network, it means that a
> higher priority frame is being send and the pending message will be
> retried later. Hence most driver only increment arbitration_lost, but
> the sja1000 and sun4i driver also incremeant tx_error, causing errors
> to be reported on a normal functioning CAN-bus. So stop counting them
> as errors.
Sounds plausible.
> For completeness, the Kvaser USB hybra also increments the tx_error
> on arbitration lose, but it does so in single shot. Since in that
> case the message is not retried, that behaviour is kept.
You mean only in one shot mode? What about one shot mode on the sja1000 cores?
> Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
I've split this into two patches, and added Fixes: lines, and pushed this for
now to linux-can/sja1000.
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/log/?h=sja1000
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-27 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 9:59 [PATCH] can: don't count arbitration lose as an error Jeroen Hofstee
2020-11-27 10:30 ` Marc Kleine-Budde [this message]
2020-11-27 11:09 ` Jeroen Hofstee
2020-11-27 16:02 ` Jeroen Hofstee
2020-11-28 17:23 ` Oliver Hartkopp
2020-11-29 15:52 ` Jeroen Hofstee
2020-12-02 14:35 ` Oliver Hartkopp
2020-12-02 15:37 ` Jeroen Hofstee
2020-12-02 16:22 ` Oliver Hartkopp
2020-12-02 16:31 ` Jeroen Hofstee
2020-11-30 11:50 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434167b4-c2df-02bf-8a9c-2d4716c5435f@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=jernej.skrabec@siol.net \
--cc=jhofstee@victronenergy.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).