linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jhofstee@victronenergy.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	linux-can@vger.kernel.org
Cc: Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
	"moderated list:ARM/Allwinner sunXi SoC support" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] can: don't count arbitration lose as an error
Date: Wed, 2 Dec 2020 17:31:51 +0100	[thread overview]
Message-ID: <defd8917-cdc6-3560-7b65-7b38980d3fa1@victronenergy.com> (raw)
In-Reply-To: <b08226a0-bd96-637f-954d-fb8dedc0017b@hartkopp.net>

Hello Oliver,

On 12/2/20 5:22 PM, Oliver Hartkopp wrote:
> [...]
>> Aborting the current transmission in non single shot mode
>> will get you there and incorrectly report the message as
>> transmitted, but that is not implemented afaik.
>
> Ahem, no. If you get there the echo_skb is deleted and the tx_errors 
> counter is increased. Just as it should be.
>
>
>

Ahem, yes. I meant how it is, so it will take the else
without CAN_CTRLMODE_ONE_SHOT being set.
But since that is not implemented, it is not relevant.

Regards,

Jeroen


  reply	other threads:[~2020-12-02 16:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27  9:59 [PATCH] can: don't count arbitration lose as an error Jeroen Hofstee
2020-11-27 10:30 ` Marc Kleine-Budde
2020-11-27 11:09   ` Jeroen Hofstee
2020-11-27 16:02     ` Jeroen Hofstee
2020-11-28 17:23     ` Oliver Hartkopp
2020-11-29 15:52       ` Jeroen Hofstee
2020-12-02 14:35     ` Oliver Hartkopp
2020-12-02 15:37       ` Jeroen Hofstee
2020-12-02 16:22         ` Oliver Hartkopp
2020-12-02 16:31           ` Jeroen Hofstee [this message]
2020-11-30 11:50   ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=defd8917-cdc6-3560-7b65-7b38980d3fa1@victronenergy.com \
    --to=jhofstee@victronenergy.com \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).