Re: Questions around J1939 backport to old kernel

Re: Questions around J1939 backport to old kernel

[Romain Forlot [IoT.bzh]]

Hello,

I've just remind that the mailing list do not accept attached document 
and then my patches hasn't been published on it.

What it is the correct way to do it ?

Thanks.

Regards.

Romain Forlot.

On 28/09/2020 13:17, Romain Forlot [IoT.bzh] wrote:
> Hello,
>
> I almost forgot, here is the result of my work about the backport of 
> j1939 protocol for the kernel v4.14. It isn't perfect, but we were 
> able to use j1939 with some warning but it was functional.
>
> This work was mainly made for our Redpesk linux distribution for a CES 
> demo. Hoping that it could be improved and be useful to you.
>
> Best regards.
>
> Romain Forlot.
>
> On 25/10/2019 21:49, Arnej wrote:
>> Hello,
>>
>> I am also very interested in back-porting. My project is currently on 
>> 4.9.9 and it is not possible to upgrade to the latest kernel at this 
>> time. I was wondering if you had any thoughts on what is required to 
>> achieve this? For example, it seems that the net stack in 5.4 is very 
>> different from 4.9 (even more so compared to 4.14) and I am having 
>> difficulties getting the kernel to compile after following your 
>> cherry-pick suggestion. I'm wondering if you are familiar with the 
>> net changes and would know if it is a good idea to continue to try 
>> back-porting (is it even possible?) or if you know of any other option?
>>
>> Best Regards,
>>
>> Arnej Duranovic
>>
>> On Friday, October 25, 2019 4:39 AM, Oleksij Rempel 
>> <o.rempel@pengutronix.de> wrote:
>>
>>> On Fri, Oct 25, 2019 at 09:38:39AM +0200, Romain Forlot [IoT.bzh] 
>>> wrote:
>>>
>>>> I used it in the mainline kernel without troubles. This is a a very 
>>>> good
>>>> job, thanks.
>>>> Ok, thanks for the answer. May be I  will work on it in the next 
>>>> few months.
>>>> Let's see. I'll keep you informed.
>>> Thank you for testing. I hope to get more feed back :)
>>>
>>>> Regards.
>>>> On 18/10/2019 16:53, Oleksij Rempel wrote:
>>>>
>>>>> Hi,
>>>>> On Fri, Oct 18, 2019 at 12:07:34PM +0200, Romain Forlot [IoT.bzh] 
>>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>> I am wondering what the cost is to backport the j1939 module to 
>>>>>> an old
>>>>>> version like a v4.14 LTSI version.
>>>>>> The backport should be quite easy:
>>>>> git cherry-pick -sx `git rev-list --reverse 
>>>>> 2c1f9e26344483e2c74e80ef708d9c7fd2e543f4..9d71dd0c70099914fcd063135da3c580865e924c`
>>>>> ...but it isn't :/ Some CAN patches are missing. We'll backport 
>>>>> the stack to
>>>>> v4.14.150 (or newer) and send a follow up mail.
>>>>> However, the driver for the CAN adapter needs proper RX/TX frame 
>>>>> ordering,
>>>>> otherwise the stack will explode.
>>>>> This is fixed in flexcan mainline. And involves a handful of 
>>>>> patches. Other
>>>>> drivers probably need more fixing. Some CAN hardware may even lack 
>>>>> the hardware
>>>>> support for proper ordering, that is time stamping registers.
>>>>>
>>>>>> And what the impact is of backporting the whole CAN stack on the 
>>>>>> CAN drivers?
>>>>>> The stack has no impact on the drivers, but requirements on 
>>>>>> proper RX/TX
>>>>>> ordering, see above.
>>>>>> Are there any modifications to drivers once the CAN stack is 
>>>>>> updated ?
>>>>>> Yes, as long as they don't have proper RX/TX ordering.
>>>>> So, which CAN driver are you planing to use?
>>>>> Regards,
>>>>> Oleksij & Marc
>>>> -- 
>>>> Romain Forlot - Embedded Engineer - IoT.bzh
>>>> romain.forlot@iot.bzh - www.iot.bzh - +33675142438
>>> -- 
>>>
>>> Pengutronix e.K. | |
>>> Industrial Linux Solutions | http://www.pengutronix.de/ |
>>> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
>>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>>
-- 
Romain Forlot - Embedded Engineer - IoT.bzh
romain.forlot@iot.bzh - www.iot.bzh - +33675142438

Re: Questions around J1939 backport to old kernel

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 607 bytes --]

On 10/21/20 4:06 PM, Romain Forlot [IoT.bzh] wrote:
> Hello,
> 
> I've just remind that the mailing list do not accept attached document 
> and then my patches hasn't been published on it.
> 
> What it is the correct way to do it ?

Use git send-email

Or upload to github and ask here to review there...

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]