* [PATCH 1/1] can: esd_usb2: Fix sparse warnings
@ 2015-03-16 8:48 Thomas Körper
2015-03-16 10:53 ` Marc Kleine-Budde
2015-03-16 13:24 ` Marc Kleine-Budde
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Körper @ 2015-03-16 8:48 UTC (permalink / raw)
To: linux-can; +Cc: Thomas Körper
The hnd field of the structs does not need to be __le32: the
device just returns the value without using it itself.
Signed-off-by: Thomas Körper <thomas.koerper@esd.eu>
---
drivers/net/can/usb/esd_usb2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
index bacca0b..e4dc936 100644
--- a/drivers/net/can/usb/esd_usb2.c
+++ b/drivers/net/can/usb/esd_usb2.c
@@ -139,7 +139,7 @@ struct tx_msg {
u8 cmd;
u8 net;
u8 dlc;
- __le32 hnd;
+ u32 hnd;
__le32 id; /* upper 3 bits contain flags */
u8 data[8];
};
@@ -149,7 +149,7 @@ struct tx_done_msg {
u8 cmd;
u8 net;
u8 status;
- __le32 hnd;
+ u32 hnd;
__le32 ts;
};
--
2.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] can: esd_usb2: Fix sparse warnings
2015-03-16 8:48 [PATCH 1/1] can: esd_usb2: Fix sparse warnings Thomas Körper
@ 2015-03-16 10:53 ` Marc Kleine-Budde
2015-03-16 13:24 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2015-03-16 10:53 UTC (permalink / raw)
To: Thomas Körper, linux-can
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
On 03/16/2015 09:48 AM, Thomas Körper wrote:
> The hnd field of the structs does not need to be __le32: the
> device just returns the value without using it itself.
Thanks, added to can-next.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] can: esd_usb2: Fix sparse warnings
2015-03-16 8:48 [PATCH 1/1] can: esd_usb2: Fix sparse warnings Thomas Körper
2015-03-16 10:53 ` Marc Kleine-Budde
@ 2015-03-16 13:24 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2015-03-16 13:24 UTC (permalink / raw)
To: Thomas Körper, linux-can
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On 03/16/2015 09:48 AM, Thomas Körper wrote:
> The hnd field of the structs does not need to be __le32: the
> device just returns the value without using it itself.
>
> Signed-off-by: Thomas Körper <thomas.koerper@esd.eu>
Applied to can-next.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-16 13:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-16 8:48 [PATCH 1/1] can: esd_usb2: Fix sparse warnings Thomas Körper
2015-03-16 10:53 ` Marc Kleine-Budde
2015-03-16 13:24 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).