From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vivek Yadav <vivek.2311@samsung.com>,
rcsekar@samsung.com, krzysztof.kozlowski+dt@linaro.org,
wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
pankaj.dubey@samsung.com, ravi.patel@samsung.com,
alim.akhtar@samsung.com, linux-fsd@tesla.com, robh+dt@kernel.org
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
aswani.reddy@samsung.com, sriranjani.p@samsung.com
Subject: Re: [PATCH v2 4/6] arm64: dts: fsd: Add MCAN device node
Date: Wed, 9 Nov 2022 12:18:13 +0100 [thread overview]
Message-ID: <6868ceb7-a274-7eb4-32b6-9e0e4eb467bf@linaro.org> (raw)
In-Reply-To: <20221109100928.109478-5-vivek.2311@samsung.com>
On 09/11/2022 11:09, Vivek Yadav wrote:
> Add MCAN device node and enable the same for FSD platform.
> This also adds the required pin configuration for the same.
>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> Cc: devicetree@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Vivek Yadav <vivek.2311@samsung.com>
> ---
> arch/arm64/boot/dts/tesla/fsd-evb.dts | 16 +++++
> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 28 +++++++++
> arch/arm64/boot/dts/tesla/fsd.dtsi | 68 ++++++++++++++++++++++
> 3 files changed, 112 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> index 1db6ddf03f01..af3862e9fe3b 100644
> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> @@ -34,6 +34,22 @@
> clock-frequency = <24000000>;
> };
>
> +&m_can0 {
> + status = "okay";
> +};
> +
> +&m_can1 {
> + status = "okay";
> +};
> +
> +&m_can2 {
> + status = "okay";
> +};
> +
> +&m_can3 {
> + status = "okay";
> +};
> +
> &serial_0 {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> index d0abb9aa0e9e..bb5289ebfef3 100644
> --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> @@ -339,6 +339,34 @@
> samsung,pin-pud = <FSD_PIN_PULL_UP>;
> samsung,pin-drv = <FSD_PIN_DRV_LV1>;
> };
> +
> + m_can0_bus: m-can0-bus-pins {
> + samsung,pins = "gpd0-0", "gpd0-1";
> + samsung,pin-function = <FSD_PIN_FUNC_2>;
> + samsung,pin-pud = <FSD_PIN_PULL_UP>;
> + samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> + };
> +
> + m_can1_bus: m-can1-bus-pins {
> + samsung,pins = "gpd0-2", "gpd0-3";
> + samsung,pin-function = <FSD_PIN_FUNC_2>;
> + samsung,pin-pud = <FSD_PIN_PULL_UP>;
> + samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> + };
> +
> + m_can2_bus: m-can2-bus-pins {
> + samsung,pins = "gpd0-4", "gpd0-5";
> + samsung,pin-function = <FSD_PIN_FUNC_2>;
> + samsung,pin-pud = <FSD_PIN_PULL_UP>;
> + samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> + };
> +
> + m_can3_bus: m-can3-bus-pins {
> + samsung,pins = "gpd0-6", "gpd0-7";
> + samsung,pin-function = <FSD_PIN_FUNC_2>;
> + samsung,pin-pud = <FSD_PIN_PULL_UP>;
> + samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> + };
> };
>
> &pinctrl_pmu {
> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
> index 3d8ebbfc27f4..154fd3fc5895 100644
> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> @@ -765,6 +765,74 @@
> interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + m_can0: can@14088000 {
> + compatible = "bosch,m_can";
> + reg = <0x0 0x14088000 0x0 0x0200>,
> + <0x0 0x14080000 0x0 0x8000>;
Align with < in line before.
> + reg-names = "m_can", "message_ram";
> + interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "int0", "int1";
> + pinctrl-names = "default";
> + pinctrl-0 = <&m_can0_bus>;
> + clocks = <&clock_peric PERIC_MCAN0_IPCLKPORT_PCLK>,
> + <&clock_peric PERIC_MCAN0_IPCLKPORT_CCLK>;
The same (unless it's the problem of diff/patch and these are actually
aligned).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-09 11:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221109100240epcas5p2cdd73ae96d91a5e915f3ac9a42091620@epcas5p2.samsung.com>
2022-11-09 10:09 ` [PATCH v2 0/6] can: mcan: Add MCAN support for FSD SoC Vivek Yadav
[not found] ` <CGME20221109100245epcas5p38a01aed025f491d39a09508ebcdcef84@epcas5p3.samsung.com>
2022-11-09 10:09 ` [PATCH v2 1/6] dt-bindings: Document the SYSREG specific compatibles found on " Vivek Yadav
2022-11-09 11:08 ` Krzysztof Kozlowski
2022-11-10 11:18 ` Vivek Yadav
2022-11-10 12:11 ` Krzysztof Kozlowski
2022-11-11 4:06 ` Vivek Yadav
2022-11-11 7:54 ` Krzysztof Kozlowski
2022-11-16 16:43 ` Rob Herring
[not found] ` <CGME20221109100249epcas5p142a0a9f7e822c466f7ca778cd341e6d9@epcas5p1.samsung.com>
2022-11-09 10:09 ` [PATCH v2 2/6] dt-bindings: can: mcan: Add ECC functionality to message ram Vivek Yadav
2022-11-09 11:11 ` Krzysztof Kozlowski
[not found] ` <CGME20221109100254epcas5p48c574876756f899875df8ac71464ce11@epcas5p4.samsung.com>
2022-11-09 10:09 ` [PATCH v2 3/6] arm64: dts: fsd: add sysreg device node Vivek Yadav
2022-11-09 11:16 ` Krzysztof Kozlowski
2022-11-09 11:17 ` Sam Protsenko
2022-11-10 12:54 ` Krzysztof Kozlowski
[not found] ` <CGME20221109100258epcas5p2966d5e93e00d2a5b4e4a3096dc5a5ec6@epcas5p2.samsung.com>
2022-11-09 10:09 ` [PATCH v2 4/6] arm64: dts: fsd: Add MCAN " Vivek Yadav
2022-11-09 11:18 ` Krzysztof Kozlowski [this message]
[not found] ` <CGME20221109100302epcas5p276282a3a320649661939dcb893765fbf@epcas5p2.samsung.com>
2022-11-09 10:09 ` [PATCH v2 5/6] can: m_can: Add ECC functionality for message RAM Vivek Yadav
2022-11-09 11:20 ` Krzysztof Kozlowski
[not found] ` <CGME20221109100309epcas5p4bc1ddd62048098d681ba8af8d35e2e73@epcas5p4.samsung.com>
2022-11-09 10:09 ` [PATCH v2 6/6] arm64: dts: fsd: Add support for error correction code " Vivek Yadav
2022-11-09 11:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6868ceb7-a274-7eb4-32b6-9e0e4eb467bf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pankaj.dubey@samsung.com \
--cc=ravi.patel@samsung.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sriranjani.p@samsung.com \
--cc=vivek.2311@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).