From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vivek Yadav <vivek.2311@samsung.com>,
rcsekar@samsung.com, krzysztof.kozlowski+dt@linaro.org,
wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
pankaj.dubey@samsung.com, ravi.patel@samsung.com,
alim.akhtar@samsung.com, linux-fsd@tesla.com, robh+dt@kernel.org
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
aswani.reddy@samsung.com, sriranjani.p@samsung.com
Subject: Re: [PATCH v2 5/6] can: m_can: Add ECC functionality for message RAM
Date: Wed, 9 Nov 2022 12:20:38 +0100 [thread overview]
Message-ID: <a9901cbd-8af3-04aa-12f5-df7c563f873a@linaro.org> (raw)
In-Reply-To: <20221109100928.109478-6-vivek.2311@samsung.com>
On 09/11/2022 11:09, Vivek Yadav wrote:
> Whenever MCAN Buffers and FIFOs are stored on message ram, there are
> inherent risks of corruption known as single-bit errors.
>
> Enable error correction code (ECC) data integrity check for Message RAM
> to create valid ECC checksums.
>
> ECC uses a respective number of bits, which are added to each word as a
> parity and that will raise the error signal on the corruption in the
> Interrupt Register(IR).
>
> This indicates either bit error detected and Corrected(BEC) or No bit
> error detected when reading from Message RAM.
>
> Signed-off-by: Chandrasekar R <rcsekar@samsung.com>
> Signed-off-by: Vivek Yadav <vivek.2311@samsung.com>
(...)
>
> +static int m_can_plat_init(struct m_can_classdev *cdev)
> +{
> + struct m_can_ecc_regmap *ecc_cfg = &cdev->ecc_cfg_sys;
> + struct device_node *np = cdev->dev->of_node;
> + int ret = 0;
> +
> + if (cdev->mram_cfg_flag != ECC_ENABLE) {
> + /* Initialize mcan message ram */
> + ret = m_can_init_ram(cdev);
> +
> + if (ret)
> + return ret;
> +
> + cdev->mram_cfg_flag = ECC_ENABLE;
> + }
> +
> + if (ecc_cfg->ecc_cfg_flag != ECC_ENABLE) {
> + /* configure error code check for mram */
> + if (!ecc_cfg->syscon) {
> + ecc_cfg->syscon =
> + syscon_regmap_lookup_by_phandle_args(np,
> + "tesla,mram-ecc-cfg"
> + , 1,
, goes to previous line
> + &ecc_cfg->reg);
> + }
> +
> + if (IS_ERR(ecc_cfg->syscon)) {
> + dev_err(cdev->dev, "couldn't get the syscon reg!\n");
Didn't you just break all platforms using ECC?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-09 11:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221109100240epcas5p2cdd73ae96d91a5e915f3ac9a42091620@epcas5p2.samsung.com>
2022-11-09 10:09 ` [PATCH v2 0/6] can: mcan: Add MCAN support for FSD SoC Vivek Yadav
[not found] ` <CGME20221109100245epcas5p38a01aed025f491d39a09508ebcdcef84@epcas5p3.samsung.com>
2022-11-09 10:09 ` [PATCH v2 1/6] dt-bindings: Document the SYSREG specific compatibles found on " Vivek Yadav
2022-11-09 11:08 ` Krzysztof Kozlowski
2022-11-10 11:18 ` Vivek Yadav
2022-11-10 12:11 ` Krzysztof Kozlowski
2022-11-11 4:06 ` Vivek Yadav
2022-11-11 7:54 ` Krzysztof Kozlowski
2022-11-16 16:43 ` Rob Herring
[not found] ` <CGME20221109100249epcas5p142a0a9f7e822c466f7ca778cd341e6d9@epcas5p1.samsung.com>
2022-11-09 10:09 ` [PATCH v2 2/6] dt-bindings: can: mcan: Add ECC functionality to message ram Vivek Yadav
2022-11-09 11:11 ` Krzysztof Kozlowski
[not found] ` <CGME20221109100254epcas5p48c574876756f899875df8ac71464ce11@epcas5p4.samsung.com>
2022-11-09 10:09 ` [PATCH v2 3/6] arm64: dts: fsd: add sysreg device node Vivek Yadav
2022-11-09 11:16 ` Krzysztof Kozlowski
2022-11-09 11:17 ` Sam Protsenko
2022-11-10 12:54 ` Krzysztof Kozlowski
[not found] ` <CGME20221109100258epcas5p2966d5e93e00d2a5b4e4a3096dc5a5ec6@epcas5p2.samsung.com>
2022-11-09 10:09 ` [PATCH v2 4/6] arm64: dts: fsd: Add MCAN " Vivek Yadav
2022-11-09 11:18 ` Krzysztof Kozlowski
[not found] ` <CGME20221109100302epcas5p276282a3a320649661939dcb893765fbf@epcas5p2.samsung.com>
2022-11-09 10:09 ` [PATCH v2 5/6] can: m_can: Add ECC functionality for message RAM Vivek Yadav
2022-11-09 11:20 ` Krzysztof Kozlowski [this message]
[not found] ` <CGME20221109100309epcas5p4bc1ddd62048098d681ba8af8d35e2e73@epcas5p4.samsung.com>
2022-11-09 10:09 ` [PATCH v2 6/6] arm64: dts: fsd: Add support for error correction code " Vivek Yadav
2022-11-09 11:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9901cbd-8af3-04aa-12f5-df7c563f873a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pankaj.dubey@samsung.com \
--cc=ravi.patel@samsung.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sriranjani.p@samsung.com \
--cc=vivek.2311@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).