* rx-dropped increases if the can module is not loaded (yet)
@ 2020-11-27 16:09 Jeroen Hofstee
2020-11-28 17:44 ` Oliver Hartkopp
0 siblings, 1 reply; 4+ messages in thread
From: Jeroen Hofstee @ 2020-11-27 16:09 UTC (permalink / raw)
To: linux-can
Hi,
Since it took me a while to figure it out, it might be worthwhile to share.
If a CAN-bus network interface is first set to up and only later used,
the messages received in the meantime are counted by [1] as dropped.
If the the can module is modprobed before the interface is upped, this
is no longer the case.
Perhaps it saves someone some time.
Jeroen
[1] https://github.com/torvalds/linux/blob/v5.9/net/core/dev.c#L5257
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: rx-dropped increases if the can module is not loaded (yet)
2020-11-27 16:09 rx-dropped increases if the can module is not loaded (yet) Jeroen Hofstee
@ 2020-11-28 17:44 ` Oliver Hartkopp
2020-12-02 15:47 ` Jeroen Hofstee
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Hartkopp @ 2020-11-28 17:44 UTC (permalink / raw)
To: Jeroen Hofstee, linux-can
On 27.11.20 17:09, Jeroen Hofstee wrote:
> Since it took me a while to figure it out, it might be worthwhile to share.
> If a CAN-bus network interface is first set to up and only later used,
> the messages received in the meantime are counted by [1] as dropped.
Interesting! But makes sense and is consistent: When the CAN frame is
not processed by the network layer is is just dropped in the rx path.
> If the the can module is modprobed before the interface is upped, this
> is no longer the case.
>
> Perhaps it saves someone some time.
So far we have not documented these details for the existing netdev
statistics. Do you think this is needed when the behaviour, which leads
to rx-dropped, is common for other netdevs also?
Regards,
Oliver
>
> [1] https://github.com/torvalds/linux/blob/v5.9/net/core/dev.c#L5257
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: rx-dropped increases if the can module is not loaded (yet)
2020-11-28 17:44 ` Oliver Hartkopp
@ 2020-12-02 15:47 ` Jeroen Hofstee
2020-12-02 16:24 ` Oliver Hartkopp
0 siblings, 1 reply; 4+ messages in thread
From: Jeroen Hofstee @ 2020-12-02 15:47 UTC (permalink / raw)
To: Oliver Hartkopp, linux-can
Hello Oliver,
On 11/28/20 6:44 PM, Oliver Hartkopp wrote:
> On 27.11.20 17:09, Jeroen Hofstee wrote:
>
>> Since it took me a while to figure it out, it might be worthwhile to
>> share.
>> If a CAN-bus network interface is first set to up and only later used,
>> the messages received in the meantime are counted by [1] as dropped.
>
> Interesting! But makes sense and is consistent: When the CAN frame is
> not processed by the network layer is is just dropped in the rx path.
>
>> If the the can module is modprobed before the interface is upped, this
>> is no longer the case.
>>
>> Perhaps it saves someone some time.
>
> So far we have not documented these details for the existing netdev
> statistics. Do you think this is needed when the behaviour, which
> leads to rx-dropped, is common for other netdevs also?
>
>
Don't know... Perhaps we should simply wait and see how many
people show up wondering where the rx-dropped frames are
coming from?
Regards,
Jeroen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: rx-dropped increases if the can module is not loaded (yet)
2020-12-02 15:47 ` Jeroen Hofstee
@ 2020-12-02 16:24 ` Oliver Hartkopp
0 siblings, 0 replies; 4+ messages in thread
From: Oliver Hartkopp @ 2020-12-02 16:24 UTC (permalink / raw)
To: Jeroen Hofstee, linux-can
On 02.12.20 16:47, Jeroen Hofstee wrote:
> Hello Oliver,
>
> On 11/28/20 6:44 PM, Oliver Hartkopp wrote:
>> On 27.11.20 17:09, Jeroen Hofstee wrote:
>>
>>> Since it took me a while to figure it out, it might be worthwhile to
>>> share.
>>> If a CAN-bus network interface is first set to up and only later used,
>>> the messages received in the meantime are counted by [1] as dropped.
>>
>> Interesting! But makes sense and is consistent: When the CAN frame is
>> not processed by the network layer is is just dropped in the rx path.
>>
>>> If the the can module is modprobed before the interface is upped, this
>>> is no longer the case.
>>>
>>> Perhaps it saves someone some time.
>>
>> So far we have not documented these details for the existing netdev
>> statistics. Do you think this is needed when the behaviour, which
>> leads to rx-dropped, is common for other netdevs also?
>>
>>
>
> Don't know... Perhaps we should simply wait and see how many
> people show up wondering where the rx-dropped frames are
> coming from?
>
ACK ;-)
Regards,
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-02 16:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 16:09 rx-dropped increases if the can module is not loaded (yet) Jeroen Hofstee
2020-11-28 17:44 ` Oliver Hartkopp
2020-12-02 15:47 ` Jeroen Hofstee
2020-12-02 16:24 ` Oliver Hartkopp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).