* [PATCH] can: Explain PDU in CAN_ISOTP help text
@ 2020-10-13 14:13 Geert Uytterhoeven
2020-10-13 16:43 ` Oliver Hartkopp
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-10-13 14:13 UTC (permalink / raw)
To: Oliver Hartkopp, Marc Kleine-Budde
Cc: David S . Miller, Jakub Kicinski, linux-can, netdev,
linux-kernel, Geert Uytterhoeven
The help text for the CAN_ISOTP config symbol uses the acronym "PDU".
However, this acronym is not explained here, nor in
Documentation/networking/can.rst.
Expand the acronym to make it easier for users to decide if they need to
enable the CAN_ISOTP option or not.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
net/can/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/can/Kconfig b/net/can/Kconfig
index 224e5e0283a986d9..7c9958df91d353c8 100644
--- a/net/can/Kconfig
+++ b/net/can/Kconfig
@@ -62,8 +62,9 @@ config CAN_ISOTP
communication between CAN nodes via two defined CAN Identifiers.
As CAN frames can only transport a small amount of data bytes
(max. 8 bytes for 'classic' CAN and max. 64 bytes for CAN FD) this
- segmentation is needed to transport longer PDUs as needed e.g. for
- vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN traffic.
+ segmentation is needed to transport longer Protocol Data Units (PDU)
+ as needed e.g. for vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN
+ traffic.
This protocol driver implements data transfers according to
ISO 15765-2:2016 for 'classic' CAN and CAN FD frame types.
If you want to perform automotive vehicle diagnostic services (UDS),
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] can: Explain PDU in CAN_ISOTP help text
2020-10-13 14:13 [PATCH] can: Explain PDU in CAN_ISOTP help text Geert Uytterhoeven
@ 2020-10-13 16:43 ` Oliver Hartkopp
2020-10-14 6:30 ` Marc Kleine-Budde
0 siblings, 1 reply; 3+ messages in thread
From: Oliver Hartkopp @ 2020-10-13 16:43 UTC (permalink / raw)
To: Geert Uytterhoeven, Marc Kleine-Budde
Cc: David S . Miller, Jakub Kicinski, linux-can, netdev, linux-kernel
On 13.10.20 16:13, Geert Uytterhoeven wrote:
> The help text for the CAN_ISOTP config symbol uses the acronym "PDU".
> However, this acronym is not explained here, nor in
> Documentation/networking/can.rst.
> Expand the acronym to make it easier for users to decide if they need to
> enable the CAN_ISOTP option or not.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Yes, when you are so deep into it that PDU becomes a word like dog or
cat ;-)
Thanks,
Oliver
> ---
> net/can/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/can/Kconfig b/net/can/Kconfig
> index 224e5e0283a986d9..7c9958df91d353c8 100644
> --- a/net/can/Kconfig
> +++ b/net/can/Kconfig
> @@ -62,8 +62,9 @@ config CAN_ISOTP
> communication between CAN nodes via two defined CAN Identifiers.
> As CAN frames can only transport a small amount of data bytes
> (max. 8 bytes for 'classic' CAN and max. 64 bytes for CAN FD) this
> - segmentation is needed to transport longer PDUs as needed e.g. for
> - vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN traffic.
> + segmentation is needed to transport longer Protocol Data Units (PDU)
> + as needed e.g. for vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN
> + traffic.
> This protocol driver implements data transfers according to
> ISO 15765-2:2016 for 'classic' CAN and CAN FD frame types.
> If you want to perform automotive vehicle diagnostic services (UDS),
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] can: Explain PDU in CAN_ISOTP help text
2020-10-13 16:43 ` Oliver Hartkopp
@ 2020-10-14 6:30 ` Marc Kleine-Budde
0 siblings, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2020-10-14 6:30 UTC (permalink / raw)
To: Oliver Hartkopp, Geert Uytterhoeven
Cc: David S . Miller, Jakub Kicinski, linux-can, netdev, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 971 bytes --]
On 10/13/20 6:43 PM, Oliver Hartkopp wrote:
> On 13.10.20 16:13, Geert Uytterhoeven wrote:
>> The help text for the CAN_ISOTP config symbol uses the acronym "PDU".
>> However, this acronym is not explained here, nor in
>> Documentation/networking/can.rst.
>> Expand the acronym to make it easier for users to decide if they need to
>> enable the CAN_ISOTP option or not.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
>
> Yes, when you are so deep into it that PDU becomes a word like dog or
> cat ;-)
As v5.9 is out and isotp will hit mainline quite soon, I'll queue this via
can/master.
Tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-14 8:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-13 14:13 [PATCH] can: Explain PDU in CAN_ISOTP help text Geert Uytterhoeven
2020-10-13 16:43 ` Oliver Hartkopp
2020-10-14 6:30 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).