Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
* [trivial PATCH] cifs: Use #define in cifs_dbg
@ 2020-02-21 13:20 Joe Perches
  2020-02-21 13:44 ` Aurélien Aptel
  0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2020-02-21 13:20 UTC (permalink / raw)
  To: Steve French; +Cc: linux-cifs, samba-technical, linux-kernel

All other uses of cifs_dbg use defines so change this one.

Signed-off-by: Joe Perches <joe@perches.com>
---
 fs/cifs/inode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index b5e663..cd95e0 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -653,8 +653,8 @@ cifs_all_info_to_fattr(struct cifs_fattr *fattr, FILE_ALL_INFO *info,
 		 */
 		if ((fattr->cf_nlink < 1) && !tcon->unix_ext &&
 		    !info->DeletePending) {
-			cifs_dbg(1, "bogus file nlink value %u\n",
-				fattr->cf_nlink);
+			cifs_dbg(VFS, "bogus file nlink value %u\n",
+				 fattr->cf_nlink);
 			fattr->cf_flags |= CIFS_FATTR_UNKNOWN_NLINK;
 		}
 	}



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [trivial PATCH] cifs: Use #define in cifs_dbg
  2020-02-21 13:20 [trivial PATCH] cifs: Use #define in cifs_dbg Joe Perches
@ 2020-02-21 13:44 ` Aurélien Aptel
  2020-02-21 13:55   ` Joe Perches
  2020-02-24  5:58   ` Steve French
  0 siblings, 2 replies; 4+ messages in thread
From: Aurélien Aptel @ 2020-02-21 13:44 UTC (permalink / raw)
  To: Joe Perches, Steve French; +Cc: linux-cifs, samba-technical, linux-kernel

Joe Perches <joe@perches.com> writes:
> +			cifs_dbg(VFS, "bogus file nlink value %u\n",
> +				 fattr->cf_nlink);

Good catch :)
I realize that 1 is VFS but this should probably be FYI.

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [trivial PATCH] cifs: Use #define in cifs_dbg
  2020-02-21 13:44 ` Aurélien Aptel
@ 2020-02-21 13:55   ` Joe Perches
  2020-02-24  5:58   ` Steve French
  1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2020-02-21 13:55 UTC (permalink / raw)
  To: Aurélien Aptel, Steve French
  Cc: linux-cifs, samba-technical, linux-kernel

On Fri, 2020-02-21 at 14:44 +0100, Aurélien Aptel wrote:
> Joe Perches <joe@perches.com> writes:
> > +			cifs_dbg(VFS, "bogus file nlink value %u\n",
> > +				 fattr->cf_nlink);
> 
> Good catch :)
> I realize that 1 is VFS but this should probably be FYI.

change it as you please.

fyi:

Perhaps commit f2f176b41 ("CIFS: add ONCE flag for cifs_dbg type")
may have increased object size quite a bit as it now tests
an external variable.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [trivial PATCH] cifs: Use #define in cifs_dbg
  2020-02-21 13:44 ` Aurélien Aptel
  2020-02-21 13:55   ` Joe Perches
@ 2020-02-24  5:58   ` Steve French
  1 sibling, 0 replies; 4+ messages in thread
From: Steve French @ 2020-02-24  5:58 UTC (permalink / raw)
  To: Aurélien Aptel
  Cc: Joe Perches, Steve French, CIFS, samba-technical, linux-kernel

Seems like a plausible debug (VFS not FYI) msg.   If delete is not
pending, it is a little strange if nlink is 0. merged into
cifs-2.6.git for-next


On Fri, Feb 21, 2020 at 7:46 AM Aurélien Aptel <aaptel@suse.com> wrote:
>
> Joe Perches <joe@perches.com> writes:
> > +                     cifs_dbg(VFS, "bogus file nlink value %u\n",
> > +                              fattr->cf_nlink);
>
> Good catch :)
> I realize that 1 is VFS but this should probably be FYI.
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)



-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 13:20 [trivial PATCH] cifs: Use #define in cifs_dbg Joe Perches
2020-02-21 13:44 ` Aurélien Aptel
2020-02-21 13:55   ` Joe Perches
2020-02-24  5:58   ` Steve French

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git