* bug in dumping server name in tracepoints
@ 2021-05-20 18:11 Steve French
2021-05-21 7:52 ` Shyam Prasad N
0 siblings, 1 reply; 4+ messages in thread
From: Steve French @ 2021-05-20 18:11 UTC (permalink / raw)
To: Shyam Prasad N; +Cc: CIFS
Looks like we have a bug in how we dump server name in some
tracepoints e.g. see below:
smfrench@smfrench-ThinkPad-P52:~/cifs-2.6$ sudo trace-cmd show
# tracer: nop
#
# entries-in-buffer/entries-written: 1/1 #P:12
#
# _-----=> irqs-off
# / _----=> need-resched
# | / _---=> hardirq/softirq
# || / _--=> preempt-depth
# ||| / delay
# TASK-PID CPU# |||| TIMESTAMP FUNCTION
# | | | |||| | |
cifsd-82671 [006] .... 298870.051187: smb3_reconnect:
conn_id=0x2 server=(0xffff950d5f6f6c00:localhost)[UNSAFE-MEMORY]
current_mid=3105
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug in dumping server name in tracepoints
2021-05-20 18:11 bug in dumping server name in tracepoints Steve French
@ 2021-05-21 7:52 ` Shyam Prasad N
2021-05-21 18:37 ` Steve French
0 siblings, 1 reply; 4+ messages in thread
From: Shyam Prasad N @ 2021-05-21 7:52 UTC (permalink / raw)
To: Steve French; +Cc: CIFS
Can you please verify with this patch?
We missed using the variable length string macros in several
tracepoints. Fixed them in this change.
There's probably more useful macros that we can use to print
others like flags etc. But I'll submit seperate patches for
those at a future date.
https://github.com/sprasad-microsoft/smb-kernel-client/commit/ce6399dd4f13cacc4ffdc41e07cde5cc88175f71.patch
https://github.com/sprasad-microsoft/smb-kernel-client/pull/2
Regards,
Shyam
On Thu, May 20, 2021 at 11:41 PM Steve French <smfrench@gmail.com> wrote:
>
> Looks like we have a bug in how we dump server name in some
> tracepoints e.g. see below:
>
> smfrench@smfrench-ThinkPad-P52:~/cifs-2.6$ sudo trace-cmd show
> # tracer: nop
> #
> # entries-in-buffer/entries-written: 1/1 #P:12
> #
> # _-----=> irqs-off
> # / _----=> need-resched
> # | / _---=> hardirq/softirq
> # || / _--=> preempt-depth
> # ||| / delay
> # TASK-PID CPU# |||| TIMESTAMP FUNCTION
> # | | | |||| | |
> cifsd-82671 [006] .... 298870.051187: smb3_reconnect:
> conn_id=0x2 server=(0xffff950d5f6f6c00:localhost)[UNSAFE-MEMORY]
> current_mid=3105
>
>
> --
> Thanks,
>
> Steve
--
Regards,
Shyam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug in dumping server name in tracepoints
2021-05-21 7:52 ` Shyam Prasad N
@ 2021-05-21 18:37 ` Steve French
2021-05-21 23:44 ` Steve French
0 siblings, 1 reply; 4+ messages in thread
From: Steve French @ 2021-05-21 18:37 UTC (permalink / raw)
To: Shyam Prasad N; +Cc: CIFS
On Fri, May 21, 2021 at 2:52 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> Can you please verify with this patch?
>
> We missed using the variable length string macros in several
> tracepoints. Fixed them in this change.
>
> There's probably more useful macros that we can use to print
> others like flags etc. But I'll submit seperate patches for
> those at a future date.
>
> https://github.com/sprasad-microsoft/smb-kernel-client/commit/ce6399dd4f13cacc4ffdc41e07cde5cc88175f71.patch
> https://github.com/sprasad-microsoft/smb-kernel-client/pull/2
>
> Regards,
> Shyam
Yes - it works now
# trace-cmd show
# tracer: nop
#
# entries-in-buffer/entries-written: 1/1 #P:12
#
# _-----=> irqs-off
# / _----=> need-resched
# | / _---=> hardirq/softirq
# || / _--=> preempt-depth
# ||| / delay
# TASK-PID CPU# |||| TIMESTAMP FUNCTION
# | | | |||| | |
cifsd-226090 [000] .... 386914.150292: smb3_reconnect:
conn_id=0x1 server=localhost current_mid=26
> On Thu, May 20, 2021 at 11:41 PM Steve French <smfrench@gmail.com> wrote:
> >
> > Looks like we have a bug in how we dump server name in some
> > tracepoints e.g. see below:
> >
> > smfrench@smfrench-ThinkPad-P52:~/cifs-2.6$ sudo trace-cmd show
> > # tracer: nop
> > #
> > # entries-in-buffer/entries-written: 1/1 #P:12
> > #
> > # _-----=> irqs-off
> > # / _----=> need-resched
> > # | / _---=> hardirq/softirq
> > # || / _--=> preempt-depth
> > # ||| / delay
> > # TASK-PID CPU# |||| TIMESTAMP FUNCTION
> > # | | | |||| | |
> > cifsd-82671 [006] .... 298870.051187: smb3_reconnect:
> > conn_id=0x2 server=(0xffff950d5f6f6c00:localhost)[UNSAFE-MEMORY]
> > current_mid=3105
> >
> >
> > --
> > Thanks,
> >
> > Steve
>
>
>
> --
> Regards,
> Shyam
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug in dumping server name in tracepoints
2021-05-21 18:37 ` Steve French
@ 2021-05-21 23:44 ` Steve French
0 siblings, 0 replies; 4+ messages in thread
From: Steve French @ 2021-05-21 23:44 UTC (permalink / raw)
To: Shyam Prasad N; +Cc: CIFS
merged into cifs-2.6.git for-next and cc:stable v5.12
On Fri, May 21, 2021 at 1:37 PM Steve French <smfrench@gmail.com> wrote:
>
> On Fri, May 21, 2021 at 2:52 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> >
> > Can you please verify with this patch?
> >
> > We missed using the variable length string macros in several
> > tracepoints. Fixed them in this change.
> >
> > There's probably more useful macros that we can use to print
> > others like flags etc. But I'll submit seperate patches for
> > those at a future date.
> >
> > https://github.com/sprasad-microsoft/smb-kernel-client/commit/ce6399dd4f13cacc4ffdc41e07cde5cc88175f71.patch
> > https://github.com/sprasad-microsoft/smb-kernel-client/pull/2
> >
> > Regards,
> > Shyam
>
> Yes - it works now
>
> # trace-cmd show
> # tracer: nop
> #
> # entries-in-buffer/entries-written: 1/1 #P:12
> #
> # _-----=> irqs-off
> # / _----=> need-resched
> # | / _---=> hardirq/softirq
> # || / _--=> preempt-depth
> # ||| / delay
> # TASK-PID CPU# |||| TIMESTAMP FUNCTION
> # | | | |||| | |
> cifsd-226090 [000] .... 386914.150292: smb3_reconnect:
> conn_id=0x1 server=localhost current_mid=26
>
>
> > On Thu, May 20, 2021 at 11:41 PM Steve French <smfrench@gmail.com> wrote:
> > >
> > > Looks like we have a bug in how we dump server name in some
> > > tracepoints e.g. see below:
> > >
> > > smfrench@smfrench-ThinkPad-P52:~/cifs-2.6$ sudo trace-cmd show
> > > # tracer: nop
> > > #
> > > # entries-in-buffer/entries-written: 1/1 #P:12
> > > #
> > > # _-----=> irqs-off
> > > # / _----=> need-resched
> > > # | / _---=> hardirq/softirq
> > > # || / _--=> preempt-depth
> > > # ||| / delay
> > > # TASK-PID CPU# |||| TIMESTAMP FUNCTION
> > > # | | | |||| | |
> > > cifsd-82671 [006] .... 298870.051187: smb3_reconnect:
> > > conn_id=0x2 server=(0xffff950d5f6f6c00:localhost)[UNSAFE-MEMORY]
> > > current_mid=3105
> > >
> > >
> > > --
> > > Thanks,
> > >
> > > Steve
> >
> >
> >
> > --
> > Regards,
> > Shyam
>
>
>
> --
> Thanks,
>
> Steve
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-21 23:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 18:11 bug in dumping server name in tracepoints Steve French
2021-05-21 7:52 ` Shyam Prasad N
2021-05-21 18:37 ` Steve French
2021-05-21 23:44 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).