* [PATCH] fs: cifs: Remove repeated struct declaration
@ 2021-04-09 2:46 Wan Jiabing
2021-04-09 3:53 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-04-09 2:46 UTC (permalink / raw)
To: Steve French, linux-cifs, samba-technical, linux-kernel
Cc: kael_w, Wan Jiabing
struct cifs_writedata is declared twice.
One is declared at 209th line.
And struct cifs_writedata is defined blew.
The declaration hear is not needed. Remove the duplicate.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
fs/cifs/cifsglob.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index ec824ab8c5ca..5ec60745034e 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -1316,8 +1316,6 @@ struct cifs_readdata {
struct page **pages;
};
-struct cifs_writedata;
-
/* asynchronous write support */
struct cifs_writedata {
struct kref refcount;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: cifs: Remove repeated struct declaration
2021-04-09 2:46 [PATCH] fs: cifs: Remove repeated struct declaration Wan Jiabing
@ 2021-04-09 3:53 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2021-04-09 3:53 UTC (permalink / raw)
To: Wan Jiabing; +Cc: Steve French, CIFS, samba-technical, LKML, kael_w
merged into cifs-2.6.git for-next
On Thu, Apr 8, 2021 at 9:47 PM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> struct cifs_writedata is declared twice.
> One is declared at 209th line.
> And struct cifs_writedata is defined blew.
> The declaration hear is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> fs/cifs/cifsglob.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index ec824ab8c5ca..5ec60745034e 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -1316,8 +1316,6 @@ struct cifs_readdata {
> struct page **pages;
> };
>
> -struct cifs_writedata;
> -
> /* asynchronous write support */
> struct cifs_writedata {
> struct kref refcount;
> --
> 2.25.1
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-09 3:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 2:46 [PATCH] fs: cifs: Remove repeated struct declaration Wan Jiabing
2021-04-09 3:53 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).