Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
* [cifs:for-next 18/20] fs/cifs/smb2transport.c:52:1: sparse: sparse: symbol 'smb3_crypto_shash_allocate' was not declared. Should it be static?
@ 2019-11-04  7:59 kbuild test robot
  2019-11-04  7:59 ` [RFC PATCH cifs] cifs: smb3_crypto_shash_allocate can be static kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-11-04  7:59 UTC (permalink / raw)
  To: Aurelien Aptel
  Cc: kbuild-all, linux-cifs, samba-technical, Steve French, linux-kernel

tree:   git://git.samba.org/sfrench/cifs-2.6.git for-next
head:   3c652dd9928737b82a74b3ce8483c7497885eb04
commit: 4d1cc0309f7ec007b5b29f1350e3b1c105e86439 [18/20] cifs: try opening channels after mounting
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-6-g57f8611-dirty
        git checkout 4d1cc0309f7ec007b5b29f1350e3b1c105e86439
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> fs/cifs/smb2transport.c:52:1: sparse: sparse: symbol 'smb3_crypto_shash_allocate' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [RFC PATCH cifs] cifs: smb3_crypto_shash_allocate can be static
  2019-11-04  7:59 [cifs:for-next 18/20] fs/cifs/smb2transport.c:52:1: sparse: sparse: symbol 'smb3_crypto_shash_allocate' was not declared. Should it be static? kbuild test robot
@ 2019-11-04  7:59 ` kbuild test robot
  2019-11-05 23:00   ` Steve French
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-11-04  7:59 UTC (permalink / raw)
  To: Aurelien Aptel
  Cc: kbuild-all, linux-cifs, samba-technical, Steve French, linux-kernel


Fixes: 4d1cc0309f7e ("cifs: try opening channels after mounting")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 smb2transport.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/smb2transport.c b/fs/cifs/smb2transport.c
index 1af789871ec2e..86501239cef55 100644
--- a/fs/cifs/smb2transport.c
+++ b/fs/cifs/smb2transport.c
@@ -48,7 +48,7 @@ smb2_crypto_shash_allocate(struct TCP_Server_Info *server)
 			       &server->secmech.sdeschmacsha256);
 }
 
-int
+static int
 smb3_crypto_shash_allocate(struct TCP_Server_Info *server)
 {
 	struct cifs_secmech *p = &server->secmech;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC PATCH cifs] cifs: smb3_crypto_shash_allocate can be static
  2019-11-04  7:59 ` [RFC PATCH cifs] cifs: smb3_crypto_shash_allocate can be static kbuild test robot
@ 2019-11-05 23:00   ` Steve French
  0 siblings, 0 replies; 3+ messages in thread
From: Steve French @ 2019-11-05 23:00 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Aurelien Aptel, kbuild-all, CIFS, samba-technical, Steve French, LKML

FYI - I updated cifs-2.6.for-next with the equivalent change (fixing a
line change to one of Aurelien's patches in the multichannel series)

On Mon, Nov 4, 2019 at 1:59 AM kbuild test robot <lkp@intel.com> wrote:
>
>
> Fixes: 4d1cc0309f7e ("cifs: try opening channels after mounting")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>  smb2transport.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2transport.c b/fs/cifs/smb2transport.c
> index 1af789871ec2e..86501239cef55 100644
> --- a/fs/cifs/smb2transport.c
> +++ b/fs/cifs/smb2transport.c
> @@ -48,7 +48,7 @@ smb2_crypto_shash_allocate(struct TCP_Server_Info *server)
>                                &server->secmech.sdeschmacsha256);
>  }
>
> -int
> +static int
>  smb3_crypto_shash_allocate(struct TCP_Server_Info *server)
>  {
>         struct cifs_secmech *p = &server->secmech;



-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04  7:59 [cifs:for-next 18/20] fs/cifs/smb2transport.c:52:1: sparse: sparse: symbol 'smb3_crypto_shash_allocate' was not declared. Should it be static? kbuild test robot
2019-11-04  7:59 ` [RFC PATCH cifs] cifs: smb3_crypto_shash_allocate can be static kbuild test robot
2019-11-05 23:00   ` Steve French

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git