* More tests added to buildbot @ 2019-03-03 5:05 Steve French 2019-03-05 4:09 ` ronnie sahlberg 0 siblings, 1 reply; 8+ messages in thread From: Steve French @ 2019-03-03 5:05 UTC (permalink / raw) To: CIFS Added four xfs subtests to the cifs-testing buildbot (and 3 of these were also missing from the Azure buildbot so added them to Azure as well) + [ "generic/464", "smb3"], + [ "generic/469", "smb3"], + [ "generic/524", "smb3"], + [ "generic/528", "smb3samba], Testing the three new tests for Azure in http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/105 -- Thanks, Steve ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: More tests added to buildbot 2019-03-03 5:05 More tests added to buildbot Steve French @ 2019-03-05 4:09 ` ronnie sahlberg 2019-03-05 5:00 ` Steve French 0 siblings, 1 reply; 8+ messages in thread From: ronnie sahlberg @ 2019-03-05 4:09 UTC (permalink / raw) To: Steve French; +Cc: CIFS generic/469 does it work for you? It fails in the tests. I have tried it locally and it always fails here. With current for-next as well as for-next as of a month ago. Same for xfs-tests, with current as well as months old master. Lets remove it. On Sun, Mar 3, 2019 at 3:05 PM Steve French <smfrench@gmail.com> wrote: > > Added four xfs subtests to the cifs-testing buildbot (and 3 of these > were also missing from the Azure buildbot so added them to Azure as > well) > + [ "generic/464", "smb3"], > + [ "generic/469", "smb3"], > + [ "generic/524", "smb3"], > + [ "generic/528", "smb3samba], > > Testing the three new tests for Azure in > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/105 > > > -- > Thanks, > > Steve ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: More tests added to buildbot 2019-03-05 4:09 ` ronnie sahlberg @ 2019-03-05 5:00 ` Steve French 2019-03-05 5:07 ` ronnie sahlberg 2019-03-05 6:01 ` Steve French 0 siblings, 2 replies; 8+ messages in thread From: Steve French @ 2019-03-05 5:00 UTC (permalink / raw) To: ronnie sahlberg; +Cc: CIFS I tried it to Samba a few minutes ago and it worked fine with current for-next and also:q it looks important (data integrity etc.). Test description # Test that mmap read doesn't see non-zero data past EOF on truncate down. # # This is inspired by an XFS bug that truncate down fails to zero page cache # beyond new EOF and causes stale data written to disk unexpectedly and a # subsequent mmap reads and sees non-zeros post EOF. I have two test targets, both Samba localhost. One succeeds for all 8 of the ones that we were worried about: ./check -cifs generic/013 generic/014 generic/024 generic/030 generic/069 generic/075 generic/112 generic/125 generic/346 generic/469 The other succeeds on all but 075 and 112 which worked on the 'old' xfstests from a month ago, but fail on the one with the newer xfstests. So I think we are ok with 469 ... but we do have to figure out what to do with what seems to be either a regression in 075 and 112 xfstests (a bug in the tests) or something that the updated tests are now seeing as a cifs bug. My theory is that it is due to this xfstest commit: root@smf-Thinkpad-P51:~/xfstests-dev# git log tests/generic/075 commit ec295d73ac19a42d1f022cb074d0bd506252cb3b Author: Christoph Hellwig <hch@lst.de> Date: Fri Feb 15 13:41:40 2019 +0100 generic/075,112: detect preallocation support for fsx tests Currently generic/075 and generic/112 have two extra fsx passes each that exercise fsx with preallocation, which are only enabled for XFS. These tests can also be run with other file systems, given that the XFS prealloc ioctls are implemented in generic code since the addition of the fallocate system call. This also means a version of XFS that does not support preallocation (e.g. because it always writes out of place) can skip the prealloc tests while still completing the normal fsx tests just fine. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Eryu Guan <guaneryu@gmail.com> Signed-off-by: Eryu Guan <guaneryu@gmail.com> On Mon, Mar 4, 2019 at 10:10 PM ronnie sahlberg <ronniesahlberg@gmail.com> wrote: > > generic/469 does it work for you? > It fails in the tests. > > I have tried it locally and it always fails here. With current > for-next as well as for-next as of a month ago. > Same for xfs-tests, with current as well as months old master. > > Lets remove it. > > On Sun, Mar 3, 2019 at 3:05 PM Steve French <smfrench@gmail.com> wrote: > > > > Added four xfs subtests to the cifs-testing buildbot (and 3 of these > > were also missing from the Azure buildbot so added them to Azure as > > well) > > + [ "generic/464", "smb3"], > > + [ "generic/469", "smb3"], > > + [ "generic/524", "smb3"], > > + [ "generic/528", "smb3samba], > > > > Testing the three new tests for Azure in > > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/105 > > > > > > -- > > Thanks, > > > > Steve -- Thanks, Steve ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: More tests added to buildbot 2019-03-05 5:00 ` Steve French @ 2019-03-05 5:07 ` ronnie sahlberg 2019-03-05 5:17 ` Steve French 2019-03-05 5:22 ` ronnie sahlberg 2019-03-05 6:01 ` Steve French 1 sibling, 2 replies; 8+ messages in thread From: ronnie sahlberg @ 2019-03-05 5:07 UTC (permalink / raw) To: Steve French; +Cc: CIFS On Tue, Mar 5, 2019 at 3:00 PM Steve French <smfrench@gmail.com> wrote: > > I tried it to Samba a few minutes ago and it worked fine with current for-next > and also:q it looks important (data integrity etc.). Test description > > # Test that mmap read doesn't see non-zero data past EOF on truncate down. > # > # This is inspired by an XFS bug that truncate down fails to zero page cache > # beyond new EOF and causes stale data written to disk unexpectedly and a > # subsequent mmap reads and sees non-zeros post EOF. > > I have two test targets, both Samba localhost. One succeeds for all 8 of > the ones that we were worried about: > > ./check -cifs generic/013 generic/014 generic/024 generic/030 > generic/069 generic/075 generic/112 generic/125 generic/346 > generic/469 generic/469 works against samba but not against windows. So we need to change the buildbot to run it against smb3samba instead of smb3. > > The other succeeds on all but 075 and 112 which worked on the 'old' > xfstests from a month ago, but fail on the one with the newer > xfstests. > > So I think we are ok with 469 ... but we do have to figure out what to > do with what seems to be either a regression in 075 and 112 xfstests > (a bug in the tests) or something that the updated tests are now > seeing as a cifs bug. My theory is that it is due to this xfstest > commit: > > root@smf-Thinkpad-P51:~/xfstests-dev# git log tests/generic/075 > commit ec295d73ac19a42d1f022cb074d0bd506252cb3b > Author: Christoph Hellwig <hch@lst.de> > Date: Fri Feb 15 13:41:40 2019 +0100 > > generic/075,112: detect preallocation support for fsx tests > > Currently generic/075 and generic/112 have two extra fsx passes each > that exercise fsx with preallocation, which are only enabled for > XFS. > > These tests can also be run with other file systems, given that the > XFS prealloc ioctls are implemented in generic code since the > addition of the fallocate system call. This also means a version of > XFS that does not support preallocation (e.g. because it always > writes out of place) can skip the prealloc tests while still > completing the normal fsx tests just fine. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Eryu Guan <guaneryu@gmail.com> > Signed-off-by: Eryu Guan <guaneryu@gmail.com> > > On Mon, Mar 4, 2019 at 10:10 PM ronnie sahlberg > <ronniesahlberg@gmail.com> wrote: > > > > generic/469 does it work for you? > > It fails in the tests. > > > > I have tried it locally and it always fails here. With current > > for-next as well as for-next as of a month ago. > > Same for xfs-tests, with current as well as months old master. > > > > Lets remove it. > > > > On Sun, Mar 3, 2019 at 3:05 PM Steve French <smfrench@gmail.com> wrote: > > > > > > Added four xfs subtests to the cifs-testing buildbot (and 3 of these > > > were also missing from the Azure buildbot so added them to Azure as > > > well) > > > + [ "generic/464", "smb3"], > > > + [ "generic/469", "smb3"], > > > + [ "generic/524", "smb3"], > > > + [ "generic/528", "smb3samba], > > > > > > Testing the three new tests for Azure in > > > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/105 > > > > > > > > > -- > > > Thanks, > > > > > > Steve > > > > -- > Thanks, > > Steve ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: More tests added to buildbot 2019-03-05 5:07 ` ronnie sahlberg @ 2019-03-05 5:17 ` Steve French 2019-03-05 5:22 ` ronnie sahlberg 1 sibling, 0 replies; 8+ messages in thread From: Steve French @ 2019-03-05 5:17 UTC (permalink / raw) To: ronnie sahlberg; +Cc: CIFS ok - sounds reasonable - although that sounds like a bug (that a simple test like this could fail against Windows) I am a little puzzled about the xfstest change a few weeks ago that affects tests 075/112 (now that our xfstests have been updated) I think it is due to it running more loops, due to seeing we support preallocate: running strace on that I see an ioctl ioctl(3, _IOC(_IOC_WRITE, 0x58, 0x2a, 0x30), 0x7ffdf08d0080) = 0 strace xfs_io -f -c "resvsp 0 1" testfile so that succeeds ... so presumably it thinks we support fallocate and then do the extra loop which fails?! On Mon, Mar 4, 2019 at 11:07 PM ronnie sahlberg <ronniesahlberg@gmail.com> wrote: > > On Tue, Mar 5, 2019 at 3:00 PM Steve French <smfrench@gmail.com> wrote: > > > > I tried it to Samba a few minutes ago and it worked fine with current for-next > > and also:q it looks important (data integrity etc.). Test description > > > > # Test that mmap read doesn't see non-zero data past EOF on truncate down. > > # > > # This is inspired by an XFS bug that truncate down fails to zero page cache > > # beyond new EOF and causes stale data written to disk unexpectedly and a > > # subsequent mmap reads and sees non-zeros post EOF. > > > > I have two test targets, both Samba localhost. One succeeds for all 8 of > > the ones that we were worried about: > > > > ./check -cifs generic/013 generic/014 generic/024 generic/030 > > generic/069 generic/075 generic/112 generic/125 generic/346 > > generic/469 > > generic/469 works against samba but not against windows. > So we need to change the buildbot to run it against smb3samba instead of smb3. > > > > > > The other succeeds on all but 075 and 112 which worked on the 'old' > > xfstests from a month ago, but fail on the one with the newer > > xfstests. > > > > So I think we are ok with 469 ... but we do have to figure out what to > > do with what seems to be either a regression in 075 and 112 xfstests > > (a bug in the tests) or something that the updated tests are now > > seeing as a cifs bug. My theory is that it is due to this xfstest > > commit: > > > > root@smf-Thinkpad-P51:~/xfstests-dev# git log tests/generic/075 > > commit ec295d73ac19a42d1f022cb074d0bd506252cb3b > > Author: Christoph Hellwig <hch@lst.de> > > Date: Fri Feb 15 13:41:40 2019 +0100 > > > > generic/075,112: detect preallocation support for fsx tests > > > > Currently generic/075 and generic/112 have two extra fsx passes each > > that exercise fsx with preallocation, which are only enabled for > > XFS. > > > > These tests can also be run with other file systems, given that the > > XFS prealloc ioctls are implemented in generic code since the > > addition of the fallocate system call. This also means a version of > > XFS that does not support preallocation (e.g. because it always > > writes out of place) can skip the prealloc tests while still > > completing the normal fsx tests just fine. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Eryu Guan <guaneryu@gmail.com> > > Signed-off-by: Eryu Guan <guaneryu@gmail.com> > > > > On Mon, Mar 4, 2019 at 10:10 PM ronnie sahlberg > > <ronniesahlberg@gmail.com> wrote: > > > > > > generic/469 does it work for you? > > > It fails in the tests. > > > > > > I have tried it locally and it always fails here. With current > > > for-next as well as for-next as of a month ago. > > > Same for xfs-tests, with current as well as months old master. > > > > > > Lets remove it. > > > > > > On Sun, Mar 3, 2019 at 3:05 PM Steve French <smfrench@gmail.com> wrote: > > > > > > > > Added four xfs subtests to the cifs-testing buildbot (and 3 of these > > > > were also missing from the Azure buildbot so added them to Azure as > > > > well) > > > > + [ "generic/464", "smb3"], > > > > + [ "generic/469", "smb3"], > > > > + [ "generic/524", "smb3"], > > > > + [ "generic/528", "smb3samba], > > > > > > > > Testing the three new tests for Azure in > > > > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/105 > > > > > > > > > > > > -- > > > > Thanks, > > > > > > > > Steve > > > > > > > > -- > > Thanks, > > > > Steve -- Thanks, Steve ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: More tests added to buildbot 2019-03-05 5:07 ` ronnie sahlberg 2019-03-05 5:17 ` Steve French @ 2019-03-05 5:22 ` ronnie sahlberg 1 sibling, 0 replies; 8+ messages in thread From: ronnie sahlberg @ 2019-03-05 5:22 UTC (permalink / raw) To: Steve French; +Cc: CIFS Lets remove 075 and 112 for now. On Tue, Mar 5, 2019 at 3:07 PM ronnie sahlberg <ronniesahlberg@gmail.com> wrote: > > On Tue, Mar 5, 2019 at 3:00 PM Steve French <smfrench@gmail.com> wrote: > > > > I tried it to Samba a few minutes ago and it worked fine with current for-next > > and also:q it looks important (data integrity etc.). Test description > > > > # Test that mmap read doesn't see non-zero data past EOF on truncate down. > > # > > # This is inspired by an XFS bug that truncate down fails to zero page cache > > # beyond new EOF and causes stale data written to disk unexpectedly and a > > # subsequent mmap reads and sees non-zeros post EOF. > > > > I have two test targets, both Samba localhost. One succeeds for all 8 of > > the ones that we were worried about: > > > > ./check -cifs generic/013 generic/014 generic/024 generic/030 > > generic/069 generic/075 generic/112 generic/125 generic/346 > > generic/469 > > generic/469 works against samba but not against windows. > So we need to change the buildbot to run it against smb3samba instead of smb3. > > > > > > The other succeeds on all but 075 and 112 which worked on the 'old' > > xfstests from a month ago, but fail on the one with the newer > > xfstests. > > > > So I think we are ok with 469 ... but we do have to figure out what to > > do with what seems to be either a regression in 075 and 112 xfstests > > (a bug in the tests) or something that the updated tests are now > > seeing as a cifs bug. My theory is that it is due to this xfstest > > commit: > > > > root@smf-Thinkpad-P51:~/xfstests-dev# git log tests/generic/075 > > commit ec295d73ac19a42d1f022cb074d0bd506252cb3b > > Author: Christoph Hellwig <hch@lst.de> > > Date: Fri Feb 15 13:41:40 2019 +0100 > > > > generic/075,112: detect preallocation support for fsx tests > > > > Currently generic/075 and generic/112 have two extra fsx passes each > > that exercise fsx with preallocation, which are only enabled for > > XFS. > > > > These tests can also be run with other file systems, given that the > > XFS prealloc ioctls are implemented in generic code since the > > addition of the fallocate system call. This also means a version of > > XFS that does not support preallocation (e.g. because it always > > writes out of place) can skip the prealloc tests while still > > completing the normal fsx tests just fine. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Eryu Guan <guaneryu@gmail.com> > > Signed-off-by: Eryu Guan <guaneryu@gmail.com> > > > > On Mon, Mar 4, 2019 at 10:10 PM ronnie sahlberg > > <ronniesahlberg@gmail.com> wrote: > > > > > > generic/469 does it work for you? > > > It fails in the tests. > > > > > > I have tried it locally and it always fails here. With current > > > for-next as well as for-next as of a month ago. > > > Same for xfs-tests, with current as well as months old master. > > > > > > Lets remove it. > > > > > > On Sun, Mar 3, 2019 at 3:05 PM Steve French <smfrench@gmail.com> wrote: > > > > > > > > Added four xfs subtests to the cifs-testing buildbot (and 3 of these > > > > were also missing from the Azure buildbot so added them to Azure as > > > > well) > > > > + [ "generic/464", "smb3"], > > > > + [ "generic/469", "smb3"], > > > > + [ "generic/524", "smb3"], > > > > + [ "generic/528", "smb3samba], > > > > > > > > Testing the three new tests for Azure in > > > > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/105 > > > > > > > > > > > > -- > > > > Thanks, > > > > > > > > Steve > > > > > > > > -- > > Thanks, > > > > Steve ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: More tests added to buildbot 2019-03-05 5:00 ` Steve French 2019-03-05 5:07 ` ronnie sahlberg @ 2019-03-05 6:01 ` Steve French 2019-03-05 7:21 ` Xiaoli Feng 1 sibling, 1 reply; 8+ messages in thread From: Steve French @ 2019-03-05 6:01 UTC (permalink / raw) To: ronnie sahlberg; +Cc: CIFS Rather than back 075 and 112 out I reverted xfstest tests/generic/075 and 112 to their state from a few weeks ago by backing out the patch I mentioned below Kicked off http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/110 with that change to the buildbot On Mon, Mar 4, 2019 at 11:00 PM Steve French <smfrench@gmail.com> wrote: > > I tried it to Samba a few minutes ago and it worked fine with current for-next > and also:q it looks important (data integrity etc.). Test description > > # Test that mmap read doesn't see non-zero data past EOF on truncate down. > # > # This is inspired by an XFS bug that truncate down fails to zero page cache > # beyond new EOF and causes stale data written to disk unexpectedly and a > # subsequent mmap reads and sees non-zeros post EOF. > > I have two test targets, both Samba localhost. One succeeds for all 8 of > the ones that we were worried about: > > ./check -cifs generic/013 generic/014 generic/024 generic/030 > generic/069 generic/075 generic/112 generic/125 generic/346 > generic/469 > > The other succeeds on all but 075 and 112 which worked on the 'old' > xfstests from a month ago, but fail on the one with the newer > xfstests. > > So I think we are ok with 469 ... but we do have to figure out what to > do with what seems to be either a regression in 075 and 112 xfstests > (a bug in the tests) or something that the updated tests are now > seeing as a cifs bug. My theory is that it is due to this xfstest > commit: > > root@smf-Thinkpad-P51:~/xfstests-dev# git log tests/generic/075 > commit ec295d73ac19a42d1f022cb074d0bd506252cb3b > Author: Christoph Hellwig <hch@lst.de> > Date: Fri Feb 15 13:41:40 2019 +0100 > > generic/075,112: detect preallocation support for fsx tests > > Currently generic/075 and generic/112 have two extra fsx passes each > that exercise fsx with preallocation, which are only enabled for > XFS. > > These tests can also be run with other file systems, given that the > XFS prealloc ioctls are implemented in generic code since the > addition of the fallocate system call. This also means a version of > XFS that does not support preallocation (e.g. because it always > writes out of place) can skip the prealloc tests while still > completing the normal fsx tests just fine. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Eryu Guan <guaneryu@gmail.com> > Signed-off-by: Eryu Guan <guaneryu@gmail.com> > > On Mon, Mar 4, 2019 at 10:10 PM ronnie sahlberg > <ronniesahlberg@gmail.com> wrote: > > > > generic/469 does it work for you? > > It fails in the tests. > > > > I have tried it locally and it always fails here. With current > > for-next as well as for-next as of a month ago. > > Same for xfs-tests, with current as well as months old master. > > > > Lets remove it. > > > > On Sun, Mar 3, 2019 at 3:05 PM Steve French <smfrench@gmail.com> wrote: > > > > > > Added four xfs subtests to the cifs-testing buildbot (and 3 of these > > > were also missing from the Azure buildbot so added them to Azure as > > > well) > > > + [ "generic/464", "smb3"], > > > + [ "generic/469", "smb3"], > > > + [ "generic/524", "smb3"], > > > + [ "generic/528", "smb3samba], > > > > > > Testing the three new tests for Azure in > > > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/105 > > > > > > > > > -- > > > Thanks, > > > > > > Steve > > > > -- > Thanks, > > Steve -- Thanks, Steve ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: More tests added to buildbot 2019-03-05 6:01 ` Steve French @ 2019-03-05 7:21 ` Xiaoli Feng 0 siblings, 0 replies; 8+ messages in thread From: Xiaoli Feng @ 2019-03-05 7:21 UTC (permalink / raw) To: Steve French; +Cc: ronnie sahlberg, CIFS JFYI. As I know, generic/075 generic/112 are failed for cifs because cifs doesn't support this function: ioctl(fd, FIDEDUPERANGE, fdr). And this function test was included by this xfstests patch: commit e7b6734822aa4ea4986c1576f0414b1174da33c7 Author: Darrick J. Wong <darrick.wong@oracle.com> Date: Thu Dec 6 22:24:20 2018 -0800 fsx: add FIDEDUPERANGE support Add support for the dedupe range ioctl to fsx. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Eryu Guan <guaneryu@gmail.com> Signed-off-by: Eryu Guan <guaneryu@gmail.com> ----- Original Message ----- > From: "Steve French" <smfrench@gmail.com> > To: "ronnie sahlberg" <ronniesahlberg@gmail.com> > Cc: "CIFS" <linux-cifs@vger.kernel.org> > Sent: Tuesday, March 5, 2019 2:01:45 PM > Subject: Re: More tests added to buildbot > > Rather than back 075 and 112 out I reverted xfstest tests/generic/075 > and 112 to their state from a few weeks ago by backing out the patch I > mentioned below > > Kicked off > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/110 > with that change to the buildbot > > On Mon, Mar 4, 2019 at 11:00 PM Steve French <smfrench@gmail.com> wrote: > > > > I tried it to Samba a few minutes ago and it worked fine with current > > for-next > > and also:q it looks important (data integrity etc.). Test description > > > > # Test that mmap read doesn't see non-zero data past EOF on truncate down. > > # > > # This is inspired by an XFS bug that truncate down fails to zero page > > cache > > # beyond new EOF and causes stale data written to disk unexpectedly and a > > # subsequent mmap reads and sees non-zeros post EOF. > > > > I have two test targets, both Samba localhost. One succeeds for all 8 of > > the ones that we were worried about: > > > > ./check -cifs generic/013 generic/014 generic/024 generic/030 > > generic/069 generic/075 generic/112 generic/125 generic/346 > > generic/469 > > > > The other succeeds on all but 075 and 112 which worked on the 'old' > > xfstests from a month ago, but fail on the one with the newer > > xfstests. > > > > So I think we are ok with 469 ... but we do have to figure out what to > > do with what seems to be either a regression in 075 and 112 xfstests > > (a bug in the tests) or something that the updated tests are now > > seeing as a cifs bug. My theory is that it is due to this xfstest > > commit: > > > > root@smf-Thinkpad-P51:~/xfstests-dev# git log tests/generic/075 > > commit ec295d73ac19a42d1f022cb074d0bd506252cb3b > > Author: Christoph Hellwig <hch@lst.de> > > Date: Fri Feb 15 13:41:40 2019 +0100 > > > > generic/075,112: detect preallocation support for fsx tests > > > > Currently generic/075 and generic/112 have two extra fsx passes each > > that exercise fsx with preallocation, which are only enabled for > > XFS. > > > > These tests can also be run with other file systems, given that the > > XFS prealloc ioctls are implemented in generic code since the > > addition of the fallocate system call. This also means a version of > > XFS that does not support preallocation (e.g. because it always > > writes out of place) can skip the prealloc tests while still > > completing the normal fsx tests just fine. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Eryu Guan <guaneryu@gmail.com> > > Signed-off-by: Eryu Guan <guaneryu@gmail.com> > > > > On Mon, Mar 4, 2019 at 10:10 PM ronnie sahlberg > > <ronniesahlberg@gmail.com> wrote: > > > > > > generic/469 does it work for you? > > > It fails in the tests. > > > > > > I have tried it locally and it always fails here. With current > > > for-next as well as for-next as of a month ago. > > > Same for xfs-tests, with current as well as months old master. > > > > > > Lets remove it. > > > > > > On Sun, Mar 3, 2019 at 3:05 PM Steve French <smfrench@gmail.com> wrote: > > > > > > > > Added four xfs subtests to the cifs-testing buildbot (and 3 of these > > > > were also missing from the Azure buildbot so added them to Azure as > > > > well) > > > > + [ "generic/464", "smb3"], > > > > + [ "generic/469", "smb3"], > > > > + [ "generic/524", "smb3"], > > > > + [ "generic/528", "smb3samba], > > > > > > > > Testing the three new tests for Azure in > > > > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/105 > > > > > > > > > > > > -- > > > > Thanks, > > > > > > > > Steve > > > > > > > > -- > > Thanks, > > > > Steve > > > > -- > Thanks, > > Steve > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-05 7:21 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-03-03 5:05 More tests added to buildbot Steve French 2019-03-05 4:09 ` ronnie sahlberg 2019-03-05 5:00 ` Steve French 2019-03-05 5:07 ` ronnie sahlberg 2019-03-05 5:17 ` Steve French 2019-03-05 5:22 ` ronnie sahlberg 2019-03-05 6:01 ` Steve French 2019-03-05 7:21 ` Xiaoli Feng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).