* Re: [PATCH 14/15] ksmbd: use ksmbd name instead of cifsd [not found] ` <009301d76677$8b52a6b0$a1f7f410$@samsung.com> @ 2021-06-22 6:03 ` 'Christoph Hellwig' [not found] ` <CAGvGhF43zhqkLn0GBjdm28cT_wufJr0CJ4LGZOVV=SFpOr9YyA@mail.gmail.com> 0 siblings, 1 reply; 2+ messages in thread From: 'Christoph Hellwig' @ 2021-06-22 6:03 UTC (permalink / raw) To: Namjae Jeon Cc: 'Christoph Hellwig', linux-cifsd-devel, linux-cifs, linux-fsdevel On Mon, Jun 21, 2021 at 05:29:25PM +0900, Namjae Jeon wrote: > > On Fri, Jun 18, 2021 at 11:26:44AM +0900, Namjae Jeon wrote: > > > Use ksmbd name instead of cifsd. > > > > I think you probably want to move fs/cifsd to fs/ksmbd/ as well then. > We had a lot of discussion about this and decided to leave the directory name as cifsd. > Please see: > https://lkml.org/lkml/2021/4/6/1296 I can't really agree with that argument. If we have a module that is called ksmbd fs/ksmbd/ is the right place for it. And having a smb_common module used by ksmbd and cifs should not be too bad for those who know just a little about the smb/cifs history. ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <CAGvGhF43zhqkLn0GBjdm28cT_wufJr0CJ4LGZOVV=SFpOr9YyA@mail.gmail.com>]
* Re: [PATCH 14/15] ksmbd: use ksmbd name instead of cifsd [not found] ` <CAGvGhF43zhqkLn0GBjdm28cT_wufJr0CJ4LGZOVV=SFpOr9YyA@mail.gmail.com> @ 2021-06-22 7:41 ` Christoph Hellwig 0 siblings, 0 replies; 2+ messages in thread From: Christoph Hellwig @ 2021-06-22 7:41 UTC (permalink / raw) To: Leif Sahlberg Cc: Christoph Hellwig, Namjae Jeon, linux-cifsd-devel, linux-cifs, linux-fsdevel On Tue, Jun 22, 2021 at 05:33:50PM +1000, Leif Sahlberg wrote: > > Understood. > In that case, what are your thoughts about renaming the current client > fs/cifs tree to fs/smb ? If it was newly added I'd be all in favor. Renaming an existing codebase is rather painful, though. So I'd rather live with the historic misnaming (and think of the historic smbfs predating the current cifs driver :)) ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-22 7:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210618022645.27307-1-namjae.jeon@samsung.com>
[not found] ` <CGME20210618023614epcas1p4f33df1322709076c65a63f5013f9c2cc@epcas1p4.samsung.com>
[not found] ` <20210618022645.27307-14-namjae.jeon@samsung.com>
[not found] ` <YNBKb2UJQ8D4JhcO@infradead.org>
[not found] ` <009301d76677$8b52a6b0$a1f7f410$@samsung.com>
2021-06-22 6:03 ` [PATCH 14/15] ksmbd: use ksmbd name instead of cifsd 'Christoph Hellwig'
[not found] ` <CAGvGhF43zhqkLn0GBjdm28cT_wufJr0CJ4LGZOVV=SFpOr9YyA@mail.gmail.com>
2021-06-22 7:41 ` Christoph Hellwig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).