Re: [PATCH 14/15] ksmbd: use ksmbd name instead of cifsd

Re: [PATCH 14/15] ksmbd: use ksmbd name instead of cifsd

['Christoph Hellwig']

On Mon, Jun 21, 2021 at 05:29:25PM +0900, Namjae Jeon wrote:
> > On Fri, Jun 18, 2021 at 11:26:44AM +0900, Namjae Jeon wrote:
> > > Use ksmbd name instead of cifsd.
> > 
> > I think you probably want to move fs/cifsd to fs/ksmbd/ as well then.
> We had a lot of discussion about this and decided to leave the directory name as cifsd.
> Please see:
>    https://lkml.org/lkml/2021/4/6/1296

I can't really agree with that argument.  If we have a module that is
called ksmbd fs/ksmbd/ is the right place for it.  And having a
smb_common module used by ksmbd and cifs should not be too bad for those
who know just a little about the smb/cifs history.

Re: [PATCH 14/15] ksmbd: use ksmbd name instead of cifsd

[Christoph Hellwig]

On Tue, Jun 22, 2021 at 05:33:50PM +1000, Leif Sahlberg wrote:
> > Understood.
>  In that case, what are your thoughts about renaming the current client
> fs/cifs tree to fs/smb ?

If it was newly added I'd be all in favor.  Renaming an existing
codebase is rather painful, though.  So I'd rather live with the
historic misnaming (and think of the historic smbfs predating the
current cifs driver :))