linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cifs: cifs_md4 convert to SPDX identifier
@ 2021-08-24 17:15 Steve French
  2021-08-25  6:15 ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Steve French @ 2021-08-24 17:15 UTC (permalink / raw)
  To: CIFS

[-- Attachment #1: Type: text/plain, Size: 95 bytes --]

Add SPDX license identifier and replace license boilerplate
for cifs_md4.c

-- 
Thanks,

Steve

[-- Attachment #2: 0001-cifs-cifs_md4-convert-to-SPDX-identifier.patch --]
[-- Type: text/x-patch, Size: 1636 bytes --]

From 2cc08e732805ad6f99d78e5013dbf3d06eb13772 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Tue, 24 Aug 2021 12:07:46 -0500
Subject: [PATCH] cifs: cifs_md4 convert to SPDX identifier

Add SPDX license identifier and replace license boilerplate
for cifs_md4.c

Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/smb2maperror.c    | 2 +-
 fs/cifs_common/cifs_md4.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/cifs/smb2maperror.c b/fs/cifs/smb2maperror.c
index cea39bcecbab..8ba4aa3e0d8d 100644
--- a/fs/cifs/smb2maperror.c
+++ b/fs/cifs/smb2maperror.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/smb2/smb2maperror.c
+ *   fs/cifs/smb2maperror.c
  *
  *   Functions which do error mapping of SMB2 status codes to POSIX errors
  *
diff --git a/fs/cifs_common/cifs_md4.c b/fs/cifs_common/cifs_md4.c
index dbf9113b8600..cc12e4cedb96 100644
--- a/fs/cifs_common/cifs_md4.c
+++ b/fs/cifs_common/cifs_md4.c
@@ -1,4 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
+ * fs/cifs_common/cifs_md4.c
+ *
  * Cryptographic API.
  *
  * MD4 Message Digest Algorithm (RFC1320).
@@ -14,11 +17,6 @@
  * Copyright (c) 2002 David S. Miller (davem@redhat.com)
  * Copyright (c) 2002 James Morris <jmorris@intercode.com.au>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
  */
 #include <linux/init.h>
 #include <linux/kernel.h>
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cifs: cifs_md4 convert to SPDX identifier
  2021-08-24 17:15 [PATCH] cifs: cifs_md4 convert to SPDX identifier Steve French
@ 2021-08-25  6:15 ` Christoph Hellwig
  2021-08-25 20:53   ` Steve French
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2021-08-25  6:15 UTC (permalink / raw)
  To: Steve French; +Cc: CIFS

On Tue, Aug 24, 2021 at 12:15:05PM -0500, Steve French wrote:
> - *   fs/smb2/smb2maperror.c
> + *   fs/cifs/smb2maperror.c


>  /*
> + * fs/cifs_common/cifs_md4.c
> + *

This is a good reminder on why putting the file name into the top of
file comment is stupid.  Just don't do it.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cifs: cifs_md4 convert to SPDX identifier
  2021-08-25  6:15 ` Christoph Hellwig
@ 2021-08-25 20:53   ` Steve French
  0 siblings, 0 replies; 3+ messages in thread
From: Steve French @ 2021-08-25 20:53 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: CIFS

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Removed the file name from the top of header comments as suggested.

On Wed, Aug 25, 2021 at 1:16 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Tue, Aug 24, 2021 at 12:15:05PM -0500, Steve French wrote:
> > - *   fs/smb2/smb2maperror.c
> > + *   fs/cifs/smb2maperror.c
>
>
> >  /*
> > + * fs/cifs_common/cifs_md4.c
> > + *
>
> This is a good reminder on why putting the file name into the top of
> file comment is stupid.  Just don't do it.
>


-- 
Thanks,

Steve

[-- Attachment #2: 0001-cifs-cifs_md4-convert-to-SPDX-identifier.patch --]
[-- Type: text/x-patch, Size: 1525 bytes --]

From 38f4910b8b26d3a940167f207bddfcc589310c8a Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Tue, 24 Aug 2021 12:07:46 -0500
Subject: [PATCH] cifs: cifs_md4 convert to SPDX identifier

Add SPDX license identifier and replace license boilerplate
for cifs_md4.c

Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/smb2maperror.c    | 1 -
 fs/cifs_common/cifs_md4.c | 6 +-----
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/fs/cifs/smb2maperror.c b/fs/cifs/smb2maperror.c
index cea39bcecbab..181514b8770d 100644
--- a/fs/cifs/smb2maperror.c
+++ b/fs/cifs/smb2maperror.c
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/smb2/smb2maperror.c
  *
  *   Functions which do error mapping of SMB2 status codes to POSIX errors
  *
diff --git a/fs/cifs_common/cifs_md4.c b/fs/cifs_common/cifs_md4.c
index dbf9113b8600..50f78cfc6ce9 100644
--- a/fs/cifs_common/cifs_md4.c
+++ b/fs/cifs_common/cifs_md4.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Cryptographic API.
  *
@@ -14,11 +15,6 @@
  * Copyright (c) 2002 David S. Miller (davem@redhat.com)
  * Copyright (c) 2002 James Morris <jmorris@intercode.com.au>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
  */
 #include <linux/init.h>
 #include <linux/kernel.h>
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-25 20:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 17:15 [PATCH] cifs: cifs_md4 convert to SPDX identifier Steve French
2021-08-25  6:15 ` Christoph Hellwig
2021-08-25 20:53   ` Steve French

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).