Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
	Sameer Pujar <spujar@nvidia.com>,
	thierry.reding@gmail.com, jonathanh@nvidia.com,
	broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
	tiwai@suse.com, mperttunen@nvidia.com,
	gregkh@linuxfoundation.org, sboyd@kernel.org, robh+dt@kernel.org,
	mark.rutland@arm.com
Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, josephl@nvidia.com,
	daniel.lezcano@linaro.org, mmaddireddy@nvidia.com,
	markz@nvidia.com, devicetree@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 00/21] Move PMC clocks into Tegra PMC driver
Date: Fri, 10 Jan 2020 17:54:45 +0300
Message-ID: <06919c0e-d0a5-5cf6-ba94-758fe9e1cdd6@gmail.com> (raw)
In-Reply-To: <dbb80785-59a8-6725-f43b-babe27ebbaeb@nvidia.com>

10.01.2020 07:47, Sowjanya Komatineni пишет:
> 
> On 1/9/20 8:43 PM, Sameer Pujar wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 1/10/2020 10:06 AM, Sowjanya Komatineni wrote:
>>>
>>> On 1/9/20 7:32 PM, Sowjanya Komatineni wrote:
>>>>
>>>> On 1/9/20 7:24 PM, Sowjanya Komatineni wrote:
>>>>>
>>>>> On 1/9/20 5:39 PM, Sowjanya Komatineni wrote:
>>>>>>
>>>>>> On 1/9/20 11:44 AM, Dmitry Osipenko wrote:
>>>>>>> External email: Use caution opening links or attachments
>>>>>>>
>>>>>>>
>>>>>>> 08.01.2020 07:24, Sowjanya Komatineni пишет:
>>>>>>>> This patch series moves Tegra PMC clocks from clock driver to pmc
>>>>>>>> driver
>>>>>>>> along with the device trees changes and audio driver which uses
>>>>>>>> one of
>>>>>>>> the pmc clock for audio mclk.
>>>>>>>>
>>>>>>>> Tegra PMC has clk_out_1, clk_out_2, clk_out_3 and blink controls
>>>>>>>> which
>>>>>>>> are currently registered by Tegra clock driver using
>>>>>>>> clk_regiser_mux and
>>>>>>>> clk_register_gate which performs direct Tegra PMC register access.
>>>>>>>>
>>>>>>>> When Tegra PMC is in secure mode, any access from non-secure
>>>>>>>> world will
>>>>>>>> not go through.
>>>>>>>>
>>>>>>>> This patch series adds these Tegra PMC clocks and blink controls
>>>>>>>> to Tegra
>>>>>>>> PMC driver with PMC as clock provider and removes them from Tegra
>>>>>>>> clock
>>>>>>>> driver.
>>>>>>>>
>>>>>>>> PMC clock clk_out_1 is dedicated for audio mclk from Tegra30 thru
>>>>>>>> Tegra210
>>>>>>>> and clock driver does inital parent configuration for it and
>>>>>>>> enables them.
>>>>>>>> But this clock should be taken care by audio driver as there is
>>>>>>>> no need
>>>>>>>> to have this clock pre enabled.
>>>>>>>>
>>>>>>>> So, this series also includes patch that updates ASoC driver to
>>>>>>>> take
>>>>>>>> care of parent configuration for mclk if device tree don't specify
>>>>>>>> initial parent configuration using assigned-clock-parents and
>>>>>>>> controls
>>>>>>>> audio mclk enable/disable during ASoC machine startup and shutdown.
>>>>>>>>
>>>>>>>> DTs are also updated to use clk_out_1 as audio mclk rather than
>>>>>>>> extern1.
>>>>>>>>
>>>>>>>> This series also includes a patch for mclk fallback to extern1 when
>>>>>>>> retrieving mclk fails to have this backward compatible of new DT
>>>>>>>> with
>>>>>>>> old kernels.
>>>>>>> Suspend-resume doesn't work anymore, reverting this series helps. I
>>>>>>> don't have any other information yet, please take a look.
>>>>>> Thanks Dmitry. Will test suspend resume and check..
>>>>>
>>>>> I see if we leave audio mclk (cdev1) enabled during
>>>>> tegra_asoc_utils_init, suspend resume works.
>>>>>
>>>>> Without audio mclk enabled during tegra_asoc_utils_init, somehow it
>>>>> prevents entry to suspend on Tegra30 platform.
>>>>>
>>>>> Will look in detail..
>>>>>
>>>> audio mclk is only needed for audio and werid that having it not
>>>> enabled all the time like in current clock driver prevents suspend
>>>> entry on Tegra30
>>>>
>>>> Looks like this issue is masked earlier with having mclk enabled all
>>>> the time by clock driver.
>>>>
>>> On linux-next without this patch series, I just disabled mclk to be
>>> enabled all the time (removed set_rate from utils_init) and also
>>> disabled default enable from clock driver.
>>>
>>> So somehow disabling mclk is preventing suspend entry.
>>
>> This is strange.
>>
>>>
>>> Probably debugging suspend issue on Tegra30 when audio mclk is
>>> disabled can be done separately and will keep audio mclk enabled in
>>> asoc_utils_init with comment mentioning this issue and fix as TBD to
>>> move on with PMC clock fixes.
>>
>> Sounds fine with me as the suspend/resume issue is not introduced in the
>> current series. It can be addressed separately.
>>
>>>
> Thanks Sameer. So, will keep mclk not enabled in clock driver but will
> do mclk enable in asoc_utils_init and will remove machine startup and
> shutdown.
> 
> mclk dependency with suspend/resume and I2S and audio clocks proper
> handling in audio driver can be taken care separately out of this series.
> 
> Dimitry, I hope you too agree with this.

Yes, should be fine to fix it separately from this series.

I suppose the clocks management isn't done properly by some of the audio
drivers and machine hangs after trying to access hardware module which
has the disabled clock. That's a quite typical bug.

      reply index

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  4:24 Sowjanya Komatineni
2020-01-08  4:24 ` [PATCH v7 01/21] dt-bindings: clock: tegra: Change CLK_M_DIV to OSC_DIV clocks Sowjanya Komatineni
2020-01-08  4:24 ` [PATCH v7 02/21] clk: tegra: Change CLK_M_DIV clocks " Sowjanya Komatineni
2020-01-08  4:24 ` [PATCH v7 03/21] dt-bindings: clock: tegra: Add DT id for OSC clock Sowjanya Komatineni
2020-01-08 19:18   ` Dmitry Osipenko
2020-01-13 22:03   ` Rob Herring
2020-01-08  4:24 ` [PATCH v7 04/21] clk: tegra: Add Tegra OSC to clock lookup Sowjanya Komatineni
2020-01-08 19:18   ` Dmitry Osipenko
2020-01-08  4:24 ` [PATCH v7 05/21] clk: tegra: Fix Tegra PMC clock out parents Sowjanya Komatineni
2020-01-08  8:34   ` Nicolas Chauvet
2020-01-09 17:18     ` Sowjanya Komatineni
2020-01-09 19:45     ` Dmitry Osipenko
2020-01-08  4:25 ` [PATCH v7 06/21] dt-bindings: tegra: Convert Tegra PMC bindings to YAML Sowjanya Komatineni
2020-01-13 22:30   ` Rob Herring
2020-01-08  4:25 ` [PATCH v7 07/21] dt-bindings: soc: tegra-pmc: Add Tegra PMC clock bindings Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 08/21] soc: tegra: Add Tegra PMC clocks registration into PMC driver Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 09/21] dt-bindings: soc: tegra-pmc: Add id for Tegra PMC 32KHz blink clock Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 10/21] soc: tegra: Add support for " Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 11/21] clk: tegra: Remove tegra_pmc_clk_init along with clk ids Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 12/21] dt-bindings: clock: tegra: Remove pmc clock ids from clock dt-bindings Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 13/21] ASoC: tegra: Use device managed resource APIs to get the clock Sowjanya Komatineni
2020-01-08  5:26   ` Sameer Pujar
2020-01-08  4:25 ` [PATCH v7 14/21] ASoC: tegra: Add audio mclk configuration Sowjanya Komatineni
2020-01-08  5:15   ` Sameer Pujar
2020-01-08  4:25 ` [PATCH v7 15/21] ASoC: tegra: Add fallback implementation for audio mclk Sowjanya Komatineni
2020-01-08  5:34   ` Sameer Pujar
2020-01-08  5:48     ` Sowjanya Komatineni
2020-01-08  6:28       ` Sameer Pujar
     [not found]         ` <745b8c7b-4fe3-c9ea-284e-b89546e8ad87@nvidia.com>
     [not found]           ` <705edf9b-d1bc-8090-017e-fa4ad445f9fb@nvidia.com>
2020-01-10 22:05             ` Dmitry Osipenko
2020-01-10 22:13               ` Sowjanya Komatineni
2020-01-10 23:02                 ` Dmitry Osipenko
2020-01-10 23:14                   ` Sowjanya Komatineni
2020-01-11 15:32                     ` Dmitry Osipenko
2020-01-08  4:25 ` [PATCH v7 16/21] clk: tegra: Remove audio related clock enables from init_table Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 17/21] ARM: dts: tegra: Add clock-cells property to pmc Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 18/21] arm64: tegra: Add clock-cells property to Tegra PMC node Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 19/21] ARM: tegra: Update sound node clocks in device tree Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 20/21] arm64: tegra: smaug: Change clk_out_2 provider to pmc Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 21/21] ASoC: nau8825: change Tegra clk_out_2 provider to tegra_pmc Sowjanya Komatineni
2020-01-09 19:44 ` [PATCH v7 00/21] Move PMC clocks into Tegra PMC driver Dmitry Osipenko
2020-01-10  1:39   ` Sowjanya Komatineni
2020-01-10  3:24     ` Sowjanya Komatineni
2020-01-10  3:32       ` Sowjanya Komatineni
2020-01-10  4:36         ` Sowjanya Komatineni
2020-01-10  4:43           ` Sameer Pujar
2020-01-10  4:47             ` Sowjanya Komatineni
2020-01-10 14:54               ` Dmitry Osipenko [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06919c0e-d0a5-5cf6-ba94-758fe9e1cdd6@gmail.com \
    --to=digetx@gmail.com \
    --cc=broonie@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=josephl@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=markz@nvidia.com \
    --cc=mmaddireddy@nvidia.com \
    --cc=mperttunen@nvidia.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=perex@perex.cz \
    --cc=pgaikwad@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=skomatineni@nvidia.com \
    --cc=spujar@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org
	public-inbox-index linux-clk

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git