Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
	Sameer Pujar <spujar@nvidia.com>,
	thierry.reding@gmail.com, jonathanh@nvidia.com,
	broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
	tiwai@suse.com, mperttunen@nvidia.com,
	gregkh@linuxfoundation.org, sboyd@kernel.org, robh+dt@kernel.org,
	mark.rutland@arm.com
Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, josephl@nvidia.com,
	daniel.lezcano@linaro.org, mmaddireddy@nvidia.com,
	markz@nvidia.com, devicetree@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 15/21] ASoC: tegra: Add fallback implementation for audio mclk
Date: Sat, 11 Jan 2020 01:05:50 +0300
Message-ID: <135f0c0b-86d1-9b1a-af02-c14c4b5308c4@gmail.com> (raw)
In-Reply-To: <705edf9b-d1bc-8090-017e-fa4ad445f9fb@nvidia.com>

10.01.2020 20:04, Sowjanya Komatineni пишет:
> 
> On 1/9/20 10:52 AM, Sowjanya Komatineni wrote:
>>
>>
>> On 1/7/20 10:28 PM, Sameer Pujar wrote:
>>>
>>> On 1/8/2020 11:18 AM, Sowjanya Komatineni wrote:
>>>>
>>>> On 1/7/20 9:34 PM, Sameer Pujar wrote:
>>>>>
>>>>> On 1/8/2020 9:55 AM, Sowjanya Komatineni wrote:
>>>>>> mclk is from clk_out_1 which is part of Tegra PMC block and pmc
>>>>>> clocks
>>>>>> are moved to Tegra PMC driver with pmc as clock provider and using
>>>>>> pmc
>>>>>> clock ids.
>>>>>>
>>>>>> New device tree uses clk_out_1 from pmc clock provider.
>>>>>>
>>>>>> So, this patch adds implementation for mclk fallback to extern1 when
>>>>>> retrieving mclk returns -ENOENT to be backward compatible of new
>>>>>> device
>>>>>> tree with older kernels.
>>>>>>
>>>>>> Tested-by: Dmitry Osipenko <digetx@gmail.com>
>>>>>> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
>>>>>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>>>>> ---
>>>>>>   sound/soc/tegra/tegra_asoc_utils.c | 11 ++++++++++-
>>>>>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/sound/soc/tegra/tegra_asoc_utils.c
>>>>>> b/sound/soc/tegra/tegra_asoc_utils.c
>>>>>> index 9cfebef74870..9a5f81039491 100644
>>>>>> --- a/sound/soc/tegra/tegra_asoc_utils.c
>>>>>> +++ b/sound/soc/tegra/tegra_asoc_utils.c
>>>>>> @@ -183,7 +183,16 @@ int tegra_asoc_utils_init(struct
>>>>>> tegra_asoc_utils_data *data,
>>>>>>       data->clk_cdev1 = devm_clk_get(dev, "mclk");
>>>>>>       if (IS_ERR(data->clk_cdev1)) {
>>>>>>           dev_err(data->dev, "Can't retrieve clk cdev1\n");
>>>>>
>>>>> This error print can be moved inside below if, when this actually
>>>>> meant to be an error condition.
>>>>>
>>>> Want to show error even if mclk retrieval returns ENOENT to clearly
>>>> indicate mclk does not exist along with message of falling back to
>>>> extern1.
>>>
>>> Yes, but falling back essentially means 'mclk' is not available and
>>> fallback print is not an error.
>>> Not a major issue though, you can consider updating. Otherwise LGTM.
>>>
>> Will update
>>>>>> -        return PTR_ERR(data->clk_cdev1);
>>>>>> +        if (PTR_ERR(data->clk_cdev1) != -ENOENT)
>>>>>> +            return PTR_ERR(data->clk_cdev1);
>>>>>> +        /* Fall back to extern1 */
>>>>>> +        data->clk_cdev1 = devm_clk_get(dev, "extern1");
>>>>>> +        if (IS_ERR(data->clk_cdev1)) {
>>>>>> +            dev_err(data->dev, "Can't retrieve clk extern1\n");
>>>>>> +            return PTR_ERR(data->clk_cdev1);
>>>>>> +        }
>>>>>> +
>>>>>> +        dev_err(data->dev, "Falling back to extern1\n");
>>>>>
>>>>> This can be a info print?
>>>>
>> Will use dev_info
>>>>>>       }
>>>>>>         /*
>>
>> Dmitry/Rob, there was discussion in v3 regarding backporting mclk
>> fallback.
>>
>> Dmitry wanted Rob to confirm on this
>>
>> I think openSUSE Leap could be one of those distros that use LTS kernel
>> with newer device-trees, but that's not 100%. Maybe Rob could help
>> clarifying that.
>>
>> Dmitry/Rob, Can you please confirm if mclk fallback patch need
>> backport to have new device tree work with old kernels?
>>
> Dmitry,
> 
> Can you please confirm if we need to backport this mclk fallback patch?
> 

Seems only T210 was making use of the CaR's TEGRA*_CLK_CLK_OUT_*, thus
the backporting isn't needed.

Also, please use 'git rebase --exec make ...' to make sure that all
patches are compiling without problems. The removal of the legacy clock
IDs should be done after the device-trees changes, otherwise it looks
like DTBs compilation will fail. It's possible that the order of the
patches could be changed if Thierry will chose to split this series into
several pull requests, nevertheless all patches should compile and work
in the original order.

  parent reply index

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  4:24 [PATCH v7 00/21] Move PMC clocks into Tegra PMC driver Sowjanya Komatineni
2020-01-08  4:24 ` [PATCH v7 01/21] dt-bindings: clock: tegra: Change CLK_M_DIV to OSC_DIV clocks Sowjanya Komatineni
2020-01-08  4:24 ` [PATCH v7 02/21] clk: tegra: Change CLK_M_DIV clocks " Sowjanya Komatineni
2020-01-08  4:24 ` [PATCH v7 03/21] dt-bindings: clock: tegra: Add DT id for OSC clock Sowjanya Komatineni
2020-01-08 19:18   ` Dmitry Osipenko
2020-01-13 22:03   ` Rob Herring
2020-01-08  4:24 ` [PATCH v7 04/21] clk: tegra: Add Tegra OSC to clock lookup Sowjanya Komatineni
2020-01-08 19:18   ` Dmitry Osipenko
2020-01-08  4:24 ` [PATCH v7 05/21] clk: tegra: Fix Tegra PMC clock out parents Sowjanya Komatineni
2020-01-08  8:34   ` Nicolas Chauvet
2020-01-09 17:18     ` Sowjanya Komatineni
2020-01-09 19:45     ` Dmitry Osipenko
2020-01-08  4:25 ` [PATCH v7 06/21] dt-bindings: tegra: Convert Tegra PMC bindings to YAML Sowjanya Komatineni
2020-01-13 22:30   ` Rob Herring
2020-01-08  4:25 ` [PATCH v7 07/21] dt-bindings: soc: tegra-pmc: Add Tegra PMC clock bindings Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 08/21] soc: tegra: Add Tegra PMC clocks registration into PMC driver Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 09/21] dt-bindings: soc: tegra-pmc: Add id for Tegra PMC 32KHz blink clock Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 10/21] soc: tegra: Add support for " Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 11/21] clk: tegra: Remove tegra_pmc_clk_init along with clk ids Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 12/21] dt-bindings: clock: tegra: Remove pmc clock ids from clock dt-bindings Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 13/21] ASoC: tegra: Use device managed resource APIs to get the clock Sowjanya Komatineni
2020-01-08  5:26   ` Sameer Pujar
2020-01-08  4:25 ` [PATCH v7 14/21] ASoC: tegra: Add audio mclk configuration Sowjanya Komatineni
2020-01-08  5:15   ` Sameer Pujar
2020-01-08  4:25 ` [PATCH v7 15/21] ASoC: tegra: Add fallback implementation for audio mclk Sowjanya Komatineni
2020-01-08  5:34   ` Sameer Pujar
2020-01-08  5:48     ` Sowjanya Komatineni
2020-01-08  6:28       ` Sameer Pujar
     [not found]         ` <745b8c7b-4fe3-c9ea-284e-b89546e8ad87@nvidia.com>
     [not found]           ` <705edf9b-d1bc-8090-017e-fa4ad445f9fb@nvidia.com>
2020-01-10 22:05             ` Dmitry Osipenko [this message]
2020-01-10 22:13               ` Sowjanya Komatineni
2020-01-10 23:02                 ` Dmitry Osipenko
2020-01-10 23:14                   ` Sowjanya Komatineni
2020-01-11 15:32                     ` Dmitry Osipenko
2020-01-08  4:25 ` [PATCH v7 16/21] clk: tegra: Remove audio related clock enables from init_table Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 17/21] ARM: dts: tegra: Add clock-cells property to pmc Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 18/21] arm64: tegra: Add clock-cells property to Tegra PMC node Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 19/21] ARM: tegra: Update sound node clocks in device tree Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 20/21] arm64: tegra: smaug: Change clk_out_2 provider to pmc Sowjanya Komatineni
2020-01-08  4:25 ` [PATCH v7 21/21] ASoC: nau8825: change Tegra clk_out_2 provider to tegra_pmc Sowjanya Komatineni
2020-01-09 19:44 ` [PATCH v7 00/21] Move PMC clocks into Tegra PMC driver Dmitry Osipenko
2020-01-10  1:39   ` Sowjanya Komatineni
2020-01-10  3:24     ` Sowjanya Komatineni
2020-01-10  3:32       ` Sowjanya Komatineni
2020-01-10  4:36         ` Sowjanya Komatineni
2020-01-10  4:43           ` Sameer Pujar
2020-01-10  4:47             ` Sowjanya Komatineni
2020-01-10 14:54               ` Dmitry Osipenko

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=135f0c0b-86d1-9b1a-af02-c14c4b5308c4@gmail.com \
    --to=digetx@gmail.com \
    --cc=broonie@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=josephl@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=markz@nvidia.com \
    --cc=mmaddireddy@nvidia.com \
    --cc=mperttunen@nvidia.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=perex@perex.cz \
    --cc=pgaikwad@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=skomatineni@nvidia.com \
    --cc=spujar@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org
	public-inbox-index linux-clk

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git