From: Stephen Boyd <sboyd@kernel.org>
To: matthias.bgg@gmail.com, matthias.bgg@kernel.org, mturquette@baylibre.com
Cc: jasu@njomotys.info, sean.wang@kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 3/3] clk: mediatek: Mark bus and DRAM related clocks as critical
Date: Thu, 29 Nov 2018 22:48:51 -0800 [thread overview]
Message-ID: <154356053181.88331.12262289931983027816@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181116180901.17737-4-matthias.bgg@kernel.org>
Quoting matthias.bgg@kernel.org (2018-11-16 10:09:01)
> From: Jasper Mattsson <jasu@njomotys.info>
>
> This marks MUXes axi_sel and ddrphycfg_sel as well as gates
> infra_dramc_f26m and infra_dramc_b_f26m as with CLK_IS_CRITICAL.
>
> Fixes: 96596aa06628 ("clk: mediatek: add clk support for MT6797")
> Signed-off-by: Jasper Mattsson <jasu@njomotys.info>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
Can you add comments in the commit text and in the code about why the
CLK_IS_CRITICAL flag is added to these clks? It makes it easier to
figure out why the flag is there months from now when we all forget
next prev parent reply other threads:[~2018-11-30 6:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 18:08 [PATCH v2 0/3] Mark clocks as critical for MT6797 matthias.bgg
2018-11-16 18:08 ` [PATCH v2 1/3] clk: mediatek: Add MUX_FLAGS macro matthias.bgg
2018-11-16 18:09 ` [PATCH v2 2/3] clk: mediatek: Add flags to mtk_gate matthias.bgg
2018-11-30 6:50 ` Stephen Boyd
2018-11-16 18:09 ` [PATCH v2 3/3] clk: mediatek: Mark bus and DRAM related clocks as critical matthias.bgg
2018-11-30 6:48 ` Stephen Boyd [this message]
2018-11-30 6:47 ` [PATCH v2 0/3] Mark clocks as critical for MT6797 Stephen Boyd
2018-11-30 9:04 ` Matthias Brugger
2019-01-07 20:56 ` Stephen Boyd
2019-01-08 3:05 ` Mars Cheng
2019-01-08 9:55 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154356053181.88331.12262289931983027816@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=jasu@njomotys.info \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mturquette@baylibre.com \
--cc=sean.wang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).