Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] clk: ux500: Fix up the SGA clock for some variants
@ 2019-12-17 21:05 Linus Walleij
  2019-12-18 14:28 ` Ulf Hansson
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Linus Walleij @ 2019-12-17 21:05 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd
  Cc: linux-clk, Linus Walleij, Ulf Hansson, Stephan Gerhold

Some of the special PRCMU firmware variants were not
properly detected in the Ux500 clock driver, resulting
in the wrong clock for the SGA.

Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/clk/ux500/u8500_of_clk.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/ux500/u8500_of_clk.c b/drivers/clk/ux500/u8500_of_clk.c
index 72ed97c6662a..0aedd42fad52 100644
--- a/drivers/clk/ux500/u8500_of_clk.c
+++ b/drivers/clk/ux500/u8500_of_clk.c
@@ -99,8 +99,10 @@ static void u8500_clk_init(struct device_node *np)
 	if (fw_version != NULL) {
 		switch (fw_version->project) {
 		case PRCMU_FW_PROJECT_U8500_C2:
+		case PRCMU_FW_PROJECT_U8500_MBL:
 		case PRCMU_FW_PROJECT_U8520:
 		case PRCMU_FW_PROJECT_U8420:
+		case PRCMU_FW_PROJECT_U8420_SYSCLK:
 			sgaclk_parent = "soc0_pll";
 			break;
 		default:
-- 
2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: ux500: Fix up the SGA clock for some variants
  2019-12-17 21:05 [PATCH] clk: ux500: Fix up the SGA clock for some variants Linus Walleij
@ 2019-12-18 14:28 ` Ulf Hansson
  2019-12-18 18:50 ` Stephan Gerhold
  2020-01-05  7:27 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2019-12-18 14:28 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Michael Turquette, Stephen Boyd, linux-clk, Stephan Gerhold

On Tue, 17 Dec 2019 at 22:05, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Some of the special PRCMU firmware variants were not
> properly detected in the Ux500 clock driver, resulting
> in the wrong clock for the SGA.
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

> ---
>  drivers/clk/ux500/u8500_of_clk.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/ux500/u8500_of_clk.c b/drivers/clk/ux500/u8500_of_clk.c
> index 72ed97c6662a..0aedd42fad52 100644
> --- a/drivers/clk/ux500/u8500_of_clk.c
> +++ b/drivers/clk/ux500/u8500_of_clk.c
> @@ -99,8 +99,10 @@ static void u8500_clk_init(struct device_node *np)
>         if (fw_version != NULL) {
>                 switch (fw_version->project) {
>                 case PRCMU_FW_PROJECT_U8500_C2:
> +               case PRCMU_FW_PROJECT_U8500_MBL:
>                 case PRCMU_FW_PROJECT_U8520:
>                 case PRCMU_FW_PROJECT_U8420:
> +               case PRCMU_FW_PROJECT_U8420_SYSCLK:
>                         sgaclk_parent = "soc0_pll";
>                         break;
>                 default:
> --
> 2.21.0
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: ux500: Fix up the SGA clock for some variants
  2019-12-17 21:05 [PATCH] clk: ux500: Fix up the SGA clock for some variants Linus Walleij
  2019-12-18 14:28 ` Ulf Hansson
@ 2019-12-18 18:50 ` Stephan Gerhold
  2020-01-05  7:27 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Stephan Gerhold @ 2019-12-18 18:50 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Michael Turquette, Stephen Boyd, linux-clk, Ulf Hansson

On Tue, Dec 17, 2019 at 10:05:04PM +0100, Linus Walleij wrote:
> Some of the special PRCMU firmware variants were not
> properly detected in the Ux500 clock driver, resulting
> in the wrong clock for the SGA.
> 
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Stephan Gerhold <stephan@gerhold.net>

> ---
>  drivers/clk/ux500/u8500_of_clk.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/ux500/u8500_of_clk.c b/drivers/clk/ux500/u8500_of_clk.c
> index 72ed97c6662a..0aedd42fad52 100644
> --- a/drivers/clk/ux500/u8500_of_clk.c
> +++ b/drivers/clk/ux500/u8500_of_clk.c
> @@ -99,8 +99,10 @@ static void u8500_clk_init(struct device_node *np)
>  	if (fw_version != NULL) {
>  		switch (fw_version->project) {
>  		case PRCMU_FW_PROJECT_U8500_C2:
> +		case PRCMU_FW_PROJECT_U8500_MBL:
>  		case PRCMU_FW_PROJECT_U8520:
>  		case PRCMU_FW_PROJECT_U8420:
> +		case PRCMU_FW_PROJECT_U8420_SYSCLK:
>  			sgaclk_parent = "soc0_pll";
>  			break;
>  		default:
> -- 
> 2.21.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: ux500: Fix up the SGA clock for some variants
  2019-12-17 21:05 [PATCH] clk: ux500: Fix up the SGA clock for some variants Linus Walleij
  2019-12-18 14:28 ` Ulf Hansson
  2019-12-18 18:50 ` Stephan Gerhold
@ 2020-01-05  7:27 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2020-01-05  7:27 UTC (permalink / raw)
  To: Linus Walleij, Michael Turquette
  Cc: linux-clk, Linus Walleij, Ulf Hansson, Stephan Gerhold

Quoting Linus Walleij (2019-12-17 13:05:04)
> Some of the special PRCMU firmware variants were not
> properly detected in the Ux500 clock driver, resulting
> in the wrong clock for the SGA.
> 
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---

Applied to clk-next


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 21:05 [PATCH] clk: ux500: Fix up the SGA clock for some variants Linus Walleij
2019-12-18 14:28 ` Ulf Hansson
2019-12-18 18:50 ` Stephan Gerhold
2020-01-05  7:27 ` Stephen Boyd

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org
	public-inbox-index linux-clk

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git