* [PATCH] clk: Pass correct arguments to __clk_hw_register_gate()
@ 2020-03-25 2:22 Stephen Boyd
2020-03-25 2:28 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2020-03-25 2:22 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd; +Cc: linux-kernel, linux-clk, Maxime Ripard
I copy/pasted these macros and forgot to update the argument
names and where they're passed to. Fix it so that these macros make
sense.
Reported-by: Maxime Ripard <maxime@cerno.tech>
Fixes: 194efb6e2667 ("clk: gate: Add support for specifying parents via DT/pointers")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
include/linux/clk-provider.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 952ac035bab9..95cc8a4f6e39 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -522,9 +522,9 @@ struct clk *clk_register_gate(struct device *dev, const char *name,
* @clk_gate_flags: gate-specific flags for this clock
* @lock: shared register lock for this clock
*/
-#define clk_hw_register_gate_parent_hw(dev, name, parent_name, flags, reg, \
+#define clk_hw_register_gate_parent_hw(dev, name, parent_hw, flags, reg, \
bit_idx, clk_gate_flags, lock) \
- __clk_hw_register_gate((dev), NULL, (name), (parent_name), NULL, \
+ __clk_hw_register_gate((dev), NULL, (name), NULL, (parent_hw), \
NULL, (flags), (reg), (bit_idx), \
(clk_gate_flags), (lock))
/**
@@ -539,10 +539,10 @@ struct clk *clk_register_gate(struct device *dev, const char *name,
* @clk_gate_flags: gate-specific flags for this clock
* @lock: shared register lock for this clock
*/
-#define clk_hw_register_gate_parent_data(dev, name, parent_name, flags, reg, \
+#define clk_hw_register_gate_parent_data(dev, name, parent_data, flags, reg, \
bit_idx, clk_gate_flags, lock) \
- __clk_hw_register_gate((dev), NULL, (name), (parent_name), NULL, \
- NULL, (flags), (reg), (bit_idx), \
+ __clk_hw_register_gate((dev), NULL, (name), NULL, NULL, (parent_data) \
+ (flags), (reg), (bit_idx), \
(clk_gate_flags), (lock))
void clk_unregister_gate(struct clk *clk);
void clk_hw_unregister_gate(struct clk_hw *hw);
--
Sent by a computer, using git, on the internet
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: Pass correct arguments to __clk_hw_register_gate()
2020-03-25 2:22 [PATCH] clk: Pass correct arguments to __clk_hw_register_gate() Stephen Boyd
@ 2020-03-25 2:28 ` Stephen Boyd
2020-03-25 15:32 ` Maxime Ripard
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2020-03-25 2:28 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd; +Cc: linux-kernel, linux-clk, Maxime Ripard
Quoting Stephen Boyd (2020-03-24 19:22:57)
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index 952ac035bab9..95cc8a4f6e39 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -539,10 +539,10 @@ struct clk *clk_register_gate(struct device *dev, const char *name,
> * @clk_gate_flags: gate-specific flags for this clock
> * @lock: shared register lock for this clock
> */
> -#define clk_hw_register_gate_parent_data(dev, name, parent_name, flags, reg, \
> +#define clk_hw_register_gate_parent_data(dev, name, parent_data, flags, reg, \
> bit_idx, clk_gate_flags, lock) \
> - __clk_hw_register_gate((dev), NULL, (name), (parent_name), NULL, \
> - NULL, (flags), (reg), (bit_idx), \
> + __clk_hw_register_gate((dev), NULL, (name), NULL, NULL, (parent_data) \
And this needs a comma after it.
I'll apply this to clk-fixes and send to Linus in the next few days.
> + (flags), (reg), (bit_idx), \
> (clk_gate_flags), (lock))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: Pass correct arguments to __clk_hw_register_gate()
2020-03-25 2:28 ` Stephen Boyd
@ 2020-03-25 15:32 ` Maxime Ripard
0 siblings, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2020-03-25 15:32 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Michael Turquette, linux-kernel, linux-clk
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
On Tue, Mar 24, 2020 at 07:28:12PM -0700, Stephen Boyd wrote:
> Quoting Stephen Boyd (2020-03-24 19:22:57)
> > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> > index 952ac035bab9..95cc8a4f6e39 100644
> > --- a/include/linux/clk-provider.h
> > +++ b/include/linux/clk-provider.h
> > @@ -539,10 +539,10 @@ struct clk *clk_register_gate(struct device *dev, const char *name,
> > * @clk_gate_flags: gate-specific flags for this clock
> > * @lock: shared register lock for this clock
> > */
> > -#define clk_hw_register_gate_parent_data(dev, name, parent_name, flags, reg, \
> > +#define clk_hw_register_gate_parent_data(dev, name, parent_data, flags, reg, \
> > bit_idx, clk_gate_flags, lock) \
> > - __clk_hw_register_gate((dev), NULL, (name), (parent_name), NULL, \
> > - NULL, (flags), (reg), (bit_idx), \
> > + __clk_hw_register_gate((dev), NULL, (name), NULL, NULL, (parent_data) \
>
> And this needs a comma after it.
>
> I'll apply this to clk-fixes and send to Linus in the next few days.
With that fix,
Tested-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-25 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 2:22 [PATCH] clk: Pass correct arguments to __clk_hw_register_gate() Stephen Boyd
2020-03-25 2:28 ` Stephen Boyd
2020-03-25 15:32 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).