From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Stephan Müller" <smueller@chronox.de>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH 00/13] crypto: copy AAD during encrypt for AEAD ciphers
Date: Thu, 12 Jan 2017 14:19:36 +0800 [thread overview]
Message-ID: <20170112061936.GA10325@gondor.apana.org.au> (raw)
In-Reply-To: <10526995.lyZ7Je1KMx@positron.chronox.de>
On Tue, Jan 10, 2017 at 02:36:21AM +0100, Stephan Müller wrote:
>
> to all driver maintainers: the patches I added are compile tested, but
> I do not have the hardware to verify the code. May I ask the respective
> hardware maintainers to verify that the code is appropriate and works
> as intended? Thanks a lot.
>
> Herbert, this is my proprosal for our discussion around copying the
> AAD for algif_aead. Instead of adding the code to algif_aead and wait
> until it transpires to all cipher implementations, I thought it would
> be more helpful to fix all cipher implementations.
I think it's too much churn. Let's get the algif_aead code fixed
up first, and then pursue this later.
BTW, why are you only doing the copy for encryption?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-01-12 6:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 1:36 [PATCH 00/13] crypto: copy AAD during encrypt for AEAD ciphers Stephan Müller
2017-01-10 1:36 ` [PATCH 01/13] crypto: service function to copy AAD from src to dst Stephan Müller
2017-01-10 1:37 ` [PATCH 02/13] crypto: gcm_generic - copy AAD during encryption Stephan Müller
2017-01-10 1:37 ` [PATCH 03/13] crypto: ccm_generic " Stephan Müller
2017-01-10 1:37 ` [PATCH 04/13] crypto: rfc4106-gcm-aesni " Stephan Müller
2017-01-10 1:38 ` [PATCH 05/13] crypto: ccm-aes-ce " Stephan Müller
2017-01-10 1:38 ` [PATCH 06/13] crypto: talitos " Stephan Müller
2017-01-10 1:38 ` [PATCH 07/13] crypto: picoxcell " Stephan Müller
2017-01-10 1:39 ` [PATCH 08/13] crypto: ixp4xx " Stephan Müller
2017-01-10 1:39 ` [PATCH 09/13] crypto: atmel " Stephan Müller
2017-01-10 1:39 ` [PATCH 10/13] crypto: caam " Stephan Müller
2017-01-10 1:40 ` [PATCH 11/13] crypto: chelsio " Stephan Müller
2017-01-10 1:40 ` [PATCH 12/13] crypto: nx " Stephan Müller
2017-01-10 1:41 ` [PATCH 13/13] crypto: qat " Stephan Müller
2017-01-12 6:19 ` Herbert Xu [this message]
2017-01-12 11:22 ` [PATCH 00/13] crypto: copy AAD during encrypt for AEAD ciphers Stephan Müller
2017-01-12 14:57 ` Herbert Xu
2017-01-12 15:23 ` Stephan Müller
2017-01-12 15:27 ` Herbert Xu
2017-01-12 15:34 ` Stephan Müller
2017-01-12 15:39 ` Herbert Xu
2017-01-12 15:50 ` Stephan Müller
2017-01-12 15:53 ` Herbert Xu
2017-01-12 16:01 ` Stephan Müller
2017-01-12 16:06 ` Herbert Xu
2017-01-12 16:37 ` Stephan Müller
2017-01-13 10:23 ` Herbert Xu
2017-01-13 10:58 ` Stephan Müller
2017-01-13 11:04 ` Herbert Xu
2017-01-13 11:12 ` Stephan Müller
2017-01-13 11:14 ` Herbert Xu
2017-01-13 11:19 ` Stephan Müller
2017-01-13 11:26 ` Herbert Xu
2017-01-13 11:30 ` Stephan Müller
2017-01-13 11:33 ` Herbert Xu
2017-01-13 11:36 ` Stephan Müller
2017-01-13 11:39 ` Herbert Xu
2017-01-20 17:07 ` Cyrille Pitchen
2017-01-20 20:28 ` Stephan Müller
2017-01-23 13:10 ` Herbert Xu
2017-01-12 12:43 ` Stephan Müller
2017-01-18 14:57 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112061936.GA10325@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).