* [PATCH -next] crypto: streebog - remove two unused variables @ 2019-08-09 8:49 YueHaibing 2019-08-09 15:04 ` Vitaly Chikunov 2019-08-15 12:07 ` Herbert Xu 0 siblings, 2 replies; 3+ messages in thread From: YueHaibing @ 2019-08-09 8:49 UTC (permalink / raw) To: herbert, davem; +Cc: linux-kernel, linux-crypto, YueHaibing crypto/streebog_generic.c:162:17: warning: Pi defined but not used [-Wunused-const-variable=] crypto/streebog_generic.c:151:17: warning: Tau defined but not used [-Wunused-const-variable=] They are never used, so can be removed. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- crypto/streebog_generic.c | 46 ---------------------------------------------- 1 file changed, 46 deletions(-) diff --git a/crypto/streebog_generic.c b/crypto/streebog_generic.c index 63663c3..dc625ff 100644 --- a/crypto/streebog_generic.c +++ b/crypto/streebog_generic.c @@ -148,52 +148,6 @@ static const struct streebog_uint512 C[12] = { } } }; -static const u8 Tau[64] = { - 0, 8, 16, 24, 32, 40, 48, 56, - 1, 9, 17, 25, 33, 41, 49, 57, - 2, 10, 18, 26, 34, 42, 50, 58, - 3, 11, 19, 27, 35, 43, 51, 59, - 4, 12, 20, 28, 36, 44, 52, 60, - 5, 13, 21, 29, 37, 45, 53, 61, - 6, 14, 22, 30, 38, 46, 54, 62, - 7, 15, 23, 31, 39, 47, 55, 63 -}; - -static const u8 Pi[256] = { - 252, 238, 221, 17, 207, 110, 49, 22, - 251, 196, 250, 218, 35, 197, 4, 77, - 233, 119, 240, 219, 147, 46, 153, 186, - 23, 54, 241, 187, 20, 205, 95, 193, - 249, 24, 101, 90, 226, 92, 239, 33, - 129, 28, 60, 66, 139, 1, 142, 79, - 5, 132, 2, 174, 227, 106, 143, 160, - 6, 11, 237, 152, 127, 212, 211, 31, - 235, 52, 44, 81, 234, 200, 72, 171, - 242, 42, 104, 162, 253, 58, 206, 204, - 181, 112, 14, 86, 8, 12, 118, 18, - 191, 114, 19, 71, 156, 183, 93, 135, - 21, 161, 150, 41, 16, 123, 154, 199, - 243, 145, 120, 111, 157, 158, 178, 177, - 50, 117, 25, 61, 255, 53, 138, 126, - 109, 84, 198, 128, 195, 189, 13, 87, - 223, 245, 36, 169, 62, 168, 67, 201, - 215, 121, 214, 246, 124, 34, 185, 3, - 224, 15, 236, 222, 122, 148, 176, 188, - 220, 232, 40, 80, 78, 51, 10, 74, - 167, 151, 96, 115, 30, 0, 98, 68, - 26, 184, 56, 130, 100, 159, 38, 65, - 173, 69, 70, 146, 39, 94, 85, 47, - 140, 163, 165, 125, 105, 213, 149, 59, - 7, 88, 179, 64, 134, 172, 29, 247, - 48, 55, 107, 228, 136, 217, 231, 137, - 225, 27, 131, 73, 76, 63, 248, 254, - 141, 83, 170, 144, 202, 216, 133, 97, - 32, 113, 103, 164, 45, 43, 9, 91, - 203, 155, 37, 208, 190, 229, 108, 82, - 89, 166, 116, 210, 230, 244, 180, 192, - 209, 102, 175, 194, 57, 75, 99, 182 -}; - static const unsigned long long Ax[8][256] = { { 0xd01f715b5c7ef8e6ULL, 0x16fa240980778325ULL, 0xa8a42e857ee049c8ULL, -- 2.7.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] crypto: streebog - remove two unused variables 2019-08-09 8:49 [PATCH -next] crypto: streebog - remove two unused variables YueHaibing @ 2019-08-09 15:04 ` Vitaly Chikunov 2019-08-15 12:07 ` Herbert Xu 1 sibling, 0 replies; 3+ messages in thread From: Vitaly Chikunov @ 2019-08-09 15:04 UTC (permalink / raw) To: YueHaibing; +Cc: herbert, davem, linux-kernel, linux-crypto On Fri, Aug 09, 2019 at 04:49:05PM +0800, YueHaibing wrote: > crypto/streebog_generic.c:162:17: warning: > Pi defined but not used [-Wunused-const-variable=] > crypto/streebog_generic.c:151:17: warning: > Tau defined but not used [-Wunused-const-variable=] > > They are never used, so can be removed. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Vitaly Chikunov <vt@altlinux.org> > --- > crypto/streebog_generic.c | 46 ---------------------------------------------- > 1 file changed, 46 deletions(-) > > diff --git a/crypto/streebog_generic.c b/crypto/streebog_generic.c > index 63663c3..dc625ff 100644 > --- a/crypto/streebog_generic.c > +++ b/crypto/streebog_generic.c > @@ -148,52 +148,6 @@ static const struct streebog_uint512 C[12] = { > } } > }; > > -static const u8 Tau[64] = { > - 0, 8, 16, 24, 32, 40, 48, 56, > - 1, 9, 17, 25, 33, 41, 49, 57, > - 2, 10, 18, 26, 34, 42, 50, 58, > - 3, 11, 19, 27, 35, 43, 51, 59, > - 4, 12, 20, 28, 36, 44, 52, 60, > - 5, 13, 21, 29, 37, 45, 53, 61, > - 6, 14, 22, 30, 38, 46, 54, 62, > - 7, 15, 23, 31, 39, 47, 55, 63 > -}; > - > -static const u8 Pi[256] = { > - 252, 238, 221, 17, 207, 110, 49, 22, > - 251, 196, 250, 218, 35, 197, 4, 77, > - 233, 119, 240, 219, 147, 46, 153, 186, > - 23, 54, 241, 187, 20, 205, 95, 193, > - 249, 24, 101, 90, 226, 92, 239, 33, > - 129, 28, 60, 66, 139, 1, 142, 79, > - 5, 132, 2, 174, 227, 106, 143, 160, > - 6, 11, 237, 152, 127, 212, 211, 31, > - 235, 52, 44, 81, 234, 200, 72, 171, > - 242, 42, 104, 162, 253, 58, 206, 204, > - 181, 112, 14, 86, 8, 12, 118, 18, > - 191, 114, 19, 71, 156, 183, 93, 135, > - 21, 161, 150, 41, 16, 123, 154, 199, > - 243, 145, 120, 111, 157, 158, 178, 177, > - 50, 117, 25, 61, 255, 53, 138, 126, > - 109, 84, 198, 128, 195, 189, 13, 87, > - 223, 245, 36, 169, 62, 168, 67, 201, > - 215, 121, 214, 246, 124, 34, 185, 3, > - 224, 15, 236, 222, 122, 148, 176, 188, > - 220, 232, 40, 80, 78, 51, 10, 74, > - 167, 151, 96, 115, 30, 0, 98, 68, > - 26, 184, 56, 130, 100, 159, 38, 65, > - 173, 69, 70, 146, 39, 94, 85, 47, > - 140, 163, 165, 125, 105, 213, 149, 59, > - 7, 88, 179, 64, 134, 172, 29, 247, > - 48, 55, 107, 228, 136, 217, 231, 137, > - 225, 27, 131, 73, 76, 63, 248, 254, > - 141, 83, 170, 144, 202, 216, 133, 97, > - 32, 113, 103, 164, 45, 43, 9, 91, > - 203, 155, 37, 208, 190, 229, 108, 82, > - 89, 166, 116, 210, 230, 244, 180, 192, > - 209, 102, 175, 194, 57, 75, 99, 182 > -}; > - > static const unsigned long long Ax[8][256] = { > { > 0xd01f715b5c7ef8e6ULL, 0x16fa240980778325ULL, 0xa8a42e857ee049c8ULL, > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] crypto: streebog - remove two unused variables 2019-08-09 8:49 [PATCH -next] crypto: streebog - remove two unused variables YueHaibing 2019-08-09 15:04 ` Vitaly Chikunov @ 2019-08-15 12:07 ` Herbert Xu 1 sibling, 0 replies; 3+ messages in thread From: Herbert Xu @ 2019-08-15 12:07 UTC (permalink / raw) To: YueHaibing; +Cc: davem, linux-kernel, linux-crypto On Fri, Aug 09, 2019 at 04:49:05PM +0800, YueHaibing wrote: > crypto/streebog_generic.c:162:17: warning: > Pi defined but not used [-Wunused-const-variable=] > crypto/streebog_generic.c:151:17: warning: > Tau defined but not used [-Wunused-const-variable=] > > They are never used, so can be removed. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > crypto/streebog_generic.c | 46 ---------------------------------------------- > 1 file changed, 46 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-15 12:07 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-08-09 8:49 [PATCH -next] crypto: streebog - remove two unused variables YueHaibing 2019-08-09 15:04 ` Vitaly Chikunov 2019-08-15 12:07 ` Herbert Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).