* [PATCH -next] crypto: chelsio - remove set but not used variable 'adap'
@ 2020-03-14 10:44 YueHaibing
2020-03-15 16:10 ` rohit maheshwari
2020-03-20 3:51 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2020-03-14 10:44 UTC (permalink / raw)
To: Ayush Sawal, Vinay Kumar Yadav, Rohit Maheshwari, Herbert Xu
Cc: YueHaibing, linux-crypto, kernel-janitors
drivers/crypto/chelsio/chcr_algo.c: In function 'chcr_device_init':
drivers/crypto/chelsio/chcr_algo.c:1440:18: warning:
variable 'adap' set but not used [-Wunused-but-set-variable]
commit 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm
to process the requests") involved this unused variable.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/crypto/chelsio/chcr_algo.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
index 8952732c0b7d..c29b80dd30d8 100644
--- a/drivers/crypto/chelsio/chcr_algo.c
+++ b/drivers/crypto/chelsio/chcr_algo.c
@@ -1437,7 +1437,6 @@ static int chcr_aes_decrypt(struct skcipher_request *req)
static int chcr_device_init(struct chcr_context *ctx)
{
struct uld_ctx *u_ctx = NULL;
- struct adapter *adap;
int txq_perchan, ntxq;
int err = 0, rxq_perchan;
@@ -1448,7 +1447,6 @@ static int chcr_device_init(struct chcr_context *ctx)
goto out;
}
ctx->dev = &u_ctx->dev;
- adap = padap(ctx->dev);
ntxq = u_ctx->lldi.ntxq;
rxq_perchan = u_ctx->lldi.nrxq / u_ctx->lldi.nchan;
txq_perchan = ntxq / u_ctx->lldi.nchan;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] crypto: chelsio - remove set but not used variable 'adap'
2020-03-14 10:44 [PATCH -next] crypto: chelsio - remove set but not used variable 'adap' YueHaibing
@ 2020-03-15 16:10 ` rohit maheshwari
2020-03-20 3:51 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: rohit maheshwari @ 2020-03-15 16:10 UTC (permalink / raw)
To: YueHaibing, Ayush Sawal, Vinay Kumar Yadav, Herbert Xu
Cc: linux-crypto, kernel-janitors
On 14/03/20 4:14 PM, YueHaibing wrote:
> drivers/crypto/chelsio/chcr_algo.c: In function 'chcr_device_init':
> drivers/crypto/chelsio/chcr_algo.c:1440:18: warning:
> variable 'adap' set but not used [-Wunused-but-set-variable]
>
> commit 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm
> to process the requests") involved this unused variable.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/crypto/chelsio/chcr_algo.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
> index 8952732c0b7d..c29b80dd30d8 100644
> --- a/drivers/crypto/chelsio/chcr_algo.c
> +++ b/drivers/crypto/chelsio/chcr_algo.c
> @@ -1437,7 +1437,6 @@ static int chcr_aes_decrypt(struct skcipher_request *req)
> static int chcr_device_init(struct chcr_context *ctx)
> {
> struct uld_ctx *u_ctx = NULL;
> - struct adapter *adap;
> int txq_perchan, ntxq;
> int err = 0, rxq_perchan;
>
> @@ -1448,7 +1447,6 @@ static int chcr_device_init(struct chcr_context *ctx)
> goto out;
> }
> ctx->dev = &u_ctx->dev;
> - adap = padap(ctx->dev);
> ntxq = u_ctx->lldi.ntxq;
> rxq_perchan = u_ctx->lldi.nrxq / u_ctx->lldi.nchan;
> txq_perchan = ntxq / u_ctx->lldi.nchan;
>
Thanks for fixing it. Looks good to me.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] crypto: chelsio - remove set but not used variable 'adap'
2020-03-14 10:44 [PATCH -next] crypto: chelsio - remove set but not used variable 'adap' YueHaibing
2020-03-15 16:10 ` rohit maheshwari
@ 2020-03-20 3:51 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-03-20 3:51 UTC (permalink / raw)
To: YueHaibing
Cc: Ayush Sawal, Vinay Kumar Yadav, Rohit Maheshwari, linux-crypto,
kernel-janitors
On Sat, Mar 14, 2020 at 10:44:41AM +0000, YueHaibing wrote:
> drivers/crypto/chelsio/chcr_algo.c: In function 'chcr_device_init':
> drivers/crypto/chelsio/chcr_algo.c:1440:18: warning:
> variable 'adap' set but not used [-Wunused-but-set-variable]
>
> commit 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm
> to process the requests") involved this unused variable.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/crypto/chelsio/chcr_algo.c | 2 --
> 1 file changed, 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-20 3:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-14 10:44 [PATCH -next] crypto: chelsio - remove set but not used variable 'adap' YueHaibing
2020-03-15 16:10 ` rohit maheshwari
2020-03-20 3:51 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).