Re: [PATCH v3 0/4] Raspberry Pi 4 HWRNG Support

[Florian Fainelli <f.fainelli@gmail.com>]

Hi Herbert,

On 11/19/2019 7:16 PM, Stephen Brennan wrote:
> This patch series enables support for the HWRNG included on the Raspberry
> Pi 4.  It is simply a rebase of Stefan's branch [1]. I went ahead and
> tested this out on a Pi 4.  Prior to this patch series, attempting to use
> the hwrng gives:
> 
>     $ head -c 2 /dev/hwrng
>     head: /dev/hwrng: Input/output error
> 
> After this series, the same command gives two random bytes.

When we get a review from Rob, you can take patches 1-2 through your
tree and Stefan/Nicholas can queue patches 3-4 through the BCM2835 tree
where the DTS files already exist. Does that work for you?

> 
> Changes in v3:
> - drop interrupts from bcm2711 rng node
> - move bcm283x rng into bcm2835-common.dtsi
> - add reviewed-by tag
> - separated out patch 3 into two parts
> 
> Changes in v2:
> - specify the correct size for the region in the dts, refactor bcm283x rng
> 
> ---
> 
> Stefan Wahren (2):
>   dt-bindings: rng: add BCM2711 RNG compatible
>   hwrng: iproc-rng200: Add support for BCM2711
> 
> Stephen Brennan (2):
>   ARM: dts: bcm2835: Move rng definition to common location
>   ARM: dts: bcm2711: Enable HWRNG support
> 
>  .../devicetree/bindings/rng/brcm,iproc-rng200.txt          | 1 +
>  arch/arm/boot/dts/bcm2711.dtsi                             | 7 +++----
>  arch/arm/boot/dts/bcm2835-common.dtsi                      | 6 ++++++
>  arch/arm/boot/dts/bcm283x.dtsi                             | 6 ------
>  drivers/char/hw_random/Kconfig                             | 2 +-
>  drivers/char/hw_random/iproc-rng200.c                      | 1 +
>  6 files changed, 12 insertions(+), 11 deletions(-)
> 

-- 
Florian