From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Stefan Wahren <wahrenst@gmx.net>, Stephen Brennan <stephen@brennan.io>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Scott Branden <sbranden@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-crypto@vger.kernel.org, Eric Anholt <eric@anholt.net>,
Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, Ray Jui <rjui@broadcom.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/4] Raspberry Pi 4 HWRNG Support
Date: Wed, 20 Nov 2019 20:50:14 +0100 [thread overview]
Message-ID: <6aaa37d2cbe91c177b7be2d7f8aa3846efe3dc34.camel@suse.de> (raw)
In-Reply-To: <99554159-6abb-6ea5-aebb-57a148a59b78@gmx.net>
[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]
On Wed, 2019-11-20 at 17:16 +0100, Stefan Wahren wrote:
> Hi Stephen,
>
> Am 20.11.19 um 04:16 schrieb Stephen Brennan:
> > This patch series enables support for the HWRNG included on the Raspberry
> > Pi 4. It is simply a rebase of Stefan's branch [1]. I went ahead and
> > tested this out on a Pi 4. Prior to this patch series, attempting to use
> > the hwrng gives:
> >
> > $ head -c 2 /dev/hwrng
> > head: /dev/hwrng: Input/output error
> >
> > After this series, the same command gives two random bytes.
>
> just a note: a more expressive test would be running rngtest (package
> rng-tools) on this device.
Just had a go at it,
root@rpi4:~# rngtest -c 1000 < /dev/hwrng
rngtest 2-unofficial-mt.14
Copyright (c) 2004 by Henrique de Moraes Holschuh
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
rngtest: starting FIPS tests...
rngtest: bits received from input: 20000032
rngtest: FIPS 140-2 successes: 998
rngtest: FIPS 140-2 failures: 2
rngtest: FIPS 140-2(2001-10-10) Monobit: 0
rngtest: FIPS 140-2(2001-10-10) Poker: 1
rngtest: FIPS 140-2(2001-10-10) Runs: 0
rngtest: FIPS 140-2(2001-10-10) Long run: 1
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=1.284; avg=113.786; max=126.213)Kibits/s
rngtest: FIPS tests speed: (min=17.122; avg=28.268; max=28.812)Mibits/s
rngtest: Program run time: 172323761 microseconds
AFAIR (Arch wiki) some small failures are acceptable.
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-20 19:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 3:16 [PATCH v3 0/4] Raspberry Pi 4 HWRNG Support Stephen Brennan
2019-11-20 3:16 ` [PATCH v3 1/4] dt-bindings: rng: add BCM2711 RNG compatible Stephen Brennan
2019-11-20 4:50 ` Baruch Siach
2019-11-20 5:21 ` Stephen Brennan
2019-11-20 19:55 ` Florian Fainelli
2019-11-23 0:39 ` Rob Herring
2019-11-20 3:16 ` [PATCH v3 2/4] hwrng: iproc-rng200: Add support for BCM2711 Stephen Brennan
2019-11-20 4:52 ` Baruch Siach
2019-11-20 17:33 ` Matthias Brugger
2019-11-20 19:55 ` Florian Fainelli
2019-11-20 3:16 ` [PATCH v3 3/4] ARM: dts: bcm2835: Move rng definition to common location Stephen Brennan
2019-11-20 16:20 ` Stefan Wahren
2019-11-20 3:16 ` [PATCH v3 4/4] ARM: dts: bcm2711: Enable HWRNG support Stephen Brennan
2019-11-20 16:21 ` Stefan Wahren
2019-11-20 19:45 ` Nicolas Saenz Julienne
2019-11-20 16:16 ` [PATCH v3 0/4] Raspberry Pi 4 HWRNG Support Stefan Wahren
2019-11-20 19:50 ` Nicolas Saenz Julienne [this message]
2019-11-21 10:14 ` Stefan Wahren
2019-11-21 4:09 ` Florian Fainelli
2019-11-21 5:30 ` Herbert Xu
2019-12-04 4:55 ` Florian Fainelli
2019-12-04 4:59 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aaa37d2cbe91c177b7be2d7f8aa3846efe3dc34.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mpm@selenic.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stephen@brennan.io \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).