* [PATCH] crypto: arm/ghash-ce - define fpu before fpu registers are referenced
@ 2020-03-01 23:37 Stefan Agner
2020-03-03 22:20 ` Nick Desaulniers
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stefan Agner @ 2020-03-01 23:37 UTC (permalink / raw)
To: herbert, davem
Cc: linux, manojgupta, jiancai, linux-crypto, linux-arm-kernel,
linux-kernel, clang-built-linux, Stefan Agner
Building ARMv7 with Clang's integrated assembler leads to errors such
as:
arch/arm/crypto/ghash-ce-core.S:34:11: error: register name expected
t3l .req d16
^
Since no FPU has selected yet Clang considers d16 not a valid register.
Moving the FPU directive on-top allows Clang to parse the registers and
allows to successfully build this file with Clang's integrated assembler.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/crypto/ghash-ce-core.S | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/crypto/ghash-ce-core.S b/arch/arm/crypto/ghash-ce-core.S
index 534c9647726d..9f51e3fa4526 100644
--- a/arch/arm/crypto/ghash-ce-core.S
+++ b/arch/arm/crypto/ghash-ce-core.S
@@ -8,6 +8,9 @@
#include <linux/linkage.h>
#include <asm/assembler.h>
+ .arch armv8-a
+ .fpu crypto-neon-fp-armv8
+
SHASH .req q0
T1 .req q1
XL .req q2
@@ -88,8 +91,6 @@
T3_H .req d17
.text
- .arch armv8-a
- .fpu crypto-neon-fp-armv8
.macro __pmull_p64, rd, rn, rm, b1, b2, b3, b4
vmull.p64 \rd, \rn, \rm
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: arm/ghash-ce - define fpu before fpu registers are referenced
2020-03-01 23:37 [PATCH] crypto: arm/ghash-ce - define fpu before fpu registers are referenced Stefan Agner
@ 2020-03-03 22:20 ` Nick Desaulniers
2020-03-04 7:39 ` Ard Biesheuvel
2020-03-06 1:52 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Nick Desaulniers @ 2020-03-03 22:20 UTC (permalink / raw)
To: Stefan Agner
Cc: Herbert Xu, David S. Miller, Russell King, Manoj Gupta, Jian Cai,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE, Linux ARM, LKML,
clang-built-linux, Ard.Biesheuvel
On Sun, Mar 1, 2020 at 3:37 PM Stefan Agner <stefan@agner.ch> wrote:
>
> Building ARMv7 with Clang's integrated assembler leads to errors such
> as:
> arch/arm/crypto/ghash-ce-core.S:34:11: error: register name expected
> t3l .req d16
> ^
>
> Since no FPU has selected yet Clang considers d16 not a valid register.
> Moving the FPU directive on-top allows Clang to parse the registers and
> allows to successfully build this file with Clang's integrated assembler.
Certainly a side effect of having a single pass assembler...This does
fix what otherwise looks like a slew of errors for us, thanks for the
patch.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/crypto/ghash-ce-core.S | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/crypto/ghash-ce-core.S b/arch/arm/crypto/ghash-ce-core.S
> index 534c9647726d..9f51e3fa4526 100644
> --- a/arch/arm/crypto/ghash-ce-core.S
> +++ b/arch/arm/crypto/ghash-ce-core.S
> @@ -8,6 +8,9 @@
> #include <linux/linkage.h>
> #include <asm/assembler.h>
>
> + .arch armv8-a
> + .fpu crypto-neon-fp-armv8
> +
> SHASH .req q0
> T1 .req q1
> XL .req q2
> @@ -88,8 +91,6 @@
> T3_H .req d17
>
> .text
> - .arch armv8-a
> - .fpu crypto-neon-fp-armv8
>
> .macro __pmull_p64, rd, rn, rm, b1, b2, b3, b4
> vmull.p64 \rd, \rn, \rm
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/c41cc67321d0b366e356440e6dbc9eceb1babfe4.1583105749.git.stefan%40agner.ch.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: arm/ghash-ce - define fpu before fpu registers are referenced
2020-03-01 23:37 [PATCH] crypto: arm/ghash-ce - define fpu before fpu registers are referenced Stefan Agner
2020-03-03 22:20 ` Nick Desaulniers
@ 2020-03-04 7:39 ` Ard Biesheuvel
2020-03-06 1:52 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-03-04 7:39 UTC (permalink / raw)
To: Stefan Agner
Cc: Herbert Xu, David S. Miller, Russell King, Manoj Gupta, Jian Cai,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
linux-arm-kernel, Linux Kernel Mailing List, clang-built-linux
On Mon, 2 Mar 2020 at 00:37, Stefan Agner <stefan@agner.ch> wrote:
>
> Building ARMv7 with Clang's integrated assembler leads to errors such
> as:
> arch/arm/crypto/ghash-ce-core.S:34:11: error: register name expected
> t3l .req d16
> ^
>
> Since no FPU has selected yet Clang considers d16 not a valid register.
> Moving the FPU directive on-top allows Clang to parse the registers and
> allows to successfully build this file with Clang's integrated assembler.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm/crypto/ghash-ce-core.S | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/crypto/ghash-ce-core.S b/arch/arm/crypto/ghash-ce-core.S
> index 534c9647726d..9f51e3fa4526 100644
> --- a/arch/arm/crypto/ghash-ce-core.S
> +++ b/arch/arm/crypto/ghash-ce-core.S
> @@ -8,6 +8,9 @@
> #include <linux/linkage.h>
> #include <asm/assembler.h>
>
> + .arch armv8-a
> + .fpu crypto-neon-fp-armv8
> +
> SHASH .req q0
> T1 .req q1
> XL .req q2
> @@ -88,8 +91,6 @@
> T3_H .req d17
>
> .text
> - .arch armv8-a
> - .fpu crypto-neon-fp-armv8
>
> .macro __pmull_p64, rd, rn, rm, b1, b2, b3, b4
> vmull.p64 \rd, \rn, \rm
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: arm/ghash-ce - define fpu before fpu registers are referenced
2020-03-01 23:37 [PATCH] crypto: arm/ghash-ce - define fpu before fpu registers are referenced Stefan Agner
2020-03-03 22:20 ` Nick Desaulniers
2020-03-04 7:39 ` Ard Biesheuvel
@ 2020-03-06 1:52 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2020-03-06 1:52 UTC (permalink / raw)
To: Stefan Agner
Cc: davem, linux, manojgupta, jiancai, linux-crypto,
linux-arm-kernel, linux-kernel, clang-built-linux
On Mon, Mar 02, 2020 at 12:37:14AM +0100, Stefan Agner wrote:
> Building ARMv7 with Clang's integrated assembler leads to errors such
> as:
> arch/arm/crypto/ghash-ce-core.S:34:11: error: register name expected
> t3l .req d16
> ^
>
> Since no FPU has selected yet Clang considers d16 not a valid register.
> Moving the FPU directive on-top allows Clang to parse the registers and
> allows to successfully build this file with Clang's integrated assembler.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/crypto/ghash-ce-core.S | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-06 1:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-01 23:37 [PATCH] crypto: arm/ghash-ce - define fpu before fpu registers are referenced Stefan Agner
2020-03-03 22:20 ` Nick Desaulniers
2020-03-04 7:39 ` Ard Biesheuvel
2020-03-06 1:52 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).