* [PATCH -next] crypto: aspeed - Remove redundant dev_err call
@ 2022-09-23 10:01 Shang XiaoJing
2022-09-23 10:15 ` Neal Liu
2022-09-30 6:17 ` Herbert Xu
0 siblings, 2 replies; 5+ messages in thread
From: Shang XiaoJing @ 2022-09-23 10:01 UTC (permalink / raw)
To: neal_liu, herbert, davem, joel, andrew, linux-aspeed,
linux-crypto, linux-arm-kernel
Cc: shangxiaojing
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
---
drivers/crypto/aspeed/aspeed-hace.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/aspeed/aspeed-hace.c b/drivers/crypto/aspeed/aspeed-hace.c
index 3f880aafb6a2..e05c32c31842 100644
--- a/drivers/crypto/aspeed/aspeed-hace.c
+++ b/drivers/crypto/aspeed/aspeed-hace.c
@@ -123,10 +123,8 @@ static int aspeed_hace_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, hace_dev);
hace_dev->regs = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(hace_dev->regs)) {
- dev_err(&pdev->dev, "Failed to map resources\n");
+ if (IS_ERR(hace_dev->regs))
return PTR_ERR(hace_dev->regs);
- }
/* Get irq number and register it */
hace_dev->irq = platform_get_irq(pdev, 0);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH -next] crypto: aspeed - Remove redundant dev_err call
2022-09-23 10:01 [PATCH -next] crypto: aspeed - Remove redundant dev_err call Shang XiaoJing
@ 2022-09-23 10:15 ` Neal Liu
2022-09-23 12:26 ` shangxiaojing
2022-09-30 6:17 ` Herbert Xu
1 sibling, 1 reply; 5+ messages in thread
From: Neal Liu @ 2022-09-23 10:15 UTC (permalink / raw)
To: Shang XiaoJing, herbert, davem, joel, andrew, linux-aspeed,
linux-crypto, linux-arm-kernel
> devm_ioremap_resource() prints error message in itself. Remove the dev_err
> call to avoid redundant error message.
>
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
> ---
> drivers/crypto/aspeed/aspeed-hace.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/aspeed/aspeed-hace.c
> b/drivers/crypto/aspeed/aspeed-hace.c
> index 3f880aafb6a2..e05c32c31842 100644
> --- a/drivers/crypto/aspeed/aspeed-hace.c
> +++ b/drivers/crypto/aspeed/aspeed-hace.c
> @@ -123,10 +123,8 @@ static int aspeed_hace_probe(struct platform_device
> *pdev)
> platform_set_drvdata(pdev, hace_dev);
>
> hace_dev->regs = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(hace_dev->regs)) {
> - dev_err(&pdev->dev, "Failed to map resources\n");
> + if (IS_ERR(hace_dev->regs))
> return PTR_ERR(hace_dev->regs);
> - }
>
> /* Get irq number and register it */
> hace_dev->irq = platform_get_irq(pdev, 0);
> --
> 2.17.1
Similar patch just be proposed few days ago.
https://patchwork.kernel.org/project/linux-crypto/patch/20220920032118.6440-1-yuehaibing@huawei.com/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] crypto: aspeed - Remove redundant dev_err call
2022-09-23 10:15 ` Neal Liu
@ 2022-09-23 12:26 ` shangxiaojing
2022-09-30 5:56 ` Herbert Xu
0 siblings, 1 reply; 5+ messages in thread
From: shangxiaojing @ 2022-09-23 12:26 UTC (permalink / raw)
To: Neal Liu, herbert, davem, joel, andrew, linux-aspeed,
linux-crypto, linux-arm-kernel
On 2022/9/23 18:15, Neal Liu wrote:
>> devm_ioremap_resource() prints error message in itself. Remove the dev_err
>> call to avoid redundant error message.
>>
>> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
>> ---
>> drivers/crypto/aspeed/aspeed-hace.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/crypto/aspeed/aspeed-hace.c
>> b/drivers/crypto/aspeed/aspeed-hace.c
>> index 3f880aafb6a2..e05c32c31842 100644
>> --- a/drivers/crypto/aspeed/aspeed-hace.c
>> +++ b/drivers/crypto/aspeed/aspeed-hace.c
>> @@ -123,10 +123,8 @@ static int aspeed_hace_probe(struct platform_device
>> *pdev)
>> platform_set_drvdata(pdev, hace_dev);
>>
>> hace_dev->regs = devm_ioremap_resource(&pdev->dev, res);
>> - if (IS_ERR(hace_dev->regs)) {
>> - dev_err(&pdev->dev, "Failed to map resources\n");
>> + if (IS_ERR(hace_dev->regs))
>> return PTR_ERR(hace_dev->regs);
>> - }
>>
>> /* Get irq number and register it */
>> hace_dev->irq = platform_get_irq(pdev, 0);
>> --
>> 2.17.1
> Similar patch just be proposed few days ago.
> https://patchwork.kernel.org/project/linux-crypto/patch/20220920032118.6440-1-yuehaibing@huawei.com/
sorry, pls ignore mine.
Thanks,
Shang XiaoJing
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] crypto: aspeed - Remove redundant dev_err call
2022-09-23 12:26 ` shangxiaojing
@ 2022-09-30 5:56 ` Herbert Xu
0 siblings, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2022-09-30 5:56 UTC (permalink / raw)
To: shangxiaojing
Cc: Neal Liu, davem, joel, andrew, linux-aspeed, linux-crypto,
linux-arm-kernel
On Fri, Sep 23, 2022 at 08:26:21PM +0800, shangxiaojing wrote:
>
> On 2022/9/23 18:15, Neal Liu wrote:
> > > devm_ioremap_resource() prints error message in itself. Remove the dev_err
> > > call to avoid redundant error message.
> > >
> > > Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
> > > ---
> > > drivers/crypto/aspeed/aspeed-hace.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/crypto/aspeed/aspeed-hace.c
> > > b/drivers/crypto/aspeed/aspeed-hace.c
> > > index 3f880aafb6a2..e05c32c31842 100644
> > > --- a/drivers/crypto/aspeed/aspeed-hace.c
> > > +++ b/drivers/crypto/aspeed/aspeed-hace.c
> > > @@ -123,10 +123,8 @@ static int aspeed_hace_probe(struct platform_device
> > > *pdev)
> > > platform_set_drvdata(pdev, hace_dev);
> > >
> > > hace_dev->regs = devm_ioremap_resource(&pdev->dev, res);
> > > - if (IS_ERR(hace_dev->regs)) {
> > > - dev_err(&pdev->dev, "Failed to map resources\n");
> > > + if (IS_ERR(hace_dev->regs))
> > > return PTR_ERR(hace_dev->regs);
> > > - }
> > >
> > > /* Get irq number and register it */
> > > hace_dev->irq = platform_get_irq(pdev, 0);
> > > --
> > > 2.17.1
> > Similar patch just be proposed few days ago.
> > https://patchwork.kernel.org/project/linux-crypto/patch/20220920032118.6440-1-yuehaibing@huawei.com/
>
> sorry, pls ignore mine.
Actually I think these two patches are different and both can be
applied.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] crypto: aspeed - Remove redundant dev_err call
2022-09-23 10:01 [PATCH -next] crypto: aspeed - Remove redundant dev_err call Shang XiaoJing
2022-09-23 10:15 ` Neal Liu
@ 2022-09-30 6:17 ` Herbert Xu
1 sibling, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2022-09-30 6:17 UTC (permalink / raw)
To: Shang XiaoJing
Cc: neal_liu, davem, joel, andrew, linux-aspeed, linux-crypto,
linux-arm-kernel
On Fri, Sep 23, 2022 at 06:01:59PM +0800, Shang XiaoJing wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
>
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
> ---
> drivers/crypto/aspeed/aspeed-hace.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-30 6:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 10:01 [PATCH -next] crypto: aspeed - Remove redundant dev_err call Shang XiaoJing
2022-09-23 10:15 ` Neal Liu
2022-09-23 12:26 ` shangxiaojing
2022-09-30 5:56 ` Herbert Xu
2022-09-30 6:17 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).