From: Martin Willi <martin@strongswan.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-crypto@vger.kernel.org, ebiggers@kernel.org
Cc: Samuel Neves <sneves@dei.uc.pt>, Andy Polyakov <appro@openssl.org>
Subject: Re: [PATCH crypto-next v2 2/3] crypto: x86_64/poly1305 - add faster implementations
Date: Thu, 12 Dec 2019 16:34:34 +0100 [thread overview]
Message-ID: <ab103a1e20889d6f4d1a68991e29ae542c85c83c.camel@strongswan.org> (raw)
In-Reply-To: <20191212093008.217086-2-Jason@zx2c4.com>
> These x86_64 vectorized implementations are based on Andy Polyakov's
> implementation, and support AVX, AVX-2, and AVX512F. The AVX-512F
> implementation is disabled on Skylake, due to throttling, but it is
> quite fast on >= Cannonlake.
> arch/x86/crypto/poly1305-avx2-x86_64.S | 390 ---
> arch/x86/crypto/poly1305-sse2-x86_64.S | 590 ----
> arch/x86/crypto/poly1305-x86_64.pl | 4266 ++++++++++++++++++++++++
As the author of the removed code, I'm certainly biased, so I won't
hinder the adaption of the new code. Nonetheless some final remarks
from my side:
* It removes the existing SSE2 code path. Most likely not that much of
an issue due to the new AVX variant.
* I certainly would favor gradual improvement, and I think the code
would allow it. But as said, not my pick.
* Those 4000+ lines perl/asm are a lot and a hard review; I won't find
time and motivation to do it. ;-)
Thanks!
Martin
next prev parent reply other threads:[~2019-12-12 15:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 17:09 [PATCH crypto-next v1] crypto: poly1305 - add new 32 and 64-bit generic versions Jason A. Donenfeld
2019-12-11 19:06 ` Eric Biggers
2019-12-11 22:04 ` Jason A. Donenfeld
2019-12-12 9:30 ` [PATCH crypto-next v2 1/3] " Jason A. Donenfeld
2019-12-12 9:30 ` [PATCH crypto-next v2 2/3] crypto: x86_64/poly1305 - add faster implementations Jason A. Donenfeld
2019-12-12 10:26 ` Jason A. Donenfeld
2019-12-12 15:34 ` Martin Willi [this message]
2019-12-12 15:39 ` Jason A. Donenfeld
2019-12-15 17:04 ` Andy Polyakov
2019-12-12 9:30 ` [PATCH crypto-next v2 3/3] crypto: arm/arm64/mips/poly1305 - remove redundant non-reduction from emit Jason A. Donenfeld
2019-12-12 14:59 ` Ard Biesheuvel
2019-12-12 12:03 ` [PATCH crypto-next v2 1/3] crypto: poly1305 - add new 32 and 64-bit generic versions Martin Willi
2019-12-12 13:08 ` Jason A. Donenfeld
2019-12-12 13:46 ` Jason A. Donenfeld
2019-12-12 14:26 ` Ard Biesheuvel
2019-12-12 14:30 ` Jason A. Donenfeld
2019-12-12 15:30 ` Martin Willi
2019-12-12 15:35 ` Jason A. Donenfeld
2019-12-13 3:28 ` Eric Biggers
2019-12-14 8:56 ` Herbert Xu
2019-12-14 12:21 ` Jason A. Donenfeld
2019-12-14 13:05 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab103a1e20889d6f4d1a68991e29ae542c85c83c.camel@strongswan.org \
--to=martin@strongswan.org \
--cc=Jason@zx2c4.com \
--cc=appro@openssl.org \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=sneves@dei.uc.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).