From: Martin Willi <martin@strongswan.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH crypto-next v2 1/3] crypto: poly1305 - add new 32 and 64-bit generic versions
Date: Thu, 12 Dec 2019 13:03:27 +0100 [thread overview]
Message-ID: <d55e0390c7187b09f820e123b05df1e5e680df0b.camel@strongswan.org> (raw)
In-Reply-To: <20191212093008.217086-1-Jason@zx2c4.com>
Hi Jason,
> These two C implementations from Zinc -- a 32x32 one and a 64x64 one,
> depending on the platform -- come from Andrew Moon's public domain
> poly1305-donna portable code, modified for usage in the kernel. The
> precomputation in the 32-bit version and the use of 64x64 multiplies
> in the 64-bit version make these perform better than the code it
> replaces.
Can you provide some numbers to testify that? In my tests, the 32-bit
version gives me exact the same results.
The 64-bit version is roughly 10% faster. However, what are the
platforms where the 64-bit version matters? Won't any SIMD version
outperform the 64-bit version anyway?
Martin
next prev parent reply other threads:[~2019-12-12 12:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 17:09 [PATCH crypto-next v1] crypto: poly1305 - add new 32 and 64-bit generic versions Jason A. Donenfeld
2019-12-11 19:06 ` Eric Biggers
2019-12-11 22:04 ` Jason A. Donenfeld
2019-12-12 9:30 ` [PATCH crypto-next v2 1/3] " Jason A. Donenfeld
2019-12-12 9:30 ` [PATCH crypto-next v2 2/3] crypto: x86_64/poly1305 - add faster implementations Jason A. Donenfeld
2019-12-12 10:26 ` Jason A. Donenfeld
2019-12-12 15:34 ` Martin Willi
2019-12-12 15:39 ` Jason A. Donenfeld
2019-12-15 17:04 ` Andy Polyakov
2019-12-12 9:30 ` [PATCH crypto-next v2 3/3] crypto: arm/arm64/mips/poly1305 - remove redundant non-reduction from emit Jason A. Donenfeld
2019-12-12 14:59 ` Ard Biesheuvel
2019-12-12 12:03 ` Martin Willi [this message]
2019-12-12 13:08 ` [PATCH crypto-next v2 1/3] crypto: poly1305 - add new 32 and 64-bit generic versions Jason A. Donenfeld
2019-12-12 13:46 ` Jason A. Donenfeld
2019-12-12 14:26 ` Ard Biesheuvel
2019-12-12 14:30 ` Jason A. Donenfeld
2019-12-12 15:30 ` Martin Willi
2019-12-12 15:35 ` Jason A. Donenfeld
2019-12-13 3:28 ` Eric Biggers
2019-12-14 8:56 ` Herbert Xu
2019-12-14 12:21 ` Jason A. Donenfeld
2019-12-14 13:05 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d55e0390c7187b09f820e123b05df1e5e680df0b.camel@strongswan.org \
--to=martin@strongswan.org \
--cc=Jason@zx2c4.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).