Linux-csky Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH v5 03/14] irqchip/csky-mpintc: Fix potential resource leaks
       [not found] ` <1593998365-25910-4-git-send-email-yangtiezhu@loongson.cn>
@ 2020-07-06  6:14   ` Markus Elfring
  0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-07-06  6:14 UTC (permalink / raw)
  To: Tiezhu Yang, Thomas Gleixner, Jason Cooper, Marc Zyngier,
	Guo Ren, linux-csky
  Cc: linux-kernel, kernel-janitors, Denis Efremov, Gustavo A. R. Silva

> … Thus add jump targets for the completion of the desired
> exception handling. By the way, do some coding-style cleanups
> suggested by Markus.

I propose to split these changes.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258#n138

Would you like to support easier back-porting of a fix
besides another bit of possible source code beautification?


…
+++ b/drivers/irqchip/irq-csky-mpintc.c
@@ -241,14 +241,16 @@ csky_mpintc_init(struct device_node *node, struct device_node *parent)
…
 		INTCG_base = ioremap(mfcr("cr<31, 14>"),
-				     INTCL_SIZE*nr_cpu_ids + INTCG_SIZE);
…
+				     INTCL_SIZE * nr_cpu_ids + INTCG_SIZE);

Can any macro (or function) be helpful for such a size computation?

Regards,
Markus

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v5 00/14] irqchip: Fix potential resource leaks
       [not found]   ` <02e077df-7c4e-24a7-1640-5f17894bd252@loongson.cn>
@ 2020-10-12  2:31     ` Tiezhu Yang
  0 siblings, 0 replies; 2+ messages in thread
From: Tiezhu Yang @ 2020-10-12  2:31 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Thomas Gleixner, Jason Cooper, linux-kernel, Alban Bedel,
	Guo Ren, Mark Rutland, Sekhar Nori, Bartosz Golaszewski,
	David Lechner, Baruch Siach, Jisheng Zhang,
	Sebastian Hesselbarth, Jiaxun Yang, Alexandre Belloni,
	Arnd Bergmann, Grant Likely, u.kleine-koenig, Catalin Marinas,
	Tony Lindgren, Felipe Balbi, Paul Walmsley, Palmer Dabbelt,
	Albert Ou, Anup Patel, Kukjin Kim, Krzysztof Kozlowski,
	Heiko Stuebner, Rob Herring, Michal Simek,
	Zubair Lutfullah Kakakhel, linux-csky, linux-arm-kernel,
	linux-omap, linux-riscv, linux-samsung-soc

On 09/02/2020 11:59 AM, Tiezhu Yang wrote:
> On 07/06/2020 03:30 PM, Marc Zyngier wrote:
>> On 2020-07-06 02:19, Tiezhu Yang wrote:
>>> When I test the irqchip code of Loongson, I read the related code of 
>>> other
>>> chips in drivers/irqchip and I find some potential resource leaks in 
>>> the
>>> error path, I think it is better to fix them.
>>>
>>> v2:
>>>   - Split the first patch into a new patch series which
>>>     includes small patches and add "Fixes" tag
>>>   - Use "goto" label to handle error path in some patches
>>>
>>> v3:
>>>   - Add missed variable "ret" in the patch #5 and #13
>>>
>>> v4:
>>>   - Modify the commit message of each patch suggested by Markus Elfring
>>>   - Make "irq_domain_remove(root_domain)" under CONFIG_SMP in patch #3
>>>   - Add a return statement before goto label in patch #4
>>>
>>> v5:
>>>   - Modify the commit messages and do some code cleanups
>>
>> Please stop replying to Markus Elfring, and give people who actually
>> care a chance to review this code. Elfring will keep asking you to make
>> absolutely pointless changes until you are blue in the face
>
> Hi Marc,
>
> Any comments?
> Could you please apply this patch series?

Hi all,

Maybe I should cc the related persons through ./scripts/get_maintainer.pl
to get Acked-by or Reviewed-by.

The cover letter link of this patch series is:
[v5,00/14] irqchip: Fix potential resource leaks
https://lore.kernel.org/patchwork/cover/1268043/

Any comments will be much appreciated.

Thanks,
Tiezhu

>
> Thanks,
> Tiezhu
>
>>
>>
>> Thanks,
>>
>>         M.
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1593998365-25910-1-git-send-email-yangtiezhu@loongson.cn>
     [not found] ` <1593998365-25910-4-git-send-email-yangtiezhu@loongson.cn>
2020-07-06  6:14   ` [PATCH v5 03/14] irqchip/csky-mpintc: Fix potential resource leaks Markus Elfring
     [not found] ` <ab1cd9280c7892a0230945ef5ff0880c@kernel.org>
     [not found]   ` <02e077df-7c4e-24a7-1640-5f17894bd252@loongson.cn>
2020-10-12  2:31     ` [PATCH v5 00/14] irqchip: " Tiezhu Yang

Linux-csky Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-csky/0 linux-csky/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-csky linux-csky/ https://lore.kernel.org/linux-csky \
		linux-csky@vger.kernel.org
	public-inbox-index linux-csky

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-csky


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git