From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Guo Ren <guoren@kernel.org>, Baruch Siach <baruch@tkos.co.il>,
Huacai Chen <chenhc@lemote.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Tony Lindgren <tony@atomide.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Kukjin Kim <kgene@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, linux-csky@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-omap@vger.kernel.org, linux-riscv@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 1/7] irqchip: Fix potential resource leaks
Date: Wed, 24 Jun 2020 11:15:20 +0200 [thread overview]
Message-ID: <CAJKOXPc9QuDp+FEogVamf7x+4JEUw78MSKqSPFpRcyTYZ7HSMA@mail.gmail.com> (raw)
In-Reply-To: <1592902276-3969-2-git-send-email-yangtiezhu@loongson.cn>
On Tue, 23 Jun 2020 at 10:51, Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> There exists some potential resource leaks in the error path, fix them.
This should be split per driver and per bug (although mostly in driver
it's just one bug). Otherwise it is difficult to review, backport and
revert.
Best regards,
Krzysztof
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> drivers/irqchip/irq-ath79-misc.c | 3 +++
> drivers/irqchip/irq-csky-apb-intc.c | 3 +++
> drivers/irqchip/irq-csky-mpintc.c | 26 ++++++++++++++++++++------
> drivers/irqchip/irq-davinci-aintc.c | 17 +++++++++++++----
> drivers/irqchip/irq-davinci-cp-intc.c | 17 ++++++++++++++---
> drivers/irqchip/irq-digicolor.c | 4 ++++
> drivers/irqchip/irq-dw-apb-ictl.c | 11 ++++++++---
> drivers/irqchip/irq-loongson-htvec.c | 5 ++++-
> drivers/irqchip/irq-ls1x.c | 4 +++-
> drivers/irqchip/irq-mscc-ocelot.c | 6 ++++--
> drivers/irqchip/irq-nvic.c | 2 ++
> drivers/irqchip/irq-omap-intc.c | 4 +++-
> drivers/irqchip/irq-riscv-intc.c | 1 +
> drivers/irqchip/irq-s3c24xx.c | 20 +++++++++++++++-----
> drivers/irqchip/irq-xilinx-intc.c | 1 +
> 15 files changed, 98 insertions(+), 26 deletions(-)
next prev parent reply other threads:[~2020-06-24 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 8:51 [PATCH 0/7] Fix potential resource leaks and do some code cleanups about irqchip Tiezhu Yang
2020-06-23 8:51 ` [PATCH 1/7] irqchip: Fix potential resource leaks Tiezhu Yang
2020-06-24 9:15 ` Krzysztof Kozlowski [this message]
2020-06-24 9:24 ` Tiezhu Yang
2020-06-23 8:51 ` [PATCH 2/7] irqchip/loongson-htpic: Remove redundant kfree operation Tiezhu Yang
2020-06-23 8:51 ` [PATCH 3/7] irqchip/loongson-htvec: Check return value of irq_domain_translate_onecell() Tiezhu Yang
2020-06-23 8:51 ` [PATCH 4/7] irqchip/loongson-pch-pic: Check return value of irq_domain_translate_twocell() Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPc9QuDp+FEogVamf7x+4JEUw78MSKqSPFpRcyTYZ7HSMA@mail.gmail.com \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=baruch@tkos.co.il \
--cc=chenhc@lemote.com \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=jason@lakedaemon.net \
--cc=jiaxun.yang@flygoat.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=maz@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).