devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support
@ 2020-11-29 17:52 Sekhar Nori
  2020-11-29 17:52 ` [PATCH v3 1/2] arm64: dts: ti: k3-j721e-main: Add output tap delay values Sekhar Nori
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Sekhar Nori @ 2020-11-29 17:52 UTC (permalink / raw)
  To: Nishanth Menon, Tero Kristo
  Cc: Faiz Abbas, Rob Herring, Linux ARM Mailing List,
	Device Tree Mailing List

Hi,

This is repost of Faiz's patches adding higher speed modes
for J721E, originally posted here:'

https://lore.kernel.org/lkml/20201001190541.6364-1-faiz_abbas@ti.com/

Dependencies are resolved now, and patches rebased to latest linux-next.

v3:
- fix new node_name_chars_strict warning that got introduced

v2:
- rebased to latest linux-next
- fixed dtbs_check warning caused by improper states property in gpio
  regulator introduced in patch 2/2.

Faiz Abbas (2):
  arm64: dts: ti: k3-j721e-main: Add output tap delay values
  arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS
    modes

 .../dts/ti/k3-j721e-common-proc-board.dts     | 33 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 22 ++++++++++---
 2 files changed, 50 insertions(+), 5 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v3 1/2] arm64: dts: ti: k3-j721e-main: Add output tap delay values
  2020-11-29 17:52 [PATCH v3 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support Sekhar Nori
@ 2020-11-29 17:52 ` Sekhar Nori
  2020-11-29 17:52 ` [PATCH v3 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support for SD card UHS modes Sekhar Nori
  2020-11-30 13:18 ` [PATCH v3 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support Nishanth Menon
  2 siblings, 0 replies; 4+ messages in thread
From: Sekhar Nori @ 2020-11-29 17:52 UTC (permalink / raw)
  To: Nishanth Menon, Tero Kristo
  Cc: Faiz Abbas, Rob Herring, Linux ARM Mailing List,
	Device Tree Mailing List

From: Faiz Abbas <faiz_abbas@ti.com>

Add output tap delay values as given in the latest Data Manual[1],
SPRSP36E, revised December 2019.

[1] https://www.ti.com/lit/gpn/tda4vm

Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 19e602afdb05..d87748cb6896 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1079,7 +1079,11 @@
 		bus-width = <8>;
 		mmc-hs400-1_8v;
 		mmc-ddr-1_8v;
-		ti,otap-del-sel = <0x2>;
+		ti,otap-del-sel-legacy = <0xf>;
+		ti,otap-del-sel-mmc-hs = <0xf>;
+		ti,otap-del-sel-ddr52 = <0x5>;
+		ti,otap-del-sel-hs200 = <0x6>;
+		ti,otap-del-sel-hs400 = <0x0>;
 		ti,trm-icp = <0x8>;
 		ti,strobe-sel = <0x77>;
 		dma-coherent;
@@ -1094,7 +1098,12 @@
 		clocks = <&k3_clks 92 0>, <&k3_clks 92 5>;
 		assigned-clocks = <&k3_clks 92 0>;
 		assigned-clock-parents = <&k3_clks 92 1>;
-		ti,otap-del-sel = <0x2>;
+		ti,otap-del-sel-legacy = <0x0>;
+		ti,otap-del-sel-sd-hs = <0xf>;
+		ti,otap-del-sel-sdr12 = <0xf>;
+		ti,otap-del-sel-sdr25 = <0xf>;
+		ti,otap-del-sel-sdr50 = <0xc>;
+		ti,otap-del-sel-ddr50 = <0xc>;
 		ti,trm-icp = <0x8>;
 		ti,clkbuf-sel = <0x7>;
 		dma-coherent;
@@ -1110,7 +1119,12 @@
 		clocks = <&k3_clks 93 0>, <&k3_clks 93 5>;
 		assigned-clocks = <&k3_clks 93 0>;
 		assigned-clock-parents = <&k3_clks 93 1>;
-		ti,otap-del-sel = <0x2>;
+		ti,otap-del-sel-legacy = <0x0>;
+		ti,otap-del-sel-sd-hs = <0xf>;
+		ti,otap-del-sel-sdr12 = <0xf>;
+		ti,otap-del-sel-sdr25 = <0xf>;
+		ti,otap-del-sel-sdr50 = <0xc>;
+		ti,otap-del-sel-ddr50 = <0xc>;
 		ti,trm-icp = <0x8>;
 		ti,clkbuf-sel = <0x7>;
 		dma-coherent;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v3 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support for SD card UHS modes
  2020-11-29 17:52 [PATCH v3 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support Sekhar Nori
  2020-11-29 17:52 ` [PATCH v3 1/2] arm64: dts: ti: k3-j721e-main: Add output tap delay values Sekhar Nori
@ 2020-11-29 17:52 ` Sekhar Nori
  2020-11-30 13:18 ` [PATCH v3 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support Nishanth Menon
  2 siblings, 0 replies; 4+ messages in thread
From: Sekhar Nori @ 2020-11-29 17:52 UTC (permalink / raw)
  To: Nishanth Menon, Tero Kristo
  Cc: Faiz Abbas, Rob Herring, Linux ARM Mailing List,
	Device Tree Mailing List

From: Faiz Abbas <faiz_abbas@ti.com>

Add support for UHS modes for the SD card connected at sdhci1. This
involves adding regulators for voltage switching and power cycling the
SD card and removing the no-1-8-v property.

Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 .../dts/ti/k3-j721e-common-proc-board.dts     | 33 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     |  2 --
 2 files changed, 33 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 5754892f8501..60764366e22b 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -67,6 +67,31 @@
 		regulator-boot-on;
 	};
 
+	vdd_mmc1: fixedregulator-sd {
+		compatible = "regulator-fixed";
+		regulator-name = "vdd_mmc1";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		enable-active-high;
+		vin-supply = <&vsys_3v3>;
+		gpio = <&exp2 2 GPIO_ACTIVE_HIGH>;
+	};
+
+	vdd_sd_dv_alt: gpio-regulator-TLV71033 {
+		compatible = "regulator-gpio";
+		pinctrl-names = "default";
+		pinctrl-0 = <&vdd_sd_dv_alt_pins_default>;
+		regulator-name = "tlv71033";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		vin-supply = <&vsys_5v0>;
+		gpios = <&main_gpio0 117 GPIO_ACTIVE_HIGH>;
+		states = <1800000 0x0>,
+			 <3300000 0x1>;
+	};
+
 	sound0: sound@0 {
 		compatible = "ti,j721e-cpb-audio";
 		model = "j721e-cpb";
@@ -106,6 +131,12 @@
 		>;
 	};
 
+	vdd_sd_dv_alt_pins_default: vdd-sd-dv-alt-pins-default {
+		pinctrl-single,pins = <
+			J721E_IOPAD(0x1d8, PIN_INPUT, 7) /* (W4) SPI1_CS1.GPIO0_117 */
+		>;
+	};
+
 	main_usbss0_pins_default: main-usbss0-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x290, PIN_OUTPUT, 0) /* (U6) USB0_DRVVBUS */
@@ -295,6 +326,8 @@
 
 &main_sdhci1 {
 	/* SD/MMC */
+	vmmc-supply = <&vdd_mmc1>;
+	vqmmc-supply = <&vdd_sd_dv_alt>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&main_mmc1_pins_default>;
 	ti,driver-strength-ohm = <50>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index d87748cb6896..2056a41f9378 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1107,7 +1107,6 @@
 		ti,trm-icp = <0x8>;
 		ti,clkbuf-sel = <0x7>;
 		dma-coherent;
-		no-1-8-v;
 	};
 
 	main_sdhci2: sdhci@4f98000 {
@@ -1128,7 +1127,6 @@
 		ti,trm-icp = <0x8>;
 		ti,clkbuf-sel = <0x7>;
 		dma-coherent;
-		no-1-8-v;
 	};
 
 	usbss0: cdns-usb@4104000 {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support
  2020-11-29 17:52 [PATCH v3 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support Sekhar Nori
  2020-11-29 17:52 ` [PATCH v3 1/2] arm64: dts: ti: k3-j721e-main: Add output tap delay values Sekhar Nori
  2020-11-29 17:52 ` [PATCH v3 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support for SD card UHS modes Sekhar Nori
@ 2020-11-30 13:18 ` Nishanth Menon
  2 siblings, 0 replies; 4+ messages in thread
From: Nishanth Menon @ 2020-11-30 13:18 UTC (permalink / raw)
  To: Tero Kristo, Sekhar Nori
  Cc: Nishanth Menon, Rob Herring, Linux ARM Mailing List,
	Device Tree Mailing List, Faiz Abbas

On Sun, 29 Nov 2020 23:22:21 +0530, Sekhar Nori wrote:
> This is repost of Faiz's patches adding higher speed modes
> for J721E, originally posted here:'
> 
> https://lore.kernel.org/lkml/20201001190541.6364-1-faiz_abbas@ti.com/
> 
> Dependencies are resolved now, and patches rebased to latest linux-next.
> 
> [...]

Hi Sekhar Nori,

I have applied the following to branch ti-k3-next on [1].
Thank you!

[1/2] arm64: dts: ti: k3-j721e-main: Add output tap delay values
      commit: 09ff4e90e041485f7562d9baec340a9824af4f45
[2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support for SD card UHS modes
      commit: cd48ce86a4d0c1ffec86aa46a26da993c9af5f53


All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-30 13:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-29 17:52 [PATCH v3 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support Sekhar Nori
2020-11-29 17:52 ` [PATCH v3 1/2] arm64: dts: ti: k3-j721e-main: Add output tap delay values Sekhar Nori
2020-11-29 17:52 ` [PATCH v3 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support for SD card UHS modes Sekhar Nori
2020-11-30 13:18 ` [PATCH v3 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).