* [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings
[not found] <1630906083-32194-1-git-send-email-mkshah@codeaurora.org>
@ 2021-09-06 5:27 ` Maulik Shah
2021-09-07 19:58 ` Stephen Boyd
2021-09-24 23:23 ` Bjorn Andersson
2021-09-06 5:28 ` [PATCH v9 3/5] arm64: dts: qcom: sc7180: Enable SoC sleep stats Maulik Shah
2021-09-06 5:28 ` [PATCH v9 5/5] arm64: dts: qcom: sc7280: " Maulik Shah
2 siblings, 2 replies; 6+ messages in thread
From: Maulik Shah @ 2021-09-06 5:27 UTC (permalink / raw)
To: swboyd, mka, evgreen, bjorn.andersson
Cc: linux-arm-msm, linux-kernel, agross, dianders, linux, rnayak,
lsrao, Mahesh Sivasubramanian, devicetree, Lina Iyer,
Maulik Shah
From: Mahesh Sivasubramanian <msivasub@codeaurora.org>
Add device binding documentation for Qualcomm Technologies, Inc. (QTI)
SoC sleep stats driver. The driver is used for displaying SoC sleep
statistic maintained by Always On Processor or Resource Power Manager.
Cc: devicetree@vger.kernel.org
Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
Signed-off-by: Lina Iyer <ilina@codeaurora.org>
Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
.../bindings/soc/qcom/soc-sleep-stats.yaml | 48 ++++++++++++++++++++++
1 file changed, 48 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
new file mode 100644
index 0000000..4161156
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
+
+maintainers:
+ - Maulik Shah <mkshah@codeaurora.org>
+ - Lina Iyer <ilina@codeaurora.org>
+
+description:
+ Always On Processor/Resource Power Manager maintains statistics of the SoC
+ sleep modes involving powering down of the rails and oscillator clock.
+
+ Statistics includes SoC sleep mode type, number of times low power mode were
+ entered, time of last entry, time of last exit and accumulated sleep duration.
+
+properties:
+ compatible:
+ enum:
+ - qcom,rpmh-sleep-stats
+ - qcom,rpm-sleep-stats
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ # Example of rpmh sleep stats
+ - |
+ aop_msgram@c3f0048 {
+ compatible = "qcom,rpmh-sleep-stats";
+ reg = <0x0c3f0048 0x400>;
+ };
+ # Example of rpm sleep stats
+ - |
+ rpm_msgram@4690000 {
+ compatible = "qcom,rpm-sleep-stats";
+ reg = <0x04690000 0x400>;
+ };
+...
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings
2021-09-06 5:27 ` [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings Maulik Shah
@ 2021-09-07 19:58 ` Stephen Boyd
2021-09-24 23:23 ` Bjorn Andersson
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2021-09-07 19:58 UTC (permalink / raw)
To: Maulik Shah, bjorn.andersson, evgreen, mka
Cc: linux-arm-msm, linux-kernel, agross, dianders, linux, rnayak,
lsrao, Mahesh Sivasubramanian, devicetree, Lina Iyer
Quoting Maulik Shah (2021-09-05 22:27:59)
> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
> new file mode 100644
> index 0000000..4161156
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
> +
> +maintainers:
> + - Maulik Shah <mkshah@codeaurora.org>
> + - Lina Iyer <ilina@codeaurora.org>
> +
> +description:
> + Always On Processor/Resource Power Manager maintains statistics of the SoC
> + sleep modes involving powering down of the rails and oscillator clock.
> +
> + Statistics includes SoC sleep mode type, number of times low power mode were
> + entered, time of last entry, time of last exit and accumulated sleep duration.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,rpmh-sleep-stats
> + - qcom,rpm-sleep-stats
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + # Example of rpmh sleep stats
> + - |
> + aop_msgram@c3f0048 {
Node names should be generic and not have any underscores in them. I
still think 'memory' is more appropriate here. I doubt anyone will
confuse it for DDR.
> + compatible = "qcom,rpmh-sleep-stats";
> + reg = <0x0c3f0048 0x400>;
> + };
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings
2021-09-06 5:27 ` [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings Maulik Shah
2021-09-07 19:58 ` Stephen Boyd
@ 2021-09-24 23:23 ` Bjorn Andersson
2021-10-05 8:53 ` Maulik Shah
1 sibling, 1 reply; 6+ messages in thread
From: Bjorn Andersson @ 2021-09-24 23:23 UTC (permalink / raw)
To: Maulik Shah
Cc: swboyd, mka, evgreen, linux-arm-msm, linux-kernel, agross,
dianders, linux, rnayak, lsrao, Mahesh Sivasubramanian,
devicetree, Lina Iyer
On Mon 06 Sep 00:27 CDT 2021, Maulik Shah wrote:
> From: Mahesh Sivasubramanian <msivasub@codeaurora.org>
>
> Add device binding documentation for Qualcomm Technologies, Inc. (QTI)
> SoC sleep stats driver. The driver is used for displaying SoC sleep
> statistic maintained by Always On Processor or Resource Power Manager.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> ---
> .../bindings/soc/qcom/soc-sleep-stats.yaml | 48 ++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
> new file mode 100644
> index 0000000..4161156
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
> +
> +maintainers:
> + - Maulik Shah <mkshah@codeaurora.org>
> + - Lina Iyer <ilina@codeaurora.org>
Lina's address is no longer valid.
> +
> +description:
> + Always On Processor/Resource Power Manager maintains statistics of the SoC
> + sleep modes involving powering down of the rails and oscillator clock.
> +
> + Statistics includes SoC sleep mode type, number of times low power mode were
> + entered, time of last entry, time of last exit and accumulated sleep duration.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,rpmh-sleep-stats
> + - qcom,rpm-sleep-stats
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + # Example of rpmh sleep stats
> + - |
> + aop_msgram@c3f0048 {
> + compatible = "qcom,rpmh-sleep-stats";
> + reg = <0x0c3f0048 0x400>;
As I tested this series I did find it quite odd that the start address
of this block is $48 bytes into a page and still the length is an even
$400.
Is there any single platform where qcom,rpmh-sleep-stats doesn't start
at an offset of $48 from the beginning of its msgram? Could we move this
number to the driver?
Regards,
Bjorn
> + };
> + # Example of rpm sleep stats
> + - |
> + rpm_msgram@4690000 {
> + compatible = "qcom,rpm-sleep-stats";
> + reg = <0x04690000 0x400>;
> + };
> +...
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings
2021-09-24 23:23 ` Bjorn Andersson
@ 2021-10-05 8:53 ` Maulik Shah
0 siblings, 0 replies; 6+ messages in thread
From: Maulik Shah @ 2021-10-05 8:53 UTC (permalink / raw)
To: Bjorn Andersson
Cc: swboyd, mka, evgreen, linux-arm-msm, linux-kernel, agross,
dianders, linux, rnayak, lsrao, Mahesh Sivasubramanian,
devicetree, Lina Iyer
Hi,
On 9/25/2021 4:53 AM, Bjorn Andersson wrote:
> On Mon 06 Sep 00:27 CDT 2021, Maulik Shah wrote:
>
>> From: Mahesh Sivasubramanian <msivasub@codeaurora.org>
>>
>> Add device binding documentation for Qualcomm Technologies, Inc. (QTI)
>> SoC sleep stats driver. The driver is used for displaying SoC sleep
>> statistic maintained by Always On Processor or Resource Power Manager.
>>
>> Cc: devicetree@vger.kernel.org
>> Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
>> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> ---
>> .../bindings/soc/qcom/soc-sleep-stats.yaml | 48 ++++++++++++++++++++++
>> 1 file changed, 48 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>> new file mode 100644
>> index 0000000..4161156
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>> @@ -0,0 +1,48 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
>> +
>> +maintainers:
>> + - Maulik Shah <mkshah@codeaurora.org>
>> + - Lina Iyer <ilina@codeaurora.org>
>
> Lina's address is no longer valid.
Removed in v10.
>
>> +
>> +description:
>> + Always On Processor/Resource Power Manager maintains statistics of the SoC
>> + sleep modes involving powering down of the rails and oscillator clock.
>> +
>> + Statistics includes SoC sleep mode type, number of times low power mode were
>> + entered, time of last entry, time of last exit and accumulated sleep duration.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,rpmh-sleep-stats
>> + - qcom,rpm-sleep-stats
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + # Example of rpmh sleep stats
>> + - |
>> + aop_msgram@c3f0048 {
>> + compatible = "qcom,rpmh-sleep-stats";
>> + reg = <0x0c3f0048 0x400>;
>
> As I tested this series I did find it quite odd that the start address
> of this block is $48 bytes into a page and still the length is an even
> $400.
>
> Is there any single platform where qcom,rpmh-sleep-stats doesn't start
> at an offset of $48 from the beginning of its msgram? Could we move this
> number to the driver?
>
> Regards,
> Bjorn
Sure, i have moved 0x48 into driver in v10.
Thanks,
Maulik
>
>> + };
>> + # Example of rpm sleep stats
>> + - |
>> + rpm_msgram@4690000 {
>> + compatible = "qcom,rpm-sleep-stats";
>> + reg = <0x04690000 0x400>;
>> + };
>> +...
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
>> of Code Aurora Forum, hosted by The Linux Foundation
>>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v9 3/5] arm64: dts: qcom: sc7180: Enable SoC sleep stats
[not found] <1630906083-32194-1-git-send-email-mkshah@codeaurora.org>
2021-09-06 5:27 ` [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings Maulik Shah
@ 2021-09-06 5:28 ` Maulik Shah
2021-09-06 5:28 ` [PATCH v9 5/5] arm64: dts: qcom: sc7280: " Maulik Shah
2 siblings, 0 replies; 6+ messages in thread
From: Maulik Shah @ 2021-09-06 5:28 UTC (permalink / raw)
To: swboyd, mka, evgreen, bjorn.andersson
Cc: linux-arm-msm, linux-kernel, agross, dianders, linux, rnayak,
lsrao, Maulik Shah, devicetree
Add device node for SoC sleep stats driver which provides various
low power mode stats.
Also update the reg size of aoss_qmp device to 0x400.
Cc: devicetree@vger.kernel.org
Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index c8921e2..c339605b 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3219,7 +3219,7 @@
aoss_qmp: power-controller@c300000 {
compatible = "qcom,sc7180-aoss-qmp";
- reg = <0 0x0c300000 0 0x100000>;
+ reg = <0 0x0c300000 0 0x400>;
interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
mboxes = <&apss_shared 0>;
@@ -3227,6 +3227,11 @@
#power-domain-cells = <1>;
};
+ aop_msgram@c3f0048 {
+ compatible = "qcom,rpmh-sleep-stats";
+ reg = <0 0x0c3f0048 0 0x400>;
+ };
+
spmi_bus: spmi@c440000 {
compatible = "qcom,spmi-pmic-arb";
reg = <0 0x0c440000 0 0x1100>,
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v9 5/5] arm64: dts: qcom: sc7280: Enable SoC sleep stats
[not found] <1630906083-32194-1-git-send-email-mkshah@codeaurora.org>
2021-09-06 5:27 ` [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings Maulik Shah
2021-09-06 5:28 ` [PATCH v9 3/5] arm64: dts: qcom: sc7180: Enable SoC sleep stats Maulik Shah
@ 2021-09-06 5:28 ` Maulik Shah
2 siblings, 0 replies; 6+ messages in thread
From: Maulik Shah @ 2021-09-06 5:28 UTC (permalink / raw)
To: swboyd, mka, evgreen, bjorn.andersson
Cc: linux-arm-msm, linux-kernel, agross, dianders, linux, rnayak,
lsrao, Maulik Shah, devicetree
Add device node for SoC sleep stats driver which provides various
low power mode stats.
Also update the reg size of aoss_qmp device to 0x400.
Cc: devicetree@vger.kernel.org
Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 53a21d0..aba7dd1 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -1473,7 +1473,7 @@
aoss_qmp: power-controller@c300000 {
compatible = "qcom,sc7280-aoss-qmp";
- reg = <0 0x0c300000 0 0x100000>;
+ reg = <0 0x0c300000 0 0x400>;
interrupts-extended = <&ipcc IPCC_CLIENT_AOP
IPCC_MPROC_SIGNAL_GLINK_QMP
IRQ_TYPE_EDGE_RISING>;
@@ -1484,6 +1484,11 @@
#power-domain-cells = <1>;
};
+ aop_msgram@c3f0048 {
+ compatible = "qcom,rpmh-sleep-stats";
+ reg = <0 0x0c3f0048 0 0x400>;
+ };
+
spmi_bus: spmi@c440000 {
compatible = "qcom,spmi-pmic-arb";
reg = <0 0x0c440000 0 0x1100>,
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 6+ messages in thread