From: Rob Herring <robh@kernel.org>
To: Cristian Pop <cristian.pop@analog.com>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, jic23@kernel.org,
linux-iio@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: addac: one-bit-adc-dac yaml documentation
Date: Tue, 11 Jan 2022 09:14:49 -0600 [thread overview]
Message-ID: <1641914089.194827.2944759.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220111115919.14645-1-cristian.pop@analog.com>
On Tue, 11 Jan 2022 13:59:18 +0200, Cristian Pop wrote:
> This adds device tree bindings for the one-bit-adc-dac.
>
> Signed-off-by: Cristian Pop <cristian.pop@analog.com>
> V1->V2
> - I am aware of the recommendation of rename/move this driver. Should we
> consider "drivers/io/gpio.c"?
> - Add .yaml file
> - Remove blank lines, remove unnecessary coma
> - Remove macros for channels
> - Check if channel is input for write_raw
> - Use labels instead of extend_name
> - Fix channel indexing
> - Use "sizeof(*channels)" in devm_kcalloc()
> - Remove assignment: " indio_dev->dev.parent = &pdev->dev;"
> - Remove "platform_set_drvdata"
> - Remove "adi" from compatible string since is not ADI specific driver.
> ---
> .../bindings/iio/addac/one-bit-adc-dac.yaml | 89 +++++++++++++++++++
> 1 file changed, 89 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.example.dts:19.27-47.11: Warning (unit_address_vs_reg): /example-0/one-bit-adc-dac@0: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.example.dt.yaml:0:0: /example-0/one-bit-adc-dac@0: failed to match any schema with compatible: ['one-bit-adc-dac']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1578401
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-01-11 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 11:59 [PATCH v2 1/2] dt-bindings: iio: addac: one-bit-adc-dac yaml documentation Cristian Pop
2022-01-11 11:59 ` [PATCH v2 2/2] one-bit-adc-dac: Add initial version of one bit ADC-DAC Cristian Pop
2022-01-12 15:23 ` Andy Shevchenko
2022-01-16 11:52 ` Jonathan Cameron
2022-01-18 17:06 ` Andy Shevchenko
2022-01-21 14:56 ` Jonathan Cameron
2022-01-19 9:38 ` Sa, Nuno
2022-01-21 10:24 ` Pop, Cristian
2022-01-21 14:54 ` Jonathan Cameron
2022-01-11 15:14 ` Rob Herring [this message]
2022-01-11 22:02 ` [PATCH v2 1/2] dt-bindings: iio: addac: one-bit-adc-dac yaml documentation Rob Herring
2022-01-16 11:30 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1641914089.194827.2944759.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=cristian.pop@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).