From: Cristian Pop <cristian.pop@analog.com>
To: <linux-iio@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <jic23@kernel.org>, <devicetree@vger.kernel.org>,
<robh+dt@kernel.org>, Cristian Pop <cristian.pop@analog.com>
Subject: [PATCH v2 1/2] dt-bindings: iio: addac: one-bit-adc-dac yaml documentation
Date: Tue, 11 Jan 2022 13:59:18 +0200 [thread overview]
Message-ID: <20220111115919.14645-1-cristian.pop@analog.com> (raw)
This adds device tree bindings for the one-bit-adc-dac.
Signed-off-by: Cristian Pop <cristian.pop@analog.com>
V1->V2
- I am aware of the recommendation of rename/move this driver. Should we
consider "drivers/io/gpio.c"?
- Add .yaml file
- Remove blank lines, remove unnecessary coma
- Remove macros for channels
- Check if channel is input for write_raw
- Use labels instead of extend_name
- Fix channel indexing
- Use "sizeof(*channels)" in devm_kcalloc()
- Remove assignment: " indio_dev->dev.parent = &pdev->dev;"
- Remove "platform_set_drvdata"
- Remove "adi" from compatible string since is not ADI specific driver.
---
.../bindings/iio/addac/one-bit-adc-dac.yaml | 89 +++++++++++++++++++
1 file changed, 89 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.yaml
diff --git a/Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.yaml b/Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.yaml
new file mode 100644
index 000000000000..dbed0f3b1ca4
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.yaml
@@ -0,0 +1,89 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2020 Analog Devices Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/addac/one-bit-adc-dac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices one bit ADC DAC driver
+
+maintainers:
+ - Cristian Pop <cristian.pop@analog.com>
+
+description: |
+ One bit ADC DAC driver
+
+properties:
+ compatible:
+ enum:
+ - adi,one-bit-adc-dac
+
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 0
+
+ in-gpios:
+ description: Input GPIOs
+
+ out-gpios:
+ description: Output GPIOs
+
+required:
+ - compatible
+ - in-gpios
+ - out-gpios
+
+patternProperties:
+ "^channel@([0-9]|1[0-5])$":
+ type: object
+ description: |
+ Represents the external channels which are connected to the ADDAC.
+
+ properties:
+ reg:
+ maxItems: 1
+ description: |
+ The channel number.
+
+ label:
+ description: |
+ Unique name to identify which channel this is.
+
+ required:
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ one-bit-adc-dac@0 {
+ compatible = "one-bit-adc-dac";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ in-gpios = <&gpio 17 0>, <&gpio 27 0>;
+ out-gpios = <&gpio 23 0>, <&gpio 24 0>;
+
+ channel@0 {
+ reg = <0>;
+ label = "i_17";
+ };
+
+ channel@1 {
+ reg = <1>;
+ label = "i_27";
+ };
+
+ channel@2 {
+ reg = <2>;
+ label = "o_23";
+ };
+
+ channel@3 {
+ reg = <3>;
+ label = "o_24";
+ };
+ };
--
2.17.1
next reply other threads:[~2022-01-11 11:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 11:59 Cristian Pop [this message]
2022-01-11 11:59 ` [PATCH v2 2/2] one-bit-adc-dac: Add initial version of one bit ADC-DAC Cristian Pop
2022-01-12 15:23 ` Andy Shevchenko
2022-01-16 11:52 ` Jonathan Cameron
2022-01-18 17:06 ` Andy Shevchenko
2022-01-21 14:56 ` Jonathan Cameron
2022-01-19 9:38 ` Sa, Nuno
2022-01-21 10:24 ` Pop, Cristian
2022-01-21 14:54 ` Jonathan Cameron
2022-01-11 15:14 ` [PATCH v2 1/2] dt-bindings: iio: addac: one-bit-adc-dac yaml documentation Rob Herring
2022-01-11 22:02 ` Rob Herring
2022-01-16 11:30 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111115919.14645-1-cristian.pop@analog.com \
--to=cristian.pop@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).