Re: [PATCH v2 2/2] one-bit-adc-dac: Add initial version of one bit ADC-DAC

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Cristian Pop <cristian.pop@analog.com>,
	linux-iio@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org
Subject: Re: [PATCH v2 2/2] one-bit-adc-dac: Add initial version of one bit ADC-DAC
Date: Tue, 18 Jan 2022 19:06:20 +0200	[thread overview]
Message-ID: <CAHp75VeakSDtDfGO1tcZKgoJ0KTAHgYMKG1v=cYDSHoc-zLUbw@mail.gmail.com> (raw)
In-Reply-To: <20220116115228.1f7b4728@jic23-huawei>

On Mon, Jan 17, 2022 at 8:41 AM Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 11 Jan 2022 13:59:19 +0200
> Cristian Pop <cristian.pop@analog.com> wrote:

> > +     st->labels = devm_kzalloc(device, sizeof(*st->labels) * child_num, GFP_KERNEL);
> > +     if (!st->labels)
> > +             return -ENOMEM;
> > +
> > +     i = child_num;
> > +     fwnode_for_each_child_node(fwnode, child) {
> > +             if (fwnode_property_read_u32(child, "reg", &crt_ch))
> > +                     continue;
> > +
> > +             if (crt_ch >= num_channels)
> > +                     continue;
> > +
> > +             if (fwnode_property_read_string(child, "label", &label))
> > +                     continue;
> > +
> > +             chan = &channels[crt_ch];
> ? Not used.
>
> > +             st->labels[--i] = label;

> I've no idea how this works...  Should be looking for the chan->channel
> value as that's what your read uses to index.

It's an implicit memcpy().

> > +     }
> > +
> > +     return 0;
> > +}

-- 
With Best Regards,
Andy Shevchenko