devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: mark.rutland@arm.com, rpurdie@rpsys.net,
	jacek.anaszewski@gmail.com, pavel@ucw.cz,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 1/6] dt: bindings: lp8860: Update bindings for lp8860
Date: Fri, 15 Dec 2017 16:57:40 -0600	[thread overview]
Message-ID: <20171215225740.caj54uo2kyfurlof@rob-hp-laptop> (raw)
In-Reply-To: <20171212220143.31210-2-dmurphy@ti.com>

On Tue, Dec 12, 2017 at 04:01:38PM -0600, Dan Murphy wrote:
> Update the lp8860 bindings to fix various issues
> found.  Add address-cells and size-cells, rename

You are doing this in the next patch...

> enable-gpio to enable-gpios, update the node name
> to the device name and indent the node example.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> 
> v4 - No changes
> 
> v3 - Indicatd enable-gpios is active high, moved address and size cells to child
> node patch and updated parent DT node name - https://patchwork.kernel.org/patch/10093745/
> v2 - New patch
> 
>  Documentation/devicetree/bindings/leds/leds-lp8860.txt | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index aad38dd94d4b..b9d09acbaa73 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -6,22 +6,22 @@ current sinks that can be controlled by a PWM input
>  signal, a SPI/I2C master, or both.
>  
>  Required properties:
> -	- compatible:
> +	- compatible :
>  		"ti,lp8860"
> -	- reg -  I2C slave address
> -	- label - Used for naming LEDs
> +	- reg : I2C slave address
> +	- label : Used for naming LEDs
>  
>  Optional properties:
> -	- enable-gpio - gpio pin to enable/disable the device.
> -	- supply - "vled" - LED supply
> +	- enable-gpios : gpio pin to enable (active high)/disable the device.
> +	- vled-supply : LED supply
>  
>  Example:
>  
> -leds: leds@6 {
> +led-controller@2d {
>  	compatible = "ti,lp8860";
>  	reg = <0x2d>;
>  	label = "display_cluster";
> -	enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> +	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>  	vled-supply = <&vbatt>;
>  }
>  
> -- 
> 2.15.0.124.g7668cbc60
> 

  parent reply	other threads:[~2017-12-15 22:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 22:01 [PATCH v4 0/6] Updated LP8860 driver series Dan Murphy
2017-12-12 22:01 ` [PATCH v4 1/6] dt: bindings: lp8860: Update bindings for lp8860 Dan Murphy
2017-12-15 22:56   ` Rob Herring
2017-12-15 22:57   ` Rob Herring [this message]
2017-12-12 22:01 ` [PATCH v4 2/6] dt: bindings: lp8860: Update DT label binding Dan Murphy
     [not found]   ` <20171212220143.31210-3-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-15 22:59     ` Rob Herring
2017-12-18 13:08       ` Dan Murphy
2017-12-12 22:01 ` [PATCH v4 3/6] leds: lp8860: Update the dt parsing for LED labeling Dan Murphy
     [not found] ` <20171212220143.31210-1-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-12 22:01   ` [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860 Dan Murphy
     [not found]     ` <20171212220143.31210-5-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-15  9:09       ` Pavel Machek
2017-12-15 17:22         ` Dan Murphy
     [not found]           ` <76329432-f96e-93ab-ed9b-ade22c8735c9-l0cyMroinI0@public.gmane.org>
2017-12-15 21:00             ` Pavel Machek
2017-12-12 22:01 ` [PATCH v4 5/6] leds: lp8860: Add DT parsing to retrieve the trigger node Dan Murphy
2017-12-12 22:01 ` [PATCH v4 6/6] leds: lp8860: Various fixes to align with LED framework Dan Murphy
2017-12-13 19:55 ` [PATCH v4 0/6] Updated LP8860 driver series Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215225740.caj54uo2kyfurlof@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).