From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>,
robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net,
pavel@ucw.cz
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 0/6] Updated LP8860 driver series
Date: Wed, 13 Dec 2017 20:55:45 +0100 [thread overview]
Message-ID: <5aabfe2b-d643-6439-dd0f-f391b6ce521d@gmail.com> (raw)
In-Reply-To: <20171212220143.31210-1-dmurphy@ti.com>
Dan,
Patch set applied, thanks.
--
Best regards,
Jacek Anaszewski
On 12/12/2017 11:01 PM, Dan Murphy wrote:
> All
>
> v4 - Fix checkpatch warning for code indentation on the
> leds: lp8860: Update the dt parsing for LED labeling patch.
>
> v3 - Made changes to the patch set to address concerns on DT node naming conventions
> based on discussion in the RFC patch https://patchwork.kernel.org/patch/10089047/
> also made requested changes to the DT and driver based on feedback. Patchworks
> links in each patch.
>
> v2 - Added an initial patch to bring the DT binding up to standard prior to adding
> the changes for the label and triggers.
>
> v1 Cover letter repeat below
>
> After creating a new LED driver for the LM3692x device I went back to the
> LP8860 driver that I authored and found some updates that need to be applied.
>
> First the way the LP8860 retrieved the label from the DT was incorrect as the
> label should have been from a child node as opposed to the parent. This is now
> fixed with this series.
>
> Second, since that device can be used to as either a backlight driver or as a
> string agnostic driver a trigger to the backlight needed to be added.
>
> Finally there are changes to the driver that need to be made as either
> unnoticed bugs or updates to the driver to align with the current LED
> framework. For instance moving to the devm LED class registration, destroying
> the mutex upon driver removal and removing the in driver dependency on CONFIG_OF
> and moving it to the Kconfig.
>
> With these changes this should at least bring the driver into a better shape.
>
> There are additional changes coming for this driver but I wanted to get the
> driver up to snuff before adding a feature to it.
>
> Dan
>
> Dan Murphy (6):
> dt: bindings: lp8860: Update bindings for lp8860
> dt: bindings: lp8860: Update DT label binding
> leds: lp8860: Update the dt parsing for LED labeling
> dt: bindings: lp8860: Add trigger binding to the lp8860
> leds: lp8860: Add DT parsing to retrieve the trigger node
> leds: lp8860: Various fixes to align with LED framework
>
> .../devicetree/bindings/leds/leds-lp8860.txt | 32 ++++++++++++-----
> drivers/leds/Kconfig | 2 +-
> drivers/leds/leds-lp8860.c | 40 ++++++++++++----------
> 3 files changed, 46 insertions(+), 28 deletions(-)
>
prev parent reply other threads:[~2017-12-13 19:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 22:01 [PATCH v4 0/6] Updated LP8860 driver series Dan Murphy
2017-12-12 22:01 ` [PATCH v4 1/6] dt: bindings: lp8860: Update bindings for lp8860 Dan Murphy
2017-12-15 22:56 ` Rob Herring
2017-12-15 22:57 ` Rob Herring
2017-12-12 22:01 ` [PATCH v4 2/6] dt: bindings: lp8860: Update DT label binding Dan Murphy
[not found] ` <20171212220143.31210-3-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-15 22:59 ` Rob Herring
2017-12-18 13:08 ` Dan Murphy
2017-12-12 22:01 ` [PATCH v4 3/6] leds: lp8860: Update the dt parsing for LED labeling Dan Murphy
[not found] ` <20171212220143.31210-1-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-12 22:01 ` [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860 Dan Murphy
[not found] ` <20171212220143.31210-5-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-15 9:09 ` Pavel Machek
2017-12-15 17:22 ` Dan Murphy
[not found] ` <76329432-f96e-93ab-ed9b-ade22c8735c9-l0cyMroinI0@public.gmane.org>
2017-12-15 21:00 ` Pavel Machek
2017-12-12 22:01 ` [PATCH v4 5/6] leds: lp8860: Add DT parsing to retrieve the trigger node Dan Murphy
2017-12-12 22:01 ` [PATCH v4 6/6] leds: lp8860: Various fixes to align with LED framework Dan Murphy
2017-12-13 19:55 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aabfe2b-d643-6439-dd0f-f391b6ce521d@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).