From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net,
jacek.anaszewski@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860
Date: Fri, 15 Dec 2017 11:22:24 -0600 [thread overview]
Message-ID: <76329432-f96e-93ab-ed9b-ade22c8735c9@ti.com> (raw)
In-Reply-To: <20171215090903.GC8221@amd>
Pavel
On 12/15/2017 03:09 AM, Pavel Machek wrote:
> Hi!
>
>> @@ -35,6 +37,7 @@ led-controller@2d {
>> led@0 {
>> reg = <0>;
>> label = "white:display_cluster";
>> + linux,default-trigger = "backlight";
>> };
>> }
>
> What is "display_cluster"? Is it display backlight?
>
This device can be configured to drive all 4 LED strings in display mode
so that all 4 strings have the same brightness controlled either through PWM or
through the brightness register
or
As cluster string where the brightness of individual strings or clustered strings
can be controlled via independent brightness control registers. I am currently working
on adding this support to the driver.
Dan
> Could we use ":backlight" and perhaps start documentation file listing
> "common" LED descriptions so they are shared across machines?
>
> For the record, I'd prefer this to be
> "/sys/class/leds/display:white:backlight" in the end... so that we
> have nice naming for userspace, consistent between different machines.
>
> Pavel
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2017-12-15 17:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 22:01 [PATCH v4 0/6] Updated LP8860 driver series Dan Murphy
2017-12-12 22:01 ` [PATCH v4 1/6] dt: bindings: lp8860: Update bindings for lp8860 Dan Murphy
2017-12-15 22:56 ` Rob Herring
2017-12-15 22:57 ` Rob Herring
2017-12-12 22:01 ` [PATCH v4 2/6] dt: bindings: lp8860: Update DT label binding Dan Murphy
[not found] ` <20171212220143.31210-3-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-15 22:59 ` Rob Herring
2017-12-18 13:08 ` Dan Murphy
2017-12-12 22:01 ` [PATCH v4 3/6] leds: lp8860: Update the dt parsing for LED labeling Dan Murphy
[not found] ` <20171212220143.31210-1-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-12 22:01 ` [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860 Dan Murphy
[not found] ` <20171212220143.31210-5-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-15 9:09 ` Pavel Machek
2017-12-15 17:22 ` Dan Murphy [this message]
[not found] ` <76329432-f96e-93ab-ed9b-ade22c8735c9-l0cyMroinI0@public.gmane.org>
2017-12-15 21:00 ` Pavel Machek
2017-12-12 22:01 ` [PATCH v4 5/6] leds: lp8860: Add DT parsing to retrieve the trigger node Dan Murphy
2017-12-12 22:01 ` [PATCH v4 6/6] leds: lp8860: Various fixes to align with LED framework Dan Murphy
2017-12-13 19:55 ` [PATCH v4 0/6] Updated LP8860 driver series Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76329432-f96e-93ab-ed9b-ade22c8735c9@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).