devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] Add tested digital audio blocks to A64
@ 2018-01-24 10:39 codekipper-Re5JQEeQqe8AvxtiuMwx3w
       [not found] ` <20180124103943.2062-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 20+ messages in thread
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2018-01-24 10:39 UTC (permalink / raw)
  To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper

From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hi All,

this patch series adds the digital audio blocks to the A64 SoC. No block
changes are necessary.

BR,
CK

Marcus Cooper (5):
  arm64: allwinner: a64: Add the SPDIF block
  arm64: allwinner: a64: Add SPDIF TX pin to the A64
  arm64: allwinner: a64: Add SPDIF to the A64
  arm64: allwinner: a64: Add SPDIF to the Pine64
  arm64: allwinner: a64: Add DAI nodes

 .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts |  7 +++
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi      | 63 ++++++++++++++++++++++
 2 files changed, 70 insertions(+)

-- 
2.16.0

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [linux-sunxi][PATCH 1/5] arm64: allwinner: a64: Add the SPDIF block
       [not found] ` <20180124103943.2062-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-01-24 10:39   ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
       [not found]     ` <20180124103943.2062-2-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-01-24 10:39   ` [PATCH 2/5] arm64: allwinner: a64: Add SPDIF TX pin to the A64 codekipper-Re5JQEeQqe8AvxtiuMwx3w
                     ` (3 subsequent siblings)
  4 siblings, 1 reply; 20+ messages in thread
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2018-01-24 10:39 UTC (permalink / raw)
  To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper

From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Add the SPDIF transceiver controller block to the A64 dtsi.

Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index d783d164b9c3..c82979038b0b 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -382,6 +382,19 @@
 			};
 		};
 
+		spdif: spdif@1c21000 {
+			#sound-dai-cells = <0>;
+			compatible = "allwinner,sun8i-h3-spdif";
+			reg = <0x01c21000 0x400>;
+			interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&ccu CLK_BUS_SPDIF>, <&ccu CLK_SPDIF>;
+			resets = <&ccu RST_BUS_SPDIF>;
+			clock-names = "apb", "spdif";
+			dmas = <&dma 2>;
+			dma-names = "tx";
+			status = "disabled";
+		};
+
 		uart0: serial@1c28000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x01c28000 0x400>;
-- 
2.16.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH 2/5] arm64: allwinner: a64: Add SPDIF TX pin to the A64
       [not found] ` <20180124103943.2062-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-01-24 10:39   ` [linux-sunxi][PATCH 1/5] arm64: allwinner: a64: Add the SPDIF block codekipper-Re5JQEeQqe8AvxtiuMwx3w
@ 2018-01-24 10:39   ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
       [not found]     ` <20180124103943.2062-3-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-01-24 10:39   ` [PATCH 3/5] arm64: allwinner: a64: Add SPDIF " codekipper-Re5JQEeQqe8AvxtiuMwx3w
                     ` (2 subsequent siblings)
  4 siblings, 1 reply; 20+ messages in thread
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2018-01-24 10:39 UTC (permalink / raw)
  To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper

From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Add the SPDIF TX pin to the A64 dtsi.

Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index c82979038b0b..db1694ec3ee4 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -336,6 +336,11 @@
 				drive-strength = <40>;
 			};
 
+			spdif_tx_pins_a: spdif@0 {
+				pins = "PH8";
+				function = "spdif";
+			};
+
 			spi0_pins: spi0 {
 				pins = "PC0", "PC1", "PC2", "PC3";
 				function = "spi0";
-- 
2.16.0

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH 3/5] arm64: allwinner: a64: Add SPDIF to the A64
       [not found] ` <20180124103943.2062-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-01-24 10:39   ` [linux-sunxi][PATCH 1/5] arm64: allwinner: a64: Add the SPDIF block codekipper-Re5JQEeQqe8AvxtiuMwx3w
  2018-01-24 10:39   ` [PATCH 2/5] arm64: allwinner: a64: Add SPDIF TX pin to the A64 codekipper-Re5JQEeQqe8AvxtiuMwx3w
@ 2018-01-24 10:39   ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
       [not found]     ` <20180124103943.2062-4-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-01-24 10:39   ` [linux-sunxi][PATCH 4/5] arm64: allwinner: a64: Add SPDIF to the Pine64 codekipper-Re5JQEeQqe8AvxtiuMwx3w
  2018-01-24 10:39   ` [linux-sunxi][PATCH 5/5] arm64: allwinner: a64: Add DAI nodes codekipper-Re5JQEeQqe8AvxtiuMwx3w
  4 siblings, 1 reply; 20+ messages in thread
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2018-01-24 10:39 UTC (permalink / raw)
  To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper

From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Add the device tree sound bindings for the S/PDIF block.

Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index db1694ec3ee4..f060a58f374c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -112,6 +112,25 @@
 		method = "smc";
 	};
 
+
+	sound_spdif {
+		compatible = "simple-audio-card";
+		simple-audio-card,name = "On-board SPDIF";
+
+		simple-audio-card,cpu {
+			sound-dai = <&spdif>;
+		};
+
+		simple-audio-card,codec {
+			sound-dai = <&spdif_out>;
+		};
+	};
+
+	spdif_out: spdif-out {
+		#sound-dai-cells = <0>;
+		compatible = "linux,spdif-dit";
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13
-- 
2.16.0

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [linux-sunxi][PATCH 4/5] arm64: allwinner: a64: Add SPDIF to the Pine64
       [not found] ` <20180124103943.2062-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
                     ` (2 preceding siblings ...)
  2018-01-24 10:39   ` [PATCH 3/5] arm64: allwinner: a64: Add SPDIF " codekipper-Re5JQEeQqe8AvxtiuMwx3w
@ 2018-01-24 10:39   ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
       [not found]     ` <20180124103943.2062-5-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-01-24 10:39   ` [linux-sunxi][PATCH 5/5] arm64: allwinner: a64: Add DAI nodes codekipper-Re5JQEeQqe8AvxtiuMwx3w
  4 siblings, 1 reply; 20+ messages in thread
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2018-01-24 10:39 UTC (permalink / raw)
  To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper

From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

---
 arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
index 604cdaedac38..70e8ff9a1f38 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
@@ -230,6 +230,13 @@
 	regulator-name = "vcc-rtc";
 };
 
+/* On Euler connector */
+&spdif {
+	pinctrl-names = "default";
+	pinctrl-0 = <&spdif_tx_pins_a>;
+	status = "disabled";
+};
+
 /* On Exp and Euler connectors */
 &uart0 {
 	pinctrl-names = "default";
-- 
2.16.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [linux-sunxi][PATCH 5/5] arm64: allwinner: a64: Add DAI nodes
       [not found] ` <20180124103943.2062-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
                     ` (3 preceding siblings ...)
  2018-01-24 10:39   ` [linux-sunxi][PATCH 4/5] arm64: allwinner: a64: Add SPDIF to the Pine64 codekipper-Re5JQEeQqe8AvxtiuMwx3w
@ 2018-01-24 10:39   ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
       [not found]     ` <20180124103943.2062-6-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  4 siblings, 1 reply; 20+ messages in thread
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2018-01-24 10:39 UTC (permalink / raw)
  To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper

From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Add the DAI blocks to the device tree. I2S0 and I2S1 are for
connecting to an external codec.

Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index f060a58f374c..f3354f8c2026 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -419,6 +419,32 @@
 			status = "disabled";
 		};
 
+		i2s0: i2s@1c22000 {
+			#sound-dai-cells = <0>;
+			compatible = "allwinner,sun8i-h3-i2s";
+			reg = <0x01c22000 0x400>;
+			interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&ccu CLK_BUS_I2S0>, <&ccu CLK_I2S0>;
+			clock-names = "apb", "mod";
+			resets = <&ccu RST_BUS_I2S0>;
+			dma-names = "rx", "tx";
+			dmas = <&dma 3>, <&dma 3>;
+			status = "disabled";
+		};
+
+		i2s1: i2s@1c22400 {
+			#sound-dai-cells = <0>;
+			compatible = "allwinner,sun8i-h3-i2s";
+			reg = <0x01c22400 0x400>;
+			interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&ccu CLK_BUS_I2S1>, <&ccu CLK_I2S1>;
+			clock-names = "apb", "mod";
+			resets = <&ccu RST_BUS_I2S1>;
+			dma-names = "rx", "tx";
+			dmas = <&dma 4>, <&dma 4>;
+			status = "disabled";
+		};
+
 		uart0: serial@1c28000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x01c28000 0x400>;
-- 
2.16.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 1/5] arm64: allwinner: a64: Add the SPDIF block
       [not found]     ` <20180124103943.2062-2-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-01-24 10:59       ` Maxime Ripard
  0 siblings, 0 replies; 20+ messages in thread
From: Maxime Ripard @ 2018-01-24 10:59 UTC (permalink / raw)
  To: codekipper-Re5JQEeQqe8AvxtiuMwx3w
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

Hi,

On Wed, Jan 24, 2018 at 11:39:39AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Add the SPDIF transceiver controller block to the A64 dtsi.
> 
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index d783d164b9c3..c82979038b0b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -382,6 +382,19 @@
>  			};
>  		};
>  
> +		spdif: spdif@1c21000 {
> +			#sound-dai-cells = <0>;
> +			compatible = "allwinner,sun8i-h3-spdif";

Please add a SoC-specific compatible here, in addition the H3.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [linux-sunxi][PATCH 2/5] arm64: allwinner: a64: Add SPDIF TX pin to the A64
       [not found]     ` <20180124103943.2062-3-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-01-24 11:00       ` Maxime Ripard
       [not found]         ` <20180124110031.kksmh56krinaivh7-ZC1Zs529Oq4@public.gmane.org>
  0 siblings, 1 reply; 20+ messages in thread
From: Maxime Ripard @ 2018-01-24 11:00 UTC (permalink / raw)
  To: codekipper-Re5JQEeQqe8AvxtiuMwx3w
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On Wed, Jan 24, 2018 at 11:39:40AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Add the SPDIF TX pin to the A64 dtsi.
> 
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index c82979038b0b..db1694ec3ee4 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -336,6 +336,11 @@
>  				drive-strength = <40>;
>  			};
>  
> +			spdif_tx_pins_a: spdif@0 {

This will generate a dtc warning, you should use a syntax similar to
the other nodes there (ie. spdif if that's the only muxing option, or
spdif-0).

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 3/5] arm64: allwinner: a64: Add SPDIF to the A64
       [not found]     ` <20180124103943.2062-4-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-01-24 11:01       ` Maxime Ripard
       [not found]         ` <20180124110124.pgvk7bwesftgbjtj-ZC1Zs529Oq4@public.gmane.org>
  0 siblings, 1 reply; 20+ messages in thread
From: Maxime Ripard @ 2018-01-24 11:01 UTC (permalink / raw)
  To: codekipper-Re5JQEeQqe8AvxtiuMwx3w
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Wed, Jan 24, 2018 at 11:39:41AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Add the device tree sound bindings for the S/PDIF block.
> 
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index db1694ec3ee4..f060a58f374c 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -112,6 +112,25 @@
>  		method = "smc";
>  	};
>  
> +
> +	sound_spdif {

Nit: You should drop the extra blank line here.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/5] arm64: allwinner: a64: Add SPDIF TX pin to the A64
       [not found]         ` <20180124110031.kksmh56krinaivh7-ZC1Zs529Oq4@public.gmane.org>
@ 2018-01-24 11:02           ` Chen-Yu Tsai
       [not found]             ` <CAGb2v67oFc0LRAcdvh-2F3HRkOui34ANp_-frB9exdvFBAirqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 20+ messages in thread
From: Chen-Yu Tsai @ 2018-01-24 11:02 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: Code Kipper, linux-arm-kernel, devicetree, linux-sunxi

On Wed, Jan 24, 2018 at 7:00 PM, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> On Wed, Jan 24, 2018 at 11:39:40AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>> Add the SPDIF TX pin to the A64 dtsi.
>>
>> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> index c82979038b0b..db1694ec3ee4 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> @@ -336,6 +336,11 @@
>>                               drive-strength = <40>;
>>                       };
>>
>> +                     spdif_tx_pins_a: spdif@0 {
>
> This will generate a dtc warning, you should use a syntax similar to
> the other nodes there (ie. spdif if that's the only muxing option, or
> spdif-0).

Furthermore, if this is the only option, you should set it as the
default in the .dtsi, so boards don't have to, and possibly squash
this patch into the first one.

ChenYu

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [linux-sunxi][PATCH 5/5] arm64: allwinner: a64: Add DAI nodes
       [not found]     ` <20180124103943.2062-6-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-01-24 11:02       ` Maxime Ripard
       [not found]         ` <20180124110222.cdglyg5m7644xiem-ZC1Zs529Oq4@public.gmane.org>
  0 siblings, 1 reply; 20+ messages in thread
From: Maxime Ripard @ 2018-01-24 11:02 UTC (permalink / raw)
  To: codekipper-Re5JQEeQqe8AvxtiuMwx3w
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]

Hi,

On Wed, Jan 24, 2018 at 11:39:43AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Add the DAI blocks to the device tree. I2S0 and I2S1 are for
> connecting to an external codec.
> 
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index f060a58f374c..f3354f8c2026 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -419,6 +419,32 @@
>  			status = "disabled";
>  		};
>  
> +		i2s0: i2s@1c22000 {
> +			#sound-dai-cells = <0>;
> +			compatible = "allwinner,sun8i-h3-i2s";

Same remark than for the spdif, please add a soc-specific compatible.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [linux-sunxi][PATCH 5/5] arm64: allwinner: a64: Add DAI nodes
       [not found]         ` <20180124110222.cdglyg5m7644xiem-ZC1Zs529Oq4@public.gmane.org>
@ 2018-01-24 11:39           ` Code Kipper
       [not found]             ` <CAEKpxBk8NXJn4KxEGXx7UddqpUMC65kdEgx1phZDWyUd3ER_3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 20+ messages in thread
From: Code Kipper @ 2018-01-24 11:39 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: linux-arm-kernel, devicetree, linux-sunxi

On 24 January 2018 at 12:02, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> Hi,
>
> On Wed, Jan 24, 2018 at 11:39:43AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>> Add the DAI blocks to the device tree. I2S0 and I2S1 are for
>> connecting to an external codec.
>>
>> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 ++++++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> index f060a58f374c..f3354f8c2026 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> @@ -419,6 +419,32 @@
>>                       status = "disabled";
>>               };
>>
>> +             i2s0: i2s@1c22000 {
>> +                     #sound-dai-cells = <0>;
>> +                     compatible = "allwinner,sun8i-h3-i2s";
>
> Same remark than for the spdif, please add a soc-specific compatible.

Is that really necessary?..for example on the a20 the functionality of
the i2s is the same as the a10 so it is down as
"allwinner,sun4i-a10-i2s", likewise here it's the same as the changes
required for the H3. I was planning on using the compatible
"allwinner,sun50i-a64-i2s" for the audio codec as there are some
quirks that need to be addressed.

Thanks,
CK
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [linux-sunxi][PATCH 3/5] arm64: allwinner: a64: Add SPDIF to the A64
       [not found]         ` <20180124110124.pgvk7bwesftgbjtj-ZC1Zs529Oq4@public.gmane.org>
@ 2018-01-24 11:40           ` Code Kipper
  0 siblings, 0 replies; 20+ messages in thread
From: Code Kipper @ 2018-01-24 11:40 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: linux-arm-kernel, devicetree, linux-sunxi

On 24 January 2018 at 12:01, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> On Wed, Jan 24, 2018 at 11:39:41AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>> Add the device tree sound bindings for the S/PDIF block.
>>
>> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> index db1694ec3ee4..f060a58f374c 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> @@ -112,6 +112,25 @@
>>               method = "smc";
>>       };
>>
>> +
>> +     sound_spdif {
>
> Nit: You should drop the extra blank line here.
ACK
Thanks,
CK
>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/5] arm64: allwinner: a64: Add SPDIF TX pin to the A64
       [not found]             ` <CAGb2v67oFc0LRAcdvh-2F3HRkOui34ANp_-frB9exdvFBAirqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-01-24 11:40               ` Code Kipper
  0 siblings, 0 replies; 20+ messages in thread
From: Code Kipper @ 2018-01-24 11:40 UTC (permalink / raw)
  To: Chen-Yu Tsai; +Cc: Maxime Ripard, linux-arm-kernel, devicetree, linux-sunxi

On 24 January 2018 at 12:02, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> wrote:
> On Wed, Jan 24, 2018 at 7:00 PM, Maxime Ripard
> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
>> On Wed, Jan 24, 2018 at 11:39:40AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>>> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>
>>> Add the SPDIF TX pin to the A64 dtsi.
>>>
>>> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> ---
>>>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>>> index c82979038b0b..db1694ec3ee4 100644
>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>>> @@ -336,6 +336,11 @@
>>>                               drive-strength = <40>;
>>>                       };
>>>
>>> +                     spdif_tx_pins_a: spdif@0 {
>>
>> This will generate a dtc warning, you should use a syntax similar to
>> the other nodes there (ie. spdif if that's the only muxing option, or
>> spdif-0).
>
> Furthermore, if this is the only option, you should set it as the
> default in the .dtsi, so boards don't have to, and possibly squash
> this patch into the first one.
ACK
Thanks,
CK
>
> ChenYu

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [linux-sunxi][PATCH 4/5] arm64: allwinner: a64: Add SPDIF to the Pine64
       [not found]     ` <20180124103943.2062-5-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-01-24 12:10       ` Code Kipper
  0 siblings, 0 replies; 20+ messages in thread
From: Code Kipper @ 2018-01-24 12:10 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: linux-arm-kernel, devicetree, linux-sunxi, Marcus Cooper

On 24 January 2018 at 11:39,  <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
NACK.....just noticed the lack of commit message...mmmm
BR,
CK
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> index 604cdaedac38..70e8ff9a1f38 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> @@ -230,6 +230,13 @@
>         regulator-name = "vcc-rtc";
>  };
>
> +/* On Euler connector */
> +&spdif {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&spdif_tx_pins_a>;
> +       status = "disabled";
> +};
> +
>  /* On Exp and Euler connectors */
>  &uart0 {
>         pinctrl-names = "default";
> --
> 2.16.0
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 5/5] arm64: allwinner: a64: Add DAI nodes
       [not found]             ` <CAEKpxBk8NXJn4KxEGXx7UddqpUMC65kdEgx1phZDWyUd3ER_3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-01-25  8:29               ` Maxime Ripard
       [not found]                 ` <20180125082904.t4sqob626kyzw4ga-ZC1Zs529Oq4@public.gmane.org>
  0 siblings, 1 reply; 20+ messages in thread
From: Maxime Ripard @ 2018-01-25  8:29 UTC (permalink / raw)
  To: Code Kipper; +Cc: linux-arm-kernel, devicetree, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 1994 bytes --]

On Wed, Jan 24, 2018 at 12:39:31PM +0100, Code Kipper wrote:
> On 24 January 2018 at 12:02, Maxime Ripard
> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > Hi,
> >
> > On Wed, Jan 24, 2018 at 11:39:43AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>
> >> Add the DAI blocks to the device tree. I2S0 and I2S1 are for
> >> connecting to an external codec.
> >>
> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> ---
> >>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 ++++++++++++++++++++++++++
> >>  1 file changed, 26 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> index f060a58f374c..f3354f8c2026 100644
> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> @@ -419,6 +419,32 @@
> >>                       status = "disabled";
> >>               };
> >>
> >> +             i2s0: i2s@1c22000 {
> >> +                     #sound-dai-cells = <0>;
> >> +                     compatible = "allwinner,sun8i-h3-i2s";
> >
> > Same remark than for the spdif, please add a soc-specific compatible.
> 
> Is that really necessary?..

Yes.

> for example on the a20 the functionality of the i2s is the same as
> the a10 so it is down as "allwinner,sun4i-a10-i2s", likewise here
> it's the same as the changes required for the H3. I was planning on
> using the compatible "allwinner,sun50i-a64-i2s" for the audio codec
> as there are some quirks that need to be addressed.

And this is exactly why it is necessary. If we ever find a quirk in
the future, supporting that quirk will be smooth if we already have a
compatible for that SoC in the DT, and a pain if we don't.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [linux-sunxi][PATCH 5/5] arm64: allwinner: a64: Add DAI nodes
       [not found]                 ` <20180125082904.t4sqob626kyzw4ga-ZC1Zs529Oq4@public.gmane.org>
@ 2018-01-25  9:07                   ` Code Kipper
       [not found]                     ` <CAEKpxBmbz-dwF77PDs-mREHwDfXG3juXz7zUKcaMQKjz=1b+Fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  2018-01-25  9:46                   ` Code Kipper
  1 sibling, 1 reply; 20+ messages in thread
From: Code Kipper @ 2018-01-25  9:07 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: linux-arm-kernel, devicetree, linux-sunxi

On 25 January 2018 at 09:29, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> On Wed, Jan 24, 2018 at 12:39:31PM +0100, Code Kipper wrote:
>> On 24 January 2018 at 12:02, Maxime Ripard
>> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
>> > Hi,
>> >
>> > On Wed, Jan 24, 2018 at 11:39:43AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>> >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> >>
>> >> Add the DAI blocks to the device tree. I2S0 and I2S1 are for
>> >> connecting to an external codec.
>> >>
>> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> >> ---
>> >>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 ++++++++++++++++++++++++++
>> >>  1 file changed, 26 insertions(+)
>> >>
>> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> >> index f060a58f374c..f3354f8c2026 100644
>> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> >> @@ -419,6 +419,32 @@
>> >>                       status = "disabled";
>> >>               };
>> >>
>> >> +             i2s0: i2s@1c22000 {
>> >> +                     #sound-dai-cells = <0>;
>> >> +                     compatible = "allwinner,sun8i-h3-i2s";
>> >
>> > Same remark than for the spdif, please add a soc-specific compatible.
>>
>> Is that really necessary?..
>
> Yes.
>
>> for example on the a20 the functionality of the i2s is the same as
>> the a10 so it is down as "allwinner,sun4i-a10-i2s", likewise here
>> it's the same as the changes required for the H3. I was planning on
>> using the compatible "allwinner,sun50i-a64-i2s" for the audio codec
>> as there are some quirks that need to be addressed.
>
> And this is exactly why it is necessary. If we ever find a quirk in
> the future, supporting that quirk will be smooth if we already have a
> compatible for that SoC in the DT, and a pain if we don't.
ACK, but is there any reason why we're not doing this for i2c?
BR,
CK
>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 5/5] arm64: allwinner: a64: Add DAI nodes
       [not found]                 ` <20180125082904.t4sqob626kyzw4ga-ZC1Zs529Oq4@public.gmane.org>
  2018-01-25  9:07                   ` [linux-sunxi][PATCH " Code Kipper
@ 2018-01-25  9:46                   ` Code Kipper
       [not found]                     ` <CAEKpxBmbhtGxk7hZMt3h7M_ih9njrwbtR7ooP4PT2kRD6xf=rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  1 sibling, 1 reply; 20+ messages in thread
From: Code Kipper @ 2018-01-25  9:46 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: linux-arm-kernel, devicetree, linux-sunxi

On 25 January 2018 at 09:29, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> On Wed, Jan 24, 2018 at 12:39:31PM +0100, Code Kipper wrote:
>> On 24 January 2018 at 12:02, Maxime Ripard
>> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
>> > Hi,
>> >
>> > On Wed, Jan 24, 2018 at 11:39:43AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>> >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> >>
>> >> Add the DAI blocks to the device tree. I2S0 and I2S1 are for
>> >> connecting to an external codec.
>> >>
>> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> >> ---
>> >>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 ++++++++++++++++++++++++++
>> >>  1 file changed, 26 insertions(+)
>> >>
>> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> >> index f060a58f374c..f3354f8c2026 100644
>> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> >> @@ -419,6 +419,32 @@
>> >>                       status = "disabled";
>> >>               };
>> >>
>> >> +             i2s0: i2s@1c22000 {
>> >> +                     #sound-dai-cells = <0>;
>> >> +                     compatible = "allwinner,sun8i-h3-i2s";
>> >
>> > Same remark than for the spdif, please add a soc-specific compatible.
>>
>> Is that really necessary?..
>
> Yes.
>
>> for example on the a20 the functionality of the i2s is the same as
>> the a10 so it is down as "allwinner,sun4i-a10-i2s", likewise here
>> it's the same as the changes required for the H3. I was planning on
>> using the compatible "allwinner,sun50i-a64-i2s" for the audio codec
>> as there are some quirks that need to be addressed.
>
> And this is exactly why it is necessary. If we ever find a quirk in
> the future, supporting that quirk will be smooth if we already have a
> compatible for that SoC in the DT, and a pain if we don't.
Hi Maxime,
so just to comfirm. I'll make this change
compatible = "allwinner,sun50i-a64-i2s", "allwinner,sun8i-h3-i2s"; to the dtsi
and later will add to the i2s driver the compatible
"allwinner,sun50i-a64-i2s-audio-codec"(or something other than
allwinner,sun50i-a64-i2s) for the quirks required for the i2s block
used for the audio codec.
BR,
CK

>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 5/5] arm64: allwinner: a64: Add DAI nodes
       [not found]                     ` <CAEKpxBmbz-dwF77PDs-mREHwDfXG3juXz7zUKcaMQKjz=1b+Fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-01-25 15:13                       ` Maxime Ripard
  0 siblings, 0 replies; 20+ messages in thread
From: Maxime Ripard @ 2018-01-25 15:13 UTC (permalink / raw)
  To: Code Kipper; +Cc: linux-arm-kernel, devicetree, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 2445 bytes --]

On Thu, Jan 25, 2018 at 10:07:45AM +0100, Code Kipper wrote:
> On 25 January 2018 at 09:29, Maxime Ripard
> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > On Wed, Jan 24, 2018 at 12:39:31PM +0100, Code Kipper wrote:
> >> On 24 January 2018 at 12:02, Maxime Ripard
> >> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> >> > Hi,
> >> >
> >> > On Wed, Jan 24, 2018 at 11:39:43AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> >> >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> >>
> >> >> Add the DAI blocks to the device tree. I2S0 and I2S1 are for
> >> >> connecting to an external codec.
> >> >>
> >> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> >> ---
> >> >>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 ++++++++++++++++++++++++++
> >> >>  1 file changed, 26 insertions(+)
> >> >>
> >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> >> index f060a58f374c..f3354f8c2026 100644
> >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> >> @@ -419,6 +419,32 @@
> >> >>                       status = "disabled";
> >> >>               };
> >> >>
> >> >> +             i2s0: i2s@1c22000 {
> >> >> +                     #sound-dai-cells = <0>;
> >> >> +                     compatible = "allwinner,sun8i-h3-i2s";
> >> >
> >> > Same remark than for the spdif, please add a soc-specific compatible.
> >>
> >> Is that really necessary?..
> >
> > Yes.
> >
> >> for example on the a20 the functionality of the i2s is the same as
> >> the a10 so it is down as "allwinner,sun4i-a10-i2s", likewise here
> >> it's the same as the changes required for the H3. I was planning on
> >> using the compatible "allwinner,sun50i-a64-i2s" for the audio codec
> >> as there are some quirks that need to be addressed.
> >
> > And this is exactly why it is necessary. If we ever find a quirk in
> > the future, supporting that quirk will be smooth if we already have a
> > compatible for that SoC in the DT, and a pain if we don't.
>
> ACK, but is there any reason why we're not doing this for i2c?

We try to do that for all the IPs, but some fell through the cracks.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [linux-sunxi][PATCH 5/5] arm64: allwinner: a64: Add DAI nodes
       [not found]                     ` <CAEKpxBmbhtGxk7hZMt3h7M_ih9njrwbtR7ooP4PT2kRD6xf=rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-01-25 15:31                       ` Maxime Ripard
  0 siblings, 0 replies; 20+ messages in thread
From: Maxime Ripard @ 2018-01-25 15:31 UTC (permalink / raw)
  To: Code Kipper; +Cc: linux-arm-kernel, devicetree, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 2754 bytes --]

On Thu, Jan 25, 2018 at 10:46:15AM +0100, Code Kipper wrote:
> On 25 January 2018 at 09:29, Maxime Ripard
> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > On Wed, Jan 24, 2018 at 12:39:31PM +0100, Code Kipper wrote:
> >> On 24 January 2018 at 12:02, Maxime Ripard
> >> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> >> > Hi,
> >> >
> >> > On Wed, Jan 24, 2018 at 11:39:43AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> >> >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> >>
> >> >> Add the DAI blocks to the device tree. I2S0 and I2S1 are for
> >> >> connecting to an external codec.
> >> >>
> >> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> >> ---
> >> >>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 ++++++++++++++++++++++++++
> >> >>  1 file changed, 26 insertions(+)
> >> >>
> >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> >> index f060a58f374c..f3354f8c2026 100644
> >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> >> @@ -419,6 +419,32 @@
> >> >>                       status = "disabled";
> >> >>               };
> >> >>
> >> >> +             i2s0: i2s@1c22000 {
> >> >> +                     #sound-dai-cells = <0>;
> >> >> +                     compatible = "allwinner,sun8i-h3-i2s";
> >> >
> >> > Same remark than for the spdif, please add a soc-specific compatible.
> >>
> >> Is that really necessary?..
> >
> > Yes.
> >
> >> for example on the a20 the functionality of the i2s is the same as
> >> the a10 so it is down as "allwinner,sun4i-a10-i2s", likewise here
> >> it's the same as the changes required for the H3. I was planning on
> >> using the compatible "allwinner,sun50i-a64-i2s" for the audio codec
> >> as there are some quirks that need to be addressed.
> >
> > And this is exactly why it is necessary. If we ever find a quirk in
> > the future, supporting that quirk will be smooth if we already have a
> > compatible for that SoC in the DT, and a pain if we don't.
> Hi Maxime,
> so just to comfirm. I'll make this change
> compatible = "allwinner,sun50i-a64-i2s", "allwinner,sun8i-h3-i2s"; to the dtsi
> and later will add to the i2s driver the compatible
> "allwinner,sun50i-a64-i2s-audio-codec"(or something other than
> allwinner,sun50i-a64-i2s) for the quirks required for the i2s block
> used for the audio codec.

That looks reasonable yes.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2018-01-25 15:31 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-24 10:39 [PATCH 0/5] Add tested digital audio blocks to A64 codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found] ` <20180124103943.2062-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 10:39   ` [linux-sunxi][PATCH 1/5] arm64: allwinner: a64: Add the SPDIF block codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20180124103943.2062-2-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 10:59       ` [PATCH " Maxime Ripard
2018-01-24 10:39   ` [PATCH 2/5] arm64: allwinner: a64: Add SPDIF TX pin to the A64 codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20180124103943.2062-3-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 11:00       ` [linux-sunxi][PATCH " Maxime Ripard
     [not found]         ` <20180124110031.kksmh56krinaivh7-ZC1Zs529Oq4@public.gmane.org>
2018-01-24 11:02           ` [PATCH " Chen-Yu Tsai
     [not found]             ` <CAGb2v67oFc0LRAcdvh-2F3HRkOui34ANp_-frB9exdvFBAirqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-24 11:40               ` Code Kipper
2018-01-24 10:39   ` [PATCH 3/5] arm64: allwinner: a64: Add SPDIF " codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20180124103943.2062-4-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 11:01       ` Maxime Ripard
     [not found]         ` <20180124110124.pgvk7bwesftgbjtj-ZC1Zs529Oq4@public.gmane.org>
2018-01-24 11:40           ` [linux-sunxi][PATCH " Code Kipper
2018-01-24 10:39   ` [linux-sunxi][PATCH 4/5] arm64: allwinner: a64: Add SPDIF to the Pine64 codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20180124103943.2062-5-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 12:10       ` Code Kipper
2018-01-24 10:39   ` [linux-sunxi][PATCH 5/5] arm64: allwinner: a64: Add DAI nodes codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20180124103943.2062-6-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 11:02       ` Maxime Ripard
     [not found]         ` <20180124110222.cdglyg5m7644xiem-ZC1Zs529Oq4@public.gmane.org>
2018-01-24 11:39           ` Code Kipper
     [not found]             ` <CAEKpxBk8NXJn4KxEGXx7UddqpUMC65kdEgx1phZDWyUd3ER_3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-25  8:29               ` [PATCH " Maxime Ripard
     [not found]                 ` <20180125082904.t4sqob626kyzw4ga-ZC1Zs529Oq4@public.gmane.org>
2018-01-25  9:07                   ` [linux-sunxi][PATCH " Code Kipper
     [not found]                     ` <CAEKpxBmbz-dwF77PDs-mREHwDfXG3juXz7zUKcaMQKjz=1b+Fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-25 15:13                       ` [PATCH " Maxime Ripard
2018-01-25  9:46                   ` Code Kipper
     [not found]                     ` <CAEKpxBmbhtGxk7hZMt3h7M_ih9njrwbtR7ooP4PT2kRD6xf=rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-25 15:31                       ` [linux-sunxi][PATCH " Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).