* [PATCH v2 1/4] dt-bindings: leds: Document commonly used LED triggers
2019-10-30 9:01 [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
@ 2019-10-30 9:01 ` Manivannan Sadhasivam
2019-11-05 22:04 ` Rob Herring
2019-10-30 9:01 ` [PATCH v2 2/4] dt-bindings: arm: Add devicetree binding for Thor96 Board Manivannan Sadhasivam
` (3 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Manivannan Sadhasivam @ 2019-10-30 9:01 UTC (permalink / raw)
To: shawnguo, s.hauer, robh+dt
Cc: kernel, festevam, linux-imx, darshak.patel, prajose.john,
devicetree, linux-arm-kernel, linux-kernel,
Manivannan Sadhasivam, Jacek Anaszewski, Pavel Machek,
Dan Murphy, linux-leds
This commit documents the LED triggers used commonly in the SoCs. Not
all triggers are documented as some of them are very application specific.
Most of the triggers documented here are currently used in devicetrees
of many SoCs.
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
.../devicetree/bindings/leds/common.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
index 9fa6f9795d50..2a6806161590 100644
--- a/Documentation/devicetree/bindings/leds/common.txt
+++ b/Documentation/devicetree/bindings/leds/common.txt
@@ -55,6 +55,23 @@ Optional properties for child nodes:
"timer" - LED flashes at a fixed, configurable rate
"pattern" - LED alters the brightness for the specified duration with one
software timer (requires "led-pattern" property)
+ "mmc[N]" - LED indicates [N]th MMC storage activity
+ "flash" - LED indicates camera flash state
+ "torch" - LED indicates camera torch state
+ "audio-mute" - LED indicates audio mute state
+ "audio-micmute" - LED indicates mic mute state
+ "bluetooth-power" - LED indicates bluetooth power state
+ "usb-gadget" - LED indicates USB gadget activity
+ "usb-host" - LED indicates USB host activity
+ "mtd" - LED indicates MTD memory activity
+ "nand-disk" - LED indicates NAND memory activity (deprecated),
+ in new implementations use "mtd"
+ "disk-read" - LED indicates disk read activity
+ "disk-write" - LED indicates disk write activity
+ "none" - No trigger assigned to the LED. This is the default mode
+ if trigger is absent
+ "cpu" - LED indicates activity of all CPUs
+ "cpu[N]" - LED indicates activity of [N]th CPU
- led-pattern : Array of integers with default pattern for certain triggers.
Each trigger may parse this property differently:
--
2.17.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v2 1/4] dt-bindings: leds: Document commonly used LED triggers
2019-10-30 9:01 ` [PATCH v2 1/4] dt-bindings: leds: Document commonly used LED triggers Manivannan Sadhasivam
@ 2019-11-05 22:04 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2019-11-05 22:04 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, darshak.patel,
prajose.john, devicetree, linux-arm-kernel, linux-kernel,
Jacek Anaszewski, Pavel Machek, Dan Murphy, linux-leds
On Wed, Oct 30, 2019 at 02:31:21PM +0530, Manivannan Sadhasivam wrote:
> This commit documents the LED triggers used commonly in the SoCs. Not
> all triggers are documented as some of them are very application specific.
> Most of the triggers documented here are currently used in devicetrees
> of many SoCs.
I guess it's worth documenting these, but you plan to use 'function'
instead, right?
>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> .../devicetree/bindings/leds/common.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
>
> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> index 9fa6f9795d50..2a6806161590 100644
> --- a/Documentation/devicetree/bindings/leds/common.txt
> +++ b/Documentation/devicetree/bindings/leds/common.txt
> @@ -55,6 +55,23 @@ Optional properties for child nodes:
> "timer" - LED flashes at a fixed, configurable rate
> "pattern" - LED alters the brightness for the specified duration with one
> software timer (requires "led-pattern" property)
> + "mmc[N]" - LED indicates [N]th MMC storage activity
> + "flash" - LED indicates camera flash state
> + "torch" - LED indicates camera torch state
> + "audio-mute" - LED indicates audio mute state
> + "audio-micmute" - LED indicates mic mute state
> + "bluetooth-power" - LED indicates bluetooth power state
> + "usb-gadget" - LED indicates USB gadget activity
> + "usb-host" - LED indicates USB host activity
> + "mtd" - LED indicates MTD memory activity
> + "nand-disk" - LED indicates NAND memory activity (deprecated),
> + in new implementations use "mtd"
> + "disk-read" - LED indicates disk read activity
> + "disk-write" - LED indicates disk write activity
> + "none" - No trigger assigned to the LED. This is the default mode
> + if trigger is absent
> + "cpu" - LED indicates activity of all CPUs
> + "cpu[N]" - LED indicates activity of [N]th CPU
>
> - led-pattern : Array of integers with default pattern for certain triggers.
> Each trigger may parse this property differently:
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 2/4] dt-bindings: arm: Add devicetree binding for Thor96 Board
2019-10-30 9:01 [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 1/4] dt-bindings: leds: Document commonly used LED triggers Manivannan Sadhasivam
@ 2019-10-30 9:01 ` Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 3/4] arm64: dts: freescale: Add devicetree support for Thor96 board Manivannan Sadhasivam
` (2 subsequent siblings)
4 siblings, 0 replies; 15+ messages in thread
From: Manivannan Sadhasivam @ 2019-10-30 9:01 UTC (permalink / raw)
To: shawnguo, s.hauer, robh+dt
Cc: kernel, festevam, linux-imx, darshak.patel, prajose.john,
devicetree, linux-arm-kernel, linux-kernel,
Manivannan Sadhasivam
Add devicetree binding for Thor96 Board from Einfochips. This board is
one of the 96Boards Consumer Edition platform powered by NXP i.MX8MQ SoC.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 1b4b4e6573b5..8016174d5e49 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -239,6 +239,7 @@ properties:
items:
- enum:
- boundary,imx8mq-nitrogen8m # i.MX8MQ NITROGEN Board
+ - einfochips,imx8mq-thor96 # i.MX8MQ Thor96 Board
- fsl,imx8mq-evk # i.MX8MQ EVK Board
- purism,librem5-devkit # Purism Librem5 devkit
- solidrun,hummingboard-pulse # SolidRun Hummingboard Pulse
--
2.17.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH v2 3/4] arm64: dts: freescale: Add devicetree support for Thor96 board
2019-10-30 9:01 [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 1/4] dt-bindings: leds: Document commonly used LED triggers Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 2/4] dt-bindings: arm: Add devicetree binding for Thor96 Board Manivannan Sadhasivam
@ 2019-10-30 9:01 ` Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw Manivannan Sadhasivam
2020-01-09 3:33 ` [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
4 siblings, 0 replies; 15+ messages in thread
From: Manivannan Sadhasivam @ 2019-10-30 9:01 UTC (permalink / raw)
To: shawnguo, s.hauer, robh+dt
Cc: kernel, festevam, linux-imx, darshak.patel, prajose.john,
devicetree, linux-arm-kernel, linux-kernel,
Manivannan Sadhasivam
Add devicetree support for Thor96 board from Einfochips. This board is
one of the 96Boards Consumer Edition platform powered by the NXP
i.MX8MQ SoC.
Following are the features supported currently:
1. uSD
2. WiFi/BT
3. Ethernet
4. EEPROM (M24256)
5. NOR Flash (W25Q256JW)
6. 2xUSB3.0 ports and 1xUSB2.0 port at HS expansion
More information about this board can be found in Arrow website:
https://www.arrow.com/en/products/i.imx8-thor96/arrow-development-tools
Link to 96Boards CE Specification: https://linaro.co/ce-specification
Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
[Mani: cleaned up for upstream]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../boot/dts/freescale/imx8mq-thor96.dts | 581 ++++++++++++++++++
2 files changed, 582 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 93fce8f0c66d..dec1662019be 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -28,6 +28,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-hummingboard-pulse.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mq-zii-ultra-rmb3.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mq-zii-ultra-zest.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8qxp-ai_ml.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
new file mode 100644
index 000000000000..b4795a032fa2
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
@@ -0,0 +1,581 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2019 Einfochips
+ * Copyright 2019 Linaro Ltd.
+ */
+
+/dts-v1/;
+
+#include "imx8mq.dtsi"
+
+/ {
+ model = "Einfochips i.MX8MQ Thor96";
+ compatible = "einfochips,imx8mq-thor96", "fsl,imx8mq";
+
+ chosen {
+ stdout-path = &uart1;
+ };
+
+ memory@40000000 {
+ device_type = "memory";
+ reg = <0x00000000 0x40000000 0 0x80000000>;
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_leds>;
+
+ user-led1 {
+ label = "green:user1";
+ gpios = <&gpio4 21 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+
+ user-led2 {
+ label = "green:user2";
+ gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "none";
+ };
+
+ user-led3 {
+ label = "green:user3";
+ gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "mmc1";
+ default-state = "off";
+ };
+
+ user-led4 {
+ label = "green:user4";
+ gpios = <&gpio4 29 GPIO_ACTIVE_HIGH>;
+ panic-indicator;
+ linux,default-trigger = "none";
+ };
+
+ wlan-active-led {
+ label = "yellow:wlan";
+ gpios = <&gpio4 1 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "phy0tx";
+ default-state = "off";
+ };
+
+ bt-active-led {
+ label = "blue:bt";
+ gpios = <&gpio4 0 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "hci0-power";
+ default-state = "off";
+ };
+ };
+
+ reg_usdhc1_vmmc: reg-usdhc1-vmmc {
+ compatible = "regulator-fixed";
+ regulator-name = "VDD_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ reg_usdhc1_vqmmc: reg-usdhc1-vqmmc {
+ compatible = "regulator-fixed";
+ regulator-name = "VCC_1V8_EXT";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ reg_usdhc2_vmmc: reg-usdhc2-vmmc {
+ compatible = "regulator-fixed";
+ regulator-name = "VSD_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_reg_usdhc2>;
+ gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ reg_usdhc2_vqmmc: reg-usdhc2-vqmmc {
+ compatible = "regulator-fixed";
+ regulator-name = "NVCC_SD2";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ sdio_pwrseq: sdio-pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wifi_reg_on>;
+ gpio = <&gpio3 3 GPIO_ACTIVE_HIGH>;
+ };
+};
+
+/* LS-SPI0 */
+&ecspi2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi2>;
+ status = "okay";
+};
+
+&fec1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_fec1>;
+ phy-mode = "rgmii-id";
+ phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
+ phy-handle = <ðphy>;
+ fsl,magic-packet;
+ status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethphy: ethernet-phy@3 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <3>;
+ };
+ };
+};
+
+/* LS-I2C0 */
+&i2c1 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c1>;
+ status = "okay";
+
+ pmic@8 {
+ compatible = "fsl,pfuze100";
+ reg = <0x8>;
+
+ regulators {
+ sw1a_reg: sw1ab {
+ regulator-min-microvolt = <300000>;
+ regulator-max-microvolt = <1875000>;
+ };
+
+ sw1c_reg: sw1c {
+ regulator-min-microvolt = <300000>;
+ regulator-max-microvolt = <1875000>;
+ };
+
+ sw2_reg: sw2 {
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ sw3a_reg: sw3ab {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <1975000>;
+ regulator-always-on;
+ };
+
+ sw4_reg: sw4 {
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ swbst_reg: swbst {
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5150000>;
+ };
+
+ snvs_reg: vsnvs {
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-always-on;
+ };
+
+ vref_reg: vrefddr {
+ regulator-always-on;
+ };
+
+ vgen1_reg: vgen1 {
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1550000>;
+ };
+
+ vgen2_reg: vgen2 {
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1550000>;
+ regulator-always-on;
+ };
+
+ vgen3_reg: vgen3 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ vgen4_reg: vgen4 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ vgen5_reg: vgen5 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ vgen6_reg: vgen6 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ };
+ };
+ };
+};
+
+/* LS-I2C1 */
+&i2c2 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c2>;
+ status = "okay";
+
+ eeprom: eeprom@50 {
+ compatible = "atmel,24c256";
+ reg = <0x50>;
+ };
+};
+
+/* HS-I2C2 */
+&i2c3 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c3>;
+ status = "okay";
+};
+
+/* HS-I2C3 */
+&i2c4 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c4>;
+ status = "okay";
+};
+
+&pgc_gpu {
+ power-supply = <&sw1a_reg>;
+};
+
+&pgc_vpu {
+ power-supply = <&sw1c_reg>;
+};
+
+&qspi0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_qspi0>;
+ status = "okay";
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ spi-max-frequency = <100000000>;
+ reg = <0>;
+ };
+};
+
+/* Debug UART */
+&uart1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart1>;
+ assigned-clocks = <&clk IMX8MQ_CLK_UART1>;
+ assigned-clock-parents = <&clk IMX8MQ_CLK_25M>;
+ status = "okay";
+};
+
+/* LS-UART0 */
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart2>;
+ assigned-clocks = <&clk IMX8MQ_CLK_UART2>;
+ assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_80M>;
+ uart-has-rtscts;
+ status = "okay";
+
+ bluetooth {
+ compatible = "brcm,bcm43438-bt";
+ device-wakeup-gpios = <&gpio3 22 GPIO_ACTIVE_HIGH>;
+ host-wakeup-gpios = <&gpio3 14 GPIO_ACTIVE_HIGH>;
+ shutdown-gpios = <&gpio3 5 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_bt_gpios>;
+ };
+};
+
+/* LS-UART1 */
+&uart3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart3>;
+ assigned-clocks = <&clk IMX8MQ_CLK_UART3>;
+ assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_80M>;
+ status = "okay";
+};
+
+&usb3_phy1 {
+ status = "okay";
+};
+
+&usb_dwc3_1 {
+ dr_mode = "host";
+ status = "okay";
+};
+
+/* SDIO */
+&usdhc1 {
+ #address-cells = <0x1>;
+ #size-cells = <0x0>;
+ pinctrl-names = "default", "state_100mhz", "state_200mhz";
+ pinctrl-0 = <&pinctrl_usdhc1>;
+ pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+ pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+ vmmc-supply = <®_usdhc1_vmmc>;
+ vqmmc-supply = <®_usdhc1_vqmmc>;
+ mmc-pwrseq = <&sdio_pwrseq>;
+ bus-width = <4>;
+ non-removable;
+ no-sd;
+ no-emmc;
+ status = "okay";
+
+ brcmf: wifi@1 {
+ reg = <1>;
+ compatible = "brcm,bcm4329-fmac";
+ };
+};
+
+/* uSD */
+&usdhc2 {
+ pinctrl-names = "default", "state_100mhz", "state_200mhz";
+ pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+ pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
+ pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
+ vmmc-supply = <®_usdhc2_vmmc>;
+ vqmmc-supply = <®_usdhc2_vqmmc>;
+ cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+ bus-width = <4>;
+ no-sdio;
+ no-emmc;
+ disable-wp;
+ status = "okay";
+};
+
+&wdog1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wdog>;
+ fsl,ext-reset-output;
+ status = "okay";
+};
+
+&iomuxc {
+ pinctrl_bt_gpios: btgpiosgrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SAI5_RXD1_GPIO3_IO22 0x19
+ MX8MQ_IOMUXC_NAND_DQS_GPIO3_IO14 0x19
+ MX8MQ_IOMUXC_NAND_CLE_GPIO3_IO5 0x19
+ >;
+ };
+
+ pinctrl_ecspi2: ecspi2grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0x16
+ MX8MQ_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0x16
+ MX8MQ_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0x16
+ MX8MQ_IOMUXC_ECSPI2_SS0_ECSPI2_SS0 0x16
+ >;
+ };
+
+ pinctrl_fec1: fec1grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC 0x4
+ MX8MQ_IOMUXC_ENET_MDIO_ENET1_MDIO 0x24
+ MX8MQ_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1c
+ MX8MQ_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1c
+ MX8MQ_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1c
+ MX8MQ_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1c
+ MX8MQ_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91
+ MX8MQ_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91
+ MX8MQ_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91
+ MX8MQ_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91
+ MX8MQ_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1c
+ MX8MQ_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91
+ MX8MQ_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91
+ MX8MQ_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1c
+ MX8MQ_IOMUXC_GPIO1_IO09_GPIO1_IO9 0x19
+ >;
+ };
+
+ pinctrl_i2c1: i2c1grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_I2C1_SCL_I2C1_SCL 0x4000007f
+ MX8MQ_IOMUXC_I2C1_SDA_I2C1_SDA 0x4000007f
+ >;
+ };
+
+ pinctrl_i2c2: i2c2grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_I2C2_SCL_I2C2_SCL 0x4000007f
+ MX8MQ_IOMUXC_I2C2_SDA_I2C2_SDA 0x4000007f
+ >;
+ };
+
+ pinctrl_i2c3: i2c3grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_I2C3_SCL_I2C3_SCL 0x4000007f
+ MX8MQ_IOMUXC_I2C3_SDA_I2C3_SDA 0x4000007f
+ >;
+ };
+
+ pinctrl_i2c4: i2c4grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_I2C4_SCL_I2C4_SCL 0x4000007f
+ MX8MQ_IOMUXC_I2C4_SDA_I2C4_SDA 0x4000007f
+ >;
+ };
+
+ pinctrl_leds: ledsgrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SAI2_RXFS_GPIO4_IO21 0x19
+ MX8MQ_IOMUXC_SAI2_RXC_GPIO4_IO22 0x19
+ MX8MQ_IOMUXC_SAI3_RXFS_GPIO4_IO28 0x19
+ MX8MQ_IOMUXC_SAI3_RXC_GPIO4_IO29 0x19
+ MX8MQ_IOMUXC_SAI1_RXC_GPIO4_IO1 0x19
+ MX8MQ_IOMUXC_SAI1_RXFS_GPIO4_IO0 0x19
+ >;
+ };
+
+ pinctrl_qspi0: qspi0grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_NAND_ALE_QSPI_A_SCLK 0x82
+ MX8MQ_IOMUXC_NAND_CE0_B_QSPI_A_SS0_B 0x82
+ MX8MQ_IOMUXC_NAND_DATA00_QSPI_A_DATA0 0x82
+ MX8MQ_IOMUXC_NAND_DATA01_QSPI_A_DATA1 0x82
+ MX8MQ_IOMUXC_NAND_DATA02_QSPI_A_DATA2 0x82
+ MX8MQ_IOMUXC_NAND_DATA03_QSPI_A_DATA3 0x82
+
+ >;
+ };
+
+ pinctrl_reg_usdhc2: regusdhc2grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SD2_RESET_B_GPIO2_IO19 0x41
+ >;
+ };
+
+ pinctrl_uart1: uart1grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_UART1_RXD_UART1_DCE_RX 0x49
+ MX8MQ_IOMUXC_UART1_TXD_UART1_DCE_TX 0x49
+ >;
+ };
+
+ pinctrl_uart2: uart2grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_UART2_RXD_UART2_DCE_RX 0x49
+ MX8MQ_IOMUXC_UART2_TXD_UART2_DCE_TX 0x49
+ MX8MQ_IOMUXC_UART4_RXD_UART2_DCE_CTS_B 0x49
+ MX8MQ_IOMUXC_UART4_TXD_UART2_DCE_RTS_B 0x49
+ >;
+ };
+
+ pinctrl_uart3: uart3grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_UART3_TXD_UART3_DCE_TX 0x49
+ MX8MQ_IOMUXC_UART3_RXD_UART3_DCE_RX 0x49
+ >;
+ };
+
+ pinctrl_usdhc1: usdhc1grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK 0x83
+ MX8MQ_IOMUXC_SD1_CMD_USDHC1_CMD 0xc3
+ MX8MQ_IOMUXC_SD1_DATA0_USDHC1_DATA0 0xc3
+ MX8MQ_IOMUXC_SD1_DATA1_USDHC1_DATA1 0xc3
+ MX8MQ_IOMUXC_SD1_DATA2_USDHC1_DATA2 0xc3
+ MX8MQ_IOMUXC_SD1_DATA3_USDHC1_DATA3 0xc3
+ MX8MQ_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K 0x85
+ >;
+ };
+
+ pinctrl_usdhc1_100mhz: usdhc1-100mhzgrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK 0x8d
+ MX8MQ_IOMUXC_SD1_CMD_USDHC1_CMD 0xcd
+ MX8MQ_IOMUXC_SD1_DATA0_USDHC1_DATA0 0xcd
+ MX8MQ_IOMUXC_SD1_DATA1_USDHC1_DATA1 0xcd
+ MX8MQ_IOMUXC_SD1_DATA2_USDHC1_DATA2 0xcd
+ MX8MQ_IOMUXC_SD1_DATA3_USDHC1_DATA3 0xcd
+ MX8MQ_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K 0x85
+ >;
+ };
+
+ pinctrl_usdhc1_200mhz: usdhc1-200mhzgrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK 0x9f
+ MX8MQ_IOMUXC_SD1_CMD_USDHC1_CMD 0xdf
+ MX8MQ_IOMUXC_SD1_DATA0_USDHC1_DATA0 0xdf
+ MX8MQ_IOMUXC_SD1_DATA1_USDHC1_DATA1 0xdf
+ MX8MQ_IOMUXC_SD1_DATA2_USDHC1_DATA2 0xdf
+ MX8MQ_IOMUXC_SD1_DATA3_USDHC1_DATA3 0xdf
+ MX8MQ_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K 0x85
+ >;
+ };
+
+ pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SD2_CD_B_GPIO2_IO12 0x41
+ >;
+ };
+
+ pinctrl_usdhc2: usdhc2grp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK 0x83
+ MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD 0xc3
+ MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0 0xc3
+ MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1 0xc3
+ MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2 0xc3
+ MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3 0xc3
+ MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT 0xc1
+ >;
+ };
+
+ pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK 0x8c
+ MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD 0xcc
+ MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0 0xcc
+ MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1 0xcc
+ MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2 0xcc
+ MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3 0xcc
+ MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT 0xc1
+ >;
+ };
+
+ pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK 0x9c
+ MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD 0xdc
+ MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0 0xdc
+ MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1 0xdc
+ MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2 0xdc
+ MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3 0xdc
+ MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT 0xcc
+ >;
+ };
+
+ pinctrl_wdog: wdoggrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0xc6
+ >;
+ };
+
+ pinctrl_wifi_reg_on: wifiregongrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_NAND_CE2_B_GPIO3_IO3 0x17059
+ >;
+ };
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw
2019-10-30 9:01 [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
` (2 preceding siblings ...)
2019-10-30 9:01 ` [PATCH v2 3/4] arm64: dts: freescale: Add devicetree support for Thor96 board Manivannan Sadhasivam
@ 2019-10-30 9:01 ` Manivannan Sadhasivam
2019-11-01 13:48 ` Tudor.Ambarus
2019-11-11 19:31 ` Tudor.Ambarus
2020-01-09 3:33 ` [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
4 siblings, 2 replies; 15+ messages in thread
From: Manivannan Sadhasivam @ 2019-10-30 9:01 UTC (permalink / raw)
To: shawnguo, s.hauer, robh+dt
Cc: kernel, festevam, linux-imx, darshak.patel, prajose.john,
devicetree, linux-arm-kernel, linux-kernel,
Manivannan Sadhasivam, Marek Vasut, Tudor Ambarus,
David Woodhouse, Brian Norris, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd
Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
supports dual/quad I/O mode with 512 blocks of memory organized in
64KB sectors. In addition to this, there is also small 4KB sectors
available for flexibility. The device has been validated using Thor96
board.
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
[Mani: cleaned up for upstream]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/mtd/spi-nor/spi-nor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 1d8621d43160..2c25b371d9f0 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -2482,6 +2482,8 @@ static const struct flash_info spi_nor_ids[] = {
{ "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+ { "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
--
2.17.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw
2019-10-30 9:01 ` [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw Manivannan Sadhasivam
@ 2019-11-01 13:48 ` Tudor.Ambarus
2019-11-01 14:58 ` Manivannan Sadhasivam
2019-11-11 19:31 ` Tudor.Ambarus
1 sibling, 1 reply; 15+ messages in thread
From: Tudor.Ambarus @ 2019-11-01 13:48 UTC (permalink / raw)
To: manivannan.sadhasivam, shawnguo, s.hauer, robh+dt
Cc: kernel, festevam, linux-imx, darshak.patel, prajose.john,
devicetree, linux-arm-kernel, linux-kernel, marek.vasut, dwmw2,
computersforpeace, miquel.raynal, richard, vigneshr, linux-mtd
On 10/30/2019 11:01 AM, Manivannan Sadhasivam wrote:
> External E-Mail
>
>
> Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
> supports dual/quad I/O mode with 512 blocks of memory organized in
> 64KB sectors. In addition to this, there is also small 4KB sectors
> available for flexibility. The device has been validated using Thor96
> board.
>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
> [Mani: cleaned up for upstream]
Can we keep Darshak's authorship? We usually change the author if we feel that
we made a significant change to what was originally published.
If it's just about cosmetics, cleaning or rebase, you can specify what you did
after the author's S-o-b tag and then add your S-o-b, as you did above.
The patch looks good.
Cheers,
ta
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 1d8621d43160..2c25b371d9f0 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -2482,6 +2482,8 @@ static const struct flash_info spi_nor_ids[] = {
> { "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> + { "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw
2019-11-01 13:48 ` Tudor.Ambarus
@ 2019-11-01 14:58 ` Manivannan Sadhasivam
2019-11-01 15:55 ` Tudor.Ambarus
0 siblings, 1 reply; 15+ messages in thread
From: Manivannan Sadhasivam @ 2019-11-01 14:58 UTC (permalink / raw)
To: Tudor.Ambarus
Cc: shawnguo, s.hauer, robh+dt, kernel, festevam, linux-imx,
darshak.patel, prajose.john, devicetree, linux-arm-kernel,
linux-kernel, marek.vasut, dwmw2, computersforpeace,
miquel.raynal, richard, vigneshr, linux-mtd
Hi Tudor,
On Fri, Nov 01, 2019 at 01:48:17PM +0000, Tudor.Ambarus@microchip.com wrote:
>
>
> On 10/30/2019 11:01 AM, Manivannan Sadhasivam wrote:
> > External E-Mail
> >
> >
> > Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
> > supports dual/quad I/O mode with 512 blocks of memory organized in
> > 64KB sectors. In addition to this, there is also small 4KB sectors
> > available for flexibility. The device has been validated using Thor96
> > board.
> >
> > Cc: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Brian Norris <computersforpeace@gmail.com>
> > Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> > Cc: Richard Weinberger <richard@nod.at>
> > Cc: Vignesh Raghavendra <vigneshr@ti.com>
> > Cc: linux-mtd@lists.infradead.org
> > Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
> > [Mani: cleaned up for upstream]
>
> Can we keep Darshak's authorship? We usually change the author if we feel that
> we made a significant change to what was originally published.
>
> If it's just about cosmetics, cleaning or rebase, you can specify what you did
> after the author's S-o-b tag and then add your S-o-b, as you did above.
>
I'd suggest to keep Darshak's authorship since he did the actual change in
the bsp. I have to clean it up before submitting upstream and I mentioned
the same above.
> The patch looks good.
>
Thanks,
Mani
> Cheers,
> ta
>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > drivers/mtd/spi-nor/spi-nor.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index 1d8621d43160..2c25b371d9f0 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -2482,6 +2482,8 @@ static const struct flash_info spi_nor_ids[] = {
> > { "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > { "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512,
> > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > + { "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512,
> > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> > SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> >
> >
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw
2019-11-01 14:58 ` Manivannan Sadhasivam
@ 2019-11-01 15:55 ` Tudor.Ambarus
2019-11-01 16:09 ` Manivannan Sadhasivam
0 siblings, 1 reply; 15+ messages in thread
From: Tudor.Ambarus @ 2019-11-01 15:55 UTC (permalink / raw)
To: manivannan.sadhasivam
Cc: shawnguo, s.hauer, robh+dt, kernel, festevam, linux-imx,
darshak.patel, prajose.john, devicetree, linux-arm-kernel,
linux-kernel, marek.vasut, dwmw2, computersforpeace,
miquel.raynal, richard, vigneshr, linux-mtd
On 11/01/2019 04:58 PM, Manivannan Sadhasivam wrote:
>>> Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
>>> supports dual/quad I/O mode with 512 blocks of memory organized in
>>> 64KB sectors. In addition to this, there is also small 4KB sectors
>>> available for flexibility. The device has been validated using Thor96
>>> board.
>>>
>>> Cc: Marek Vasut <marek.vasut@gmail.com>
>>> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
>>> Cc: David Woodhouse <dwmw2@infradead.org>
>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>>> Cc: Richard Weinberger <richard@nod.at>
>>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>>> Cc: linux-mtd@lists.infradead.org
>>> Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
>>> [Mani: cleaned up for upstream]
>> Can we keep Darshak's authorship? We usually change the author if we feel that
>> we made a significant change to what was originally published.
>>
>> If it's just about cosmetics, cleaning or rebase, you can specify what you did
>> after the author's S-o-b tag and then add your S-o-b, as you did above.
>>
> I'd suggest to keep Darshak's authorship since he did the actual change in
> the bsp. I have to clean it up before submitting upstream and I mentioned
> the same above.
>
Ok, I'll amend the author when applying, it will be Darshak.
Thanks,
ta
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw
2019-11-01 15:55 ` Tudor.Ambarus
@ 2019-11-01 16:09 ` Manivannan Sadhasivam
2019-11-07 12:30 ` Tudor.Ambarus
0 siblings, 1 reply; 15+ messages in thread
From: Manivannan Sadhasivam @ 2019-11-01 16:09 UTC (permalink / raw)
To: Tudor.Ambarus
Cc: shawnguo, s.hauer, robh+dt, kernel, festevam, linux-imx,
darshak.patel, prajose.john, devicetree, linux-arm-kernel,
linux-kernel, marek.vasut, dwmw2, computersforpeace,
miquel.raynal, richard, vigneshr, linux-mtd
On Fri, Nov 01, 2019 at 03:55:01PM +0000, Tudor.Ambarus@microchip.com wrote:
>
>
> On 11/01/2019 04:58 PM, Manivannan Sadhasivam wrote:
> >>> Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
> >>> supports dual/quad I/O mode with 512 blocks of memory organized in
> >>> 64KB sectors. In addition to this, there is also small 4KB sectors
> >>> available for flexibility. The device has been validated using Thor96
> >>> board.
> >>>
> >>> Cc: Marek Vasut <marek.vasut@gmail.com>
> >>> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> >>> Cc: David Woodhouse <dwmw2@infradead.org>
> >>> Cc: Brian Norris <computersforpeace@gmail.com>
> >>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> >>> Cc: Richard Weinberger <richard@nod.at>
> >>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> >>> Cc: linux-mtd@lists.infradead.org
> >>> Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
> >>> [Mani: cleaned up for upstream]
> >> Can we keep Darshak's authorship? We usually change the author if we feel that
> >> we made a significant change to what was originally published.
> >>
> >> If it's just about cosmetics, cleaning or rebase, you can specify what you did
> >> after the author's S-o-b tag and then add your S-o-b, as you did above.
> >>
> > I'd suggest to keep Darshak's authorship since he did the actual change in
> > the bsp. I have to clean it up before submitting upstream and I mentioned
> > the same above.
> >
>
> Ok, I'll amend the author when applying, it will be Darshak.
>
Ah no. I was saying we should keep both of ours authorship. It shouldn't
be an issue because we both are involved in the process.
Thanks,
Mani
> Thanks,
> ta
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw
2019-11-01 16:09 ` Manivannan Sadhasivam
@ 2019-11-07 12:30 ` Tudor.Ambarus
2019-11-07 12:40 ` Manivannan Sadhasivam
0 siblings, 1 reply; 15+ messages in thread
From: Tudor.Ambarus @ 2019-11-07 12:30 UTC (permalink / raw)
To: manivannan.sadhasivam
Cc: shawnguo, s.hauer, robh+dt, kernel, festevam, linux-imx,
darshak.patel, prajose.john, devicetree, linux-arm-kernel,
linux-kernel, marek.vasut, dwmw2, computersforpeace,
miquel.raynal, richard, vigneshr, linux-mtd
On 11/01/2019 06:09 PM, Manivannan Sadhasivam wrote:
>> On 11/01/2019 04:58 PM, Manivannan Sadhasivam wrote:
>>>>> Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
>>>>> supports dual/quad I/O mode with 512 blocks of memory organized in
>>>>> 64KB sectors. In addition to this, there is also small 4KB sectors
>>>>> available for flexibility. The device has been validated using Thor96
>>>>> board.
>>>>>
>>>>> Cc: Marek Vasut <marek.vasut@gmail.com>
>>>>> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
>>>>> Cc: David Woodhouse <dwmw2@infradead.org>
>>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>>>>> Cc: Richard Weinberger <richard@nod.at>
>>>>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>>>>> Cc: linux-mtd@lists.infradead.org
>>>>> Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
>>>>> [Mani: cleaned up for upstream]
>>>> Can we keep Darshak's authorship? We usually change the author if we feel that
>>>> we made a significant change to what was originally published.
>>>>
>>>> If it's just about cosmetics, cleaning or rebase, you can specify what you did
>>>> after the author's S-o-b tag and then add your S-o-b, as you did above.
>>>>
>>> I'd suggest to keep Darshak's authorship since he did the actual change in
>>> the bsp. I have to clean it up before submitting upstream and I mentioned
>>> the same above.
>>>
>> Ok, I'll amend the author when applying, it will be Darshak.
>>
> Ah no. I was saying we should keep both of ours authorship. It shouldn't
> be an issue because we both are involved in the process.
There can be only one author in a patch, and multiple signers if needed:
Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Date: Wed Oct 30 14:31:24 2019 +0530
mtd: spi-nor: Add support for w25q256jw
[cut]
Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
[Mani: cleaned up for upstream]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Please read
https://www.kernel.org/doc/html/v5.3/process/submitting-patches.html, paragraph
11), and tell me if you want me to amend the author to keep Darshak's authorship
or you want to keep yours.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw
2019-11-07 12:30 ` Tudor.Ambarus
@ 2019-11-07 12:40 ` Manivannan Sadhasivam
0 siblings, 0 replies; 15+ messages in thread
From: Manivannan Sadhasivam @ 2019-11-07 12:40 UTC (permalink / raw)
To: Tudor.Ambarus
Cc: shawnguo, s.hauer, robh+dt, kernel, festevam, linux-imx,
darshak.patel, prajose.john, devicetree, linux-arm-kernel,
linux-kernel, marek.vasut, dwmw2, computersforpeace,
miquel.raynal, richard, vigneshr, linux-mtd
On Thu, Nov 07, 2019 at 12:30:05PM +0000, Tudor.Ambarus@microchip.com wrote:
>
>
> On 11/01/2019 06:09 PM, Manivannan Sadhasivam wrote:
> >> On 11/01/2019 04:58 PM, Manivannan Sadhasivam wrote:
> >>>>> Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
> >>>>> supports dual/quad I/O mode with 512 blocks of memory organized in
> >>>>> 64KB sectors. In addition to this, there is also small 4KB sectors
> >>>>> available for flexibility. The device has been validated using Thor96
> >>>>> board.
> >>>>>
> >>>>> Cc: Marek Vasut <marek.vasut@gmail.com>
> >>>>> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> >>>>> Cc: David Woodhouse <dwmw2@infradead.org>
> >>>>> Cc: Brian Norris <computersforpeace@gmail.com>
> >>>>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> >>>>> Cc: Richard Weinberger <richard@nod.at>
> >>>>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> >>>>> Cc: linux-mtd@lists.infradead.org
> >>>>> Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
> >>>>> [Mani: cleaned up for upstream]
> >>>> Can we keep Darshak's authorship? We usually change the author if we feel that
> >>>> we made a significant change to what was originally published.
> >>>>
> >>>> If it's just about cosmetics, cleaning or rebase, you can specify what you did
> >>>> after the author's S-o-b tag and then add your S-o-b, as you did above.
> >>>>
> >>> I'd suggest to keep Darshak's authorship since he did the actual change in
> >>> the bsp. I have to clean it up before submitting upstream and I mentioned
> >>> the same above.
> >>>
> >> Ok, I'll amend the author when applying, it will be Darshak.
> >>
> > Ah no. I was saying we should keep both of ours authorship. It shouldn't
> > be an issue because we both are involved in the process.
>
> There can be only one author in a patch, and multiple signers if needed:
>
> Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Date: Wed Oct 30 14:31:24 2019 +0530
>
> mtd: spi-nor: Add support for w25q256jw
> [cut]
> Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
> [Mani: cleaned up for upstream]
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Please read
> https://www.kernel.org/doc/html/v5.3/process/submitting-patches.html, paragraph
> 11), and tell me if you want me to amend the author to keep Darshak's authorship
> or you want to keep yours.
Just keep me as the author of this patch. Darshak still gets credit with his
signed-off-by tag.
Sorry for the confusion!
Thanks,
Mani
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw
2019-10-30 9:01 ` [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw Manivannan Sadhasivam
2019-11-01 13:48 ` Tudor.Ambarus
@ 2019-11-11 19:31 ` Tudor.Ambarus
1 sibling, 0 replies; 15+ messages in thread
From: Tudor.Ambarus @ 2019-11-11 19:31 UTC (permalink / raw)
To: manivannan.sadhasivam, shawnguo, s.hauer, robh+dt
Cc: kernel, festevam, linux-imx, darshak.patel, prajose.john,
devicetree, linux-arm-kernel, linux-kernel, marek.vasut, dwmw2,
computersforpeace, miquel.raynal, richard, vigneshr, linux-mtd
On 10/30/2019 11:01 AM, Manivannan Sadhasivam wrote:
> Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
> supports dual/quad I/O mode with 512 blocks of memory organized in
> 64KB sectors. In addition to this, there is also small 4KB sectors
> available for flexibility. The device has been validated using Thor96
> board.
>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
> [Mani: cleaned up for upstream]
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to spi-nor/next. Thanks.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 0/4] Add support for Thor96 board
2019-10-30 9:01 [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
` (3 preceding siblings ...)
2019-10-30 9:01 ` [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw Manivannan Sadhasivam
@ 2020-01-09 3:33 ` Manivannan Sadhasivam
2020-01-09 6:39 ` Shawn Guo
4 siblings, 1 reply; 15+ messages in thread
From: Manivannan Sadhasivam @ 2020-01-09 3:33 UTC (permalink / raw)
To: shawnguo, s.hauer, robh+dt
Cc: kernel, festevam, linux-imx, darshak.patel, prajose.john,
devicetree, linux-arm-kernel, linux-kernel
Hi Shawn,
On Wed, Oct 30, 2019 at 02:31:20PM +0530, Manivannan Sadhasivam wrote:
> Hello,
>
> This patchset adds support for Thor96 board from Einfochips. This board is
> one of the 96Boards Consumer Edition platform powered by the NXP i.MX8MQ
> SoC.
>
> Following are the features supported currently:
>
> 1. uSD
> 2. WiFi/BT
> 3. Ethernet
> 4. EEPROM (M24256)
> 5. NOR Flash (W25Q256JW)
> 6. 2xUSB3.0 ports and 1xUSB2.0 port at HS expansion
>
> More information about this board can be found in Arrow website:
> https://www.arrow.com/en/products/i.imx8-thor96/arrow-development-tools
>
> Link to 96Boards CE Specification: https://linaro.co/ce-specification
>
> Expecting patch 1 to go through LED/Rob's tree, 4 through MTD tree
> and 2,3 through Freescale tree.
>
Any update here? Patch 4 is already merged.
Thanks,
Mani
> Thanks,
> Mani
>
> Changes in v2:
>
> * Added patch for documenting commonly used LED triggers
> * Added Reviewed-by tags for bindings patch
> * Changed, fsl,uart-has-rtscts to uart-has-rtscts in dts
> * Modified the commit message of MTD patch
>
> Manivannan Sadhasivam (4):
> dt-bindings: leds: Document commonly used LED triggers
> dt-bindings: arm: Add devicetree binding for Thor96 Board
> arm64: dts: freescale: Add devicetree support for Thor96 board
> mtd: spi-nor: Add support for w25q256jw
>
> .../devicetree/bindings/arm/fsl.yaml | 1 +
> .../devicetree/bindings/leds/common.txt | 17 +
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../boot/dts/freescale/imx8mq-thor96.dts | 581 ++++++++++++++++++
> drivers/mtd/spi-nor/spi-nor.c | 2 +
> 5 files changed, 602 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2 0/4] Add support for Thor96 board
2020-01-09 3:33 ` [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
@ 2020-01-09 6:39 ` Shawn Guo
0 siblings, 0 replies; 15+ messages in thread
From: Shawn Guo @ 2020-01-09 6:39 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: s.hauer, robh+dt, kernel, festevam, linux-imx, darshak.patel,
prajose.john, devicetree, linux-arm-kernel, linux-kernel
On Thu, Jan 09, 2020 at 09:03:42AM +0530, Manivannan Sadhasivam wrote:
> Hi Shawn,
>
> On Wed, Oct 30, 2019 at 02:31:20PM +0530, Manivannan Sadhasivam wrote:
> > Hello,
> >
> > This patchset adds support for Thor96 board from Einfochips. This board is
> > one of the 96Boards Consumer Edition platform powered by the NXP i.MX8MQ
> > SoC.
> >
> > Following are the features supported currently:
> >
> > 1. uSD
> > 2. WiFi/BT
> > 3. Ethernet
> > 4. EEPROM (M24256)
> > 5. NOR Flash (W25Q256JW)
> > 6. 2xUSB3.0 ports and 1xUSB2.0 port at HS expansion
> >
> > More information about this board can be found in Arrow website:
> > https://www.arrow.com/en/products/i.imx8-thor96/arrow-development-tools
> >
> > Link to 96Boards CE Specification: https://linaro.co/ce-specification
> >
> > Expecting patch 1 to go through LED/Rob's tree, 4 through MTD tree
> > and 2,3 through Freescale tree.
> >
>
> Any update here? Patch 4 is already merged.
Just applied patch #2 and #3. For patch #1, it should go via LED or DT
tree, I think.
Shawn
^ permalink raw reply [flat|nested] 15+ messages in thread