From: Vinod Koul <vkoul@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: robh+dt@kernel.org, nm@ti.com, ssantosh@kernel.org,
dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, grygorii.strashko@ti.com,
lokeshvutla@ti.com, t-kristo@ti.com, tony@atomide.com,
j-keerthy@ti.com, vigneshr@ti.com
Subject: Re: [PATCH v7 06/12] dmaengine: ti: Add cppi5 header for K3 NAVSS/UDMA
Date: Fri, 20 Dec 2019 15:24:55 +0530 [thread overview]
Message-ID: <20191220095455.GM2536@vkoul-mobl> (raw)
In-Reply-To: <20191209094332.4047-7-peter.ujfalusi@ti.com>
On 09-12-19, 11:43, Peter Ujfalusi wrote:
> +#define CPPI5_INFO2_DESC_RETPUSHPOLICY BIT(16)
> +#define CPPI5_INFO2_DESC_RETP_MASK GENMASK(18, 16)
> +
> +#define CPPI5_INFO2_DESC_RETQ_SHIFT (0)
> +#define CPPI5_INFO2_DESC_RETQ_MASK GENMASK(15, 0)
> +
> +#define CPPI5_INFO3_DESC_SRCTAG_SHIFT (16U)
> +#define CPPI5_INFO3_DESC_SRCTAG_MASK GENMASK(31, 16)
> +#define CPPI5_INFO3_DESC_DSTTAG_SHIFT (0)
> +#define CPPI5_INFO3_DESC_DSTTAG_MASK GENMASK(15, 0)
> +
> +#define CPPI5_BUFINFO1_HDESC_DATA_LEN_SHIFT (0)
> +#define CPPI5_BUFINFO1_HDESC_DATA_LEN_MASK GENMASK(27, 0)
> +
> +#define CPPI5_OBUFINFO0_HDESC_BUF_LEN_SHIFT (0)
> +#define CPPI5_OBUFINFO0_HDESC_BUF_LEN_MASK GENMASK(27, 0)
I think you can remove the SHIFT defines and use ffs() to get the bit
position for shift
> +static inline u32 cppi5_hdesc_calc_size(bool epib, u32 psdata_size,
> + u32 sw_data_size)
> +{
> + u32 desc_size;
> +
> + if (psdata_size > CPPI5_INFO0_HDESC_PSDATA_MAX_SIZE)
> + return 0;
> +
> + desc_size = sizeof(struct cppi5_host_desc_t) + psdata_size +
> + sw_data_size;
I think there was an API for this kind of mem allocation of struct and
buffer attached...
> +static inline void cppi5_hdesc_reset_hbdesc(struct cppi5_host_desc_t *desc)
> +{
> + desc->hdr = (struct cppi5_desc_hdr_t) { 0 };
> + desc->next_desc = 0;
would this not be superfluous? Or if you want a memset call?
> +static inline u32 *cppi5_hdesc_get_psdata32(struct cppi5_host_desc_t *desc)
> +{
> + return (u32 *)cppi5_hdesc_get_psdata(desc);
you dont need casts away from void *
--
~Vinod
next prev parent reply other threads:[~2019-12-20 9:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 9:43 [PATCH v7 00/12] dmaengine/soc: Add Texas Instruments UDMA support Peter Ujfalusi
2019-12-09 9:43 ` [PATCH v7 01/12] bindings: soc: ti: add documentation for k3 ringacc Peter Ujfalusi
2019-12-09 9:43 ` [PATCH v7 02/12] soc: ti: k3: add navss ringacc driver Peter Ujfalusi
2019-12-09 9:43 ` [PATCH v7 03/12] dmaengine: doc: Add sections for per descriptor metadata support Peter Ujfalusi
2019-12-20 8:28 ` Vinod Koul
2019-12-20 9:52 ` Peter Ujfalusi
2019-12-20 10:14 ` Vinod Koul
2019-12-09 9:43 ` [PATCH v7 04/12] dmaengine: Add metadata_ops for dma_async_tx_descriptor Peter Ujfalusi
2019-12-20 8:32 ` Vinod Koul
2019-12-20 8:48 ` Peter Ujfalusi
2019-12-09 9:43 ` [PATCH v7 05/12] dmaengine: Add support for reporting DMA cached data amount Peter Ujfalusi
2019-12-20 8:37 ` Vinod Koul
2019-12-20 8:49 ` Peter Ujfalusi
2019-12-20 9:57 ` Vinod Koul
2019-12-20 10:13 ` Peter Ujfalusi
2019-12-09 9:43 ` [PATCH v7 06/12] dmaengine: ti: Add cppi5 header for K3 NAVSS/UDMA Peter Ujfalusi
2019-12-20 9:54 ` Vinod Koul [this message]
2019-12-20 10:42 ` Peter Ujfalusi
2019-12-23 7:11 ` Peter Ujfalusi
2019-12-09 9:43 ` [PATCH v7 07/12] dmaengine: ti: k3 PSI-L remote endpoint configuration Peter Ujfalusi
2019-12-09 9:43 ` [PATCH v7 08/12] dt-bindings: dma: ti: Add document for K3 UDMA Peter Ujfalusi
2019-12-23 6:53 ` Vinod Koul
2019-12-09 9:43 ` [PATCH v7 09/12] dmaengine: ti: New driver " Peter Ujfalusi
2019-12-23 7:34 ` Vinod Koul
2019-12-23 8:59 ` Peter Ujfalusi
2019-12-23 11:26 ` Vinod Koul
2019-12-09 9:43 ` [PATCH v7 10/12] dmaengine: ti: k3-udma: Add glue layer for non DMAengine users Peter Ujfalusi
2019-12-09 9:43 ` [PATCH v7 11/12] firmware: ti_sci: rm: Add support for tx_tdtype parameter for tx channel Peter Ujfalusi
2019-12-11 10:24 ` Tero Kristo
2019-12-09 9:43 ` [PATCH v7 12/12] dmaengine: ti: k3-udma: Wait for peer teardown completion if supported Peter Ujfalusi
2019-12-11 10:43 ` [PATCH v7 00/12] dmaengine/soc: Add Texas Instruments UDMA support Keerthy
2019-12-12 8:46 ` Peter Ujfalusi
2019-12-12 10:55 ` Tero Kristo
2019-12-12 10:57 ` Tero Kristo
2019-12-16 10:05 ` Peter Ujfalusi
2019-12-12 18:01 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220095455.GM2536@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).